-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors on macOS for WSL detection #36
Conversation
Also if anyone stumbles here because they're trying to fix this issue on WSL, try using grep to check for WSL. And modify the IsWSL function as necessary. The vimscript would look like: if execute "grep -q Microsoft /proc/version"
return 1
endif |
I believe we need to fix both at once, so let's wait for folks with WSL |
I am on Neovim with macOS Cataline using this plugin and I get a flashing error where the plugin is looking for Just to let you know. |
I was able to test on WSL and the error is no longer occuring. However, I did find a new bug that is unrelated but pertains to WSL. I will reference it in a new Issue. |
Should we merge? |
Probably not.. wait for a fix for #38. I'll look into it this week to figure out what the WSL problem is. |
Merged 2 pull requests, is it working fine now? |
Relating to issues #33 and #35
The problem is solely that when detecting the OS, the file
/proc/version
is read. Darwin does not contain this file so it throws an error. It's better to nest the check for WSL in thes:os == "Linux"
line.The issue may still persist (#34) that an error will be thrown on WSL that don't contain the
proc/version
file. I don't have WSL to test.This PR fixes the issue on macOS.