Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSL function resets terminal font and raises "No such file or directory" #38

Closed
hexcowboy opened this issue Sep 3, 2020 · 2 comments
Closed

WSL function resets terminal font and raises "No such file or directory" #38

hexcowboy opened this issue Sep 3, 2020 · 2 comments

Comments

@hexcowboy
Copy link
Contributor

ezgif-7-d0516241f619

The issue of #33 and #35 resulted in an error occurring, and then the s:SaveFileTMPLinux function running after the error. That issue affects macOS and WSL systems.

#36 fixed the problem for macOS and Windows. Now instead of throwing and error and running s:SaveFileTMPLinux, s:SaveFileTMPWSL is called and breaks the terminal.

My advice would be to remove the WSL function and let the s:SaveFileTMPLinux function run when WSL is detected.
@ferrine
Copy link
Collaborator

ferrine commented Sep 4, 2020 •
edited
Loading

Can you propose this workaround in the recent pr?

@hexcowboy hexcowboy mentioned this issue Sep 6, 2020
Merged
@hexcowboy
Copy link
Contributor Author

Font resetting is a product of this issue microsoft/terminal#280

@hexcowboy hexcowboy mentioned this issue Sep 7, 2020
Merged
@hexcowboy hexcowboy changed the title WSL function resets terminal font and causes other bugs WSL function resets terminal font and raises "No such file or directory" Sep 7, 2020
This was referenced Sep 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hexcowboy @ferrine