This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat: ✨ e2ee support (old) #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The functionality of the code looks fine. Note that you will have to document that users need to install libolm>=3.0.0 as a native dependency in order for matrix-nio[e2e] to build correctly.
https://github.com/anoadragon453/nio-template/blob/master/SETUP.md has some documentation in this area.
ghost
marked this pull request as ready for review
This reverts commit 8cb9b46.
this way sessions are reused if possible. it is especially necessary to keep e2e sessions.
4 tasks
it can be imported from callbacks.py and added to callbacks manually if
user wants to enable it:
```python
async def verify(event):
await emoji_verification(bot.async_client, event)
bot.async_client.add_to_device_callback(verify, KeyVerificationEvent)
```
ghost
force-pushed
the
master
branch
2 times, most recently
from
a711bef to
e95148d
Compare
|
(is this blocked on me currently?) |
|
(no, this is blocked on my free time vs the todos in the OP |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first step to #76
thanks to and kindly asking for review from @anoadragon453
Also this is my first time productively using poetry, so please tell me what I still need to learn.
todo: