-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
This reverts commit 8cb9b46.
this way sessions are reused if possible. it is especially necessary to keep e2e sessions.
it can be imported from callbacks.py and added to callbacks manually if user wants to enable it: ```python async def verify(event): await emoji_verification(bot.async_client, event) bot.async_client.add_to_device_callback(verify, KeyVerificationEvent) ```
can be activated by config option
How do you want to handle the dependency problem in the CI? |
We should check if encryption dependencies are installed either through something involving https://github.com/poljar/matrix-nio/blob/20ac350d015b9fb1363482661a1d9d26e28914c1/nio/crypto/__init__.py#L41, or through an try-except ImportError check. |
If that check is false, then changes such as setting https://github.com/HarHarLinks/simple-matrix-bot-lib/blob/182f30e608ac379eacb64e14e6b57904eda88000/simplematrixbotlib/api.py#L56 to false should be made. |
Don't we need to adapt the CI to also run with e2e deps installed as to properly test the e2e stuff just the same? At this point I'm not familiar with how to do that. |
I"m not familiar either. Perhaps we could create an e2e-specific github action test. |
This might be a convenient way to install olm (from the maubot docs) |
From https://docs.mau.fi/maubot/usage/encryption.html to be precise, although there is a warning
I don't think this should be the preferred option, because the distro-packaged library would (maybe automatically) get updated if and when a security patch releases |
based on openSUSE experience
supersedes #79
I rebased this on current-ish (~ last week's) master because the situation got a bit messy with half a year of changes
todos transfered from original PR:
notify + log when the crypto session broke incl hint to reset access_token and crypto store: compare access_token -> session ID -> crypto dbnot sure how to detect this broken statedo/not listen to unverified?deferred to #150by mxid (regex?)deferred to #151list of users to automatically verifylist of users to automatically "ignore" i.e. send without verificationSAS decimal?supported in nio, but deferred to #152QR code?doesn't look like nio supports it, deferred to lateradd simplematrixbotlib[e2e] extra which pulls in matrix-nio[e2e]poetry currently can't specify extras to pull in extras Change dependency's extras through own extras python-poetry/poetry#6053