Code

Add tests for resource limits#2085

Code

Merged

fintelia merged 28 commits intoimage-rs:masterimage-rs/image:masterfrom Shnatsel:limit-testsShnatsel/image:limit-testsCopy head branch name to clipboardJan 6, 2024

+229

Commits

Commits on Jan 4, 2024

• Add initial tests for adherence to resolution and resource limits; so far only covers GIF

  Shnatsel

  committed
  a543a80

• Note absence of tests for animation

  Shnatsel

  committed
  4ea84ec

• Add PNG limit tests

  Shnatsel

  committed
  dc72466

• Also check allocation limits in the default implementation of set_limits

  Shnatsel

  committed
  95ef3c7

• Uncomment tests fixed by the allocation check in the blanket set_limits impl

  Shnatsel

  committed
  fac37ba

• Drop an unnecesary import

  Shnatsel

  committed
  2892d88

• Silence deprecation warning to fix CI

  Shnatsel

  committed
  c1ae486

• Improve comment

  Shnatsel

  committed
  ccdbb36

• Refactor tests to use constants more

  Shnatsel

  committed
  2347ebd

• Add tests verifying that the limits are not overly restrictive

  Shnatsel

  committed
  1dac0ce

• Revert blanket impl for limits - it interacts poorly with the reader, resulting in overly restrictive limits

  Shnatsel

  committed
  91672f5

• Comment out broken tests

  Shnatsel

  committed
  e6c006a

• Add JPEG limits test

  Shnatsel

  committed
  94d9c12

• Uncomment a test that's actually working

  Shnatsel

  committed
  ebd7fa3

• Reintroduce a comment about animation not being covered

  Shnatsel

  committed
  dc2377b

• Fix a rustfmt goof

  Shnatsel

  committed
  d142f6e

• Add resource limit tests for WebP

  Shnatsel

  committed
  38d2a9c

• Move format-specific methods to the end to make them stand out more

  Shnatsel

  committed
  30b6222

• Fix rustfmt goof again

  Shnatsel

  committed
  ccc817b

• More newlines for readability

  Shnatsel

  committed
  98c0da3

• Add a comment on the PNG brokenness

  Shnatsel

  committed
  11125a6

• Add a test for TIFF limits, which have their own interesting brokenness

  Shnatsel

  committed
  d951a0a

• Add a test for AVIF limits

  Shnatsel

  committed
  0527089

• Add a test for BMP limits

  Shnatsel

  committed
  53755fc

• cargo fmt

  Shnatsel

  committed
  2f63f1c

• Cleaner integer type conversions

  Shnatsel

  committed
  fb6eb40

• Add a note that the png with_limits may actually be intended behavior

  Shnatsel

  committed
  128158f

Commits on Jan 6, 2024

• Fix tests based on PR review feedback

  Shnatsel

  committed
  5c375c8