Add tests for resource limits #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… far only covers GIF
|
The fix actually broke some other stuff, so I'm going to make this PR purely about tests and then chip away at the test failures in subsequent PRs. |
Shnatsel
changed the title
.set_limits() impl
|
This is now ready for review. Since this only adds tests, the changes should be uncontroversial and won't break anything. I'll propose fixes in subsequent PRs once this is merged. |
fintelia
reviewed
Jan 4, 2024
|
The tests now cover the existing API surface and verify that the parts that are already in place work correctly. I'll leave tests for and implementation of resource limits in animation to follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests verifying that all decoding APIs enforce the resource limits.
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option.