340 validator increase performance by leveraging activestorageblob analyzed feature #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorkasyanchuk
approved these changes
Jan 12, 2025
Mth0158
force-pushed
the
340-validator-increase-performance-by-leveraging-activestorageblob-analyzed-feature
branch
5 times, most recently
from
3b222bb to
07f9679
Compare
Mth0158
force-pushed
the
340-validator-increase-performance-by-leveraging-activestorageblob-analyzed-feature
branch
from
07f9679 to
3a858be
Compare
igorkasyanchuk
deleted the
340-validator-increase-performance-by-leveraging-activestorageblob-analyzed-feature
branch
igorkasyanchuk
pushed a commit
that referenced
this pull request
Jan 24, 2025
* [Analyzer] Refacto our image analyzers to further expand the gem (#254) * [Analyzer] Improve tempfile usage and remove useless code * [Analyzer] Add test for rotated image * [Analyzer] Fix issue with tempfile (#266) * [Analyzer] Ensure tempfile is always closed * [Analyzer] Correct rotated image test * [Readme] Rework additional info section * [Readme] Reword installation section * [Readme] Reword title section * [Readme] Reword validator section and its first 2 validators * [Readme] Reword size validator section * [Readme] Reword total_size validator section * [Readme] Reword dimension validator section * [Readme] Add upgrading from 1.x to 2.x section * [Readme] Reword limit validator section * [Readme] Reword aspect_ratio validator section * [Readme] Reword processable_image validator section * [Readme] Remove usage section * [Readme] Rework contributing section * [Readme] Rework test matchers section * [Readme] Remove sample section * [Readme] Rework I18n section * [Readme] Rework content_type spoofing section * [Readme] Add best practices for content_type validator * [Readme] Add best practices for size validator * [Readme] Add pending TODOs * Fixed typo in README in test matcher section. * [Analyzer] Add video analyzer (#255) * [ContentSpoof] Slight refacto for open3 command * [Analyzer] Add explicit open3 require * [CI] Add FFmpeg install in CI * [Validator/Matcher] Add most_common_mime_types tests for content_type validator * [Validator] Correct failing ensure_content_types_validity * [Validator] Add dedicated error for 'image/jpg' content type * [Readme] Improve size validator best practices section (#317) * [Merge] Correct merge issues * [Merge] Correct merge issues * [Readme] Update aspect_ratio validator part * [Analyzer] Add audio analyzer (#301) rb * [Analyzer] Round video duration like audio one * [Error] Change image_metadata_missing to media_metadata_missing * [Error] Update aspect_ratio error messages * [Error] Update content_type spoofed error messages * [Error] Update content_type error messages rb * [Error] Update limit error messages * [Error] Update dimension error messages * [Error] Fix failing test for limit validator * [Test] Change to right order for assert_equal * [Validator] Replace processable_image validator to processable_file (#314) * [Validator] Refacto BaseComparisonValidator * [Validator] Add duration validator (#304) * [Matcher] Add duration validator matcher * [Analyzer] Fix failing test * [Analyzer] Refacto content_type_spoof_detector into an analyzer (#334) * [Validator] Enhance content_type spoof errors * [Analyzer] Fix failing tests * [Validator] Handle content_type with parameters properly * 340 validator increase performance by leveraging activestorageblob analyzed feature (#341) * [Validator] Update base iterable method for attachables * [Validator] Improve performance leveraging ActiveStorage::Blob#metadata metadata (#340) * [Validator] Refine our performance improvement * [Validator] Add content_type spoof in blob metadata * [Validator] Handle edge case for has_one_attached (#193) * [Doc] Refine readme before release * [Changes] Add v2 changes * [Analyzer] Fix unused variable warning * [CI] Update Github actions --------- Co-authored-by: Andreas Dausenau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.