Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle video media #255

Closed
Mth0158 opened this issue Jul 19, 2024 · 1 comment
Closed

Handle video media #255

Mth0158 opened this issue Jul 19, 2024 · 1 comment
Assignees
@Mth0158
Labels
enhancement New feature or request v2 Features for releasing v2

Comments

@Mth0158
Copy link
Collaborator

Mth0158 commented Jul 19, 2024 •
edited
Loading

We could add a few validators for audio & video files. We would need something to analyse such files and ... tada! There is already one built-in Rails around FFMPEG:

We would then just have to build the validations on top on the retrieved metadata, that wouldn't be such a big issue I guess :) A bit of work yes but nothing too hard.

@igorkasyanchuk & @gr8bit what do you think?
@Mth0158 Mth0158 added the enhancement New feature or request label Jul 19, 2024
@Mth0158 Mth0158 changed the title Add validators for audio & video Add validators for video Nov 25, 2024
@Mth0158 Mth0158 changed the title Add validators for video Handle video media Nov 25, 2024
Mth0158 added a commit that referenced this issue Nov 26, 2024
@Mth0158
[Analyzer] Add video analyzer (#255)
6f40e62
@Mth0158 Mth0158 self-assigned this Nov 26, 2024
@Mth0158 Mth0158 added the v2 Features for releasing v2 label Nov 26, 2024
This was referenced Nov 26, 2024
Closed
Merged
Mth0158 added a commit that referenced this issue Nov 26, 2024
@Mth0158
[Analyzer] Add video analyzer (#255)
5c38a87
Mth0158 added a commit that referenced this issue Dec 4, 2024
@Mth0158
[Analyzer] Add video analyzer (#255)
6b3e679
@Mth0158
Copy link
Collaborator Author

Mth0158 commented Dec 21, 2024

Merged in #310

@Mth0158 Mth0158 closed this as completed Dec 21, 2024
igorkasyanchuk pushed a commit that referenced this issue Jan 24, 2025
@Mth0158
V2 (#310)
da80c1a 
* [Analyzer] Refacto our image analyzers to further expand the gem (#254)

* [Analyzer] Improve tempfile usage and remove useless code

* [Analyzer] Add test for rotated image

* [Analyzer] Fix issue with tempfile (#266)

* [Analyzer] Ensure tempfile is always closed

* [Analyzer] Correct rotated image test

* [Readme] Rework additional info section

* [Readme] Reword installation section

* [Readme] Reword title section

* [Readme] Reword validator section and its first 2 validators

* [Readme] Reword size validator section

* [Readme] Reword total_size validator section

* [Readme] Reword dimension validator section

* [Readme] Add upgrading from 1.x to 2.x section

* [Readme] Reword limit validator section

* [Readme] Reword aspect_ratio validator section

* [Readme] Reword processable_image validator section

* [Readme] Remove usage section

* [Readme] Rework contributing section

* [Readme] Rework test matchers section

* [Readme] Remove sample section

* [Readme] Rework I18n section

* [Readme] Rework content_type spoofing section

* [Readme] Add best practices for content_type validator

* [Readme] Add best practices for size validator

* [Readme] Add pending TODOs

* Fixed typo in README in test matcher section.

* [Analyzer] Add video analyzer (#255)

* [ContentSpoof] Slight refacto for open3 command

* [Analyzer] Add explicit open3 require

* [CI] Add FFmpeg install in CI

* [Validator/Matcher] Add most_common_mime_types tests for content_type validator

* [Validator] Correct failing ensure_content_types_validity

* [Validator] Add dedicated error for 'image/jpg' content type

* [Readme] Improve size validator best practices section (#317)

* [Merge] Correct merge issues

* [Merge] Correct merge issues

* [Readme] Update aspect_ratio validator part

* [Analyzer] Add audio analyzer (#301)

rb

* [Analyzer] Round video duration like audio one

* [Error] Change image_metadata_missing to media_metadata_missing

* [Error] Update aspect_ratio error messages

* [Error] Update content_type spoofed error messages

* [Error] Update content_type error messages

rb

* [Error] Update limit error messages

* [Error] Update dimension error messages

* [Error] Fix failing test for limit validator

* [Test] Change to right order for assert_equal

* [Validator] Replace processable_image validator to processable_file (#314)

* [Validator] Refacto BaseComparisonValidator

* [Validator] Add duration validator (#304)

* [Matcher] Add duration validator matcher

* [Analyzer] Fix failing test

* [Analyzer] Refacto content_type_spoof_detector into an analyzer (#334)

* [Validator] Enhance content_type spoof errors

* [Analyzer] Fix failing tests

* [Validator] Handle content_type with parameters properly

* 340 validator increase performance by leveraging activestorageblob analyzed feature (#341)

* [Validator] Update base iterable method for attachables

* [Validator] Improve performance leveraging ActiveStorage::Blob#metadata metadata (#340)

* [Validator] Refine our performance improvement

* [Validator] Add content_type spoof in blob metadata

* [Validator] Handle edge case for has_one_attached (#193)

* [Doc] Refine readme before release

* [Changes] Add v2 changes

* [Analyzer] Fix unused variable warning

* [CI] Update Github actions

---------

Co-authored-by: Andreas Dausenau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mth0158 Mth0158

Labels
enhancement New feature or request v2 Features for releasing v2
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

255-handle-video-media igorkasyanchuk/active_storage_validations
1 participant
@Mth0158