Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename CLI "plugin" command to "app" #3662

Merged
merged 21 commits into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0c89b4d
refactor: rename "plugin" to "app"
jeronimoalbi Sep 20, 2023
f6b1749
refactor: simplify code
jeronimoalbi Sep 20, 2023
f979000
chore: update changelog
jeronimoalbi Sep 20, 2023
da5d88b
tests: fixed unit tests
jeronimoalbi Sep 20, 2023
772e77e
tests: fix integration tests
jeronimoalbi Sep 20, 2023
ad47e30
chore: change plugin template to use `app` as the type name
jeronimoalbi Sep 20, 2023
f2a1692
chore: update plugin code documentation to use "app" instead
jeronimoalbi Sep 20, 2023
161b980
tests: fixed service unit tests
jeronimoalbi Sep 20, 2023
a145c52
chore: update comments
jeronimoalbi Sep 25, 2023
5d17483
chore: fix typo
jeronimoalbi Sep 25, 2023
8e3292e
chore: improve command description
jeronimoalbi Sep 25, 2023
be98c9d
chore: restore plugin to test case names
jeronimoalbi Sep 25, 2023
7cf5b1b
chore: remove commented unit test code
jeronimoalbi Sep 25, 2023
73cbc38
Merge branch 'main' into feat/ignite-apps
jeronimoalbi Sep 26, 2023
1be2cbb
Merge branch 'main' into feat/ignite-apps
Pantani Sep 27, 2023
0a592fa
Merge branch 'main' into feat/ignite-apps
jeronimoalbi Sep 28, 2023
6c638ba
Merge branch 'main' into feat/ignite-apps
jeronimoalbi Oct 2, 2023
3b96b47
chore: change app commands to properly set example command
jeronimoalbi Oct 2, 2023
b0a3d76
chore: remove redundant plugin path check
jeronimoalbi Oct 2, 2023
2c2fdca
Merge branch 'main' into feat/ignite-apps
jeronimoalbi Oct 4, 2023
8cce8b2
Merge branch 'main' into feat/ignite-apps
jeronimoalbi Oct 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- [#3658](https://github.com/ignite/cli/pull/3658) Rename Marshaler to Codec in EncodingConfig
- [#3653](https://github.com/ignite/cli/pull/3653) Add "app" extension to plugin binaries
- [#3656](https://github.com/ignite/cli/pull/3656) Disable Go toolchain download
- [#3662](https://github.com/ignite/cli/pull/3662) Refactor CLI "plugin" command to "app"

### Fixes

Expand Down
8 changes: 4 additions & 4 deletions ignite/cmd/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
)

// New creates a new root command for `Ignite CLI` with its sub commands.
// Returns the cobra.Command, a cleanUp function and an error. The cleanUp
// function must be invoked by the caller to clean eventual plugin instances.
// Returns the cobra.Command, a cleanup function and an error. The cleanup
// function must be invoked by the caller to clean eventual Ignite App instances.
func New(ctx context.Context) (*cobra.Command, func(), error) {
cobra.EnableCommandSorting = false

Expand Down Expand Up @@ -78,14 +78,14 @@
NewTools(),
NewDocs(),
NewVersion(),
NewPlugin(),
NewApp(),

Check warning on line 81 in ignite/cmd/cmd.go

View check run for this annotation

Codecov / codecov/patch

ignite/cmd/cmd.go#L81

Added line #L81 was not covered by tests
NewDoctor(),
)
c.AddCommand(deprecated()...)

// Load plugins if any
if err := LoadPlugins(ctx, c); err != nil {
jeronimoalbi marked this conversation as resolved.
Show resolved Hide resolved
return nil, nil, fmt.Errorf("error while loading plugins: %w", err)
return nil, nil, fmt.Errorf("error while loading apps: %w", err)

Check warning on line 88 in ignite/cmd/cmd.go

View check run for this annotation

Codecov / codecov/patch

ignite/cmd/cmd.go#L88

Added line #L88 was not covered by tests
}
return c, UnloadPlugins, nil
}
Expand Down
Loading
Loading