Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename CLI "plugin" command to "app" #3662

Merged
merged 21 commits into from
Oct 5, 2023
Merged

refactor: rename CLI "plugin" command to "app" #3662

merged 21 commits into from
Oct 5, 2023

Conversation

jeronimoalbi
Copy link
Member

No description provided.

@jeronimoalbi jeronimoalbi added type:refactor component:extensions Related to Ignite Extensions. labels Sep 20, 2023
@jeronimoalbi jeronimoalbi self-assigned this Sep 20, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd type:services Service-related issues. component:packages labels Sep 20, 2023
@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented Sep 25, 2023 •
edited
Loading

Commands were changed to:

Create and manage Ignite Apps

Usage:
  ignite app [command]

Available Commands:
  list        List installed apps
  update      Update app
  scaffold    Scaffold a new Ignite App
  describe    Print information about installed apps
  install     Install app
  uninstall   Uninstall app

@jeronimoalbi jeronimoalbi marked this pull request as ready for review September 25, 2023 10:13
Ehsan-saradar
Ehsan-saradar suggested changes Sep 25, 2023
View reviewed changes
ignite/cmd/plugin_test.go Outdated Show resolved Hide resolved
@Pantani Pantani mentioned this pull request Sep 25, 2023
Closed
Pantani
Pantani reviewed Sep 27, 2023
View reviewed changes
ignite/cmd/cmd.go Show resolved Hide resolved
ignite/cmd/plugin.go Show resolved Hide resolved
ignite/cmd/plugin_default.go Outdated Show resolved Hide resolved
ignite/cmd/plugin_default.go Show resolved Hide resolved
ignite/cmd/plugin_test.go Show resolved Hide resolved
ignite/services/plugin/cache.go Outdated Show resolved Hide resolved
integration/plugin/plugin_test.go Show resolved Hide resolved
ignite/config/plugins/config.go Outdated Show resolved Hide resolved
ignite/config/plugins/config.go Show resolved Hide resolved
julienrbrt
julienrbrt previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm!
I agree it will feel better once the codebase and the user facing prompts are both named apps.

Just one nit about using the Example field in cobra instead of having it in the long description.

ignite/cmd/plugin.go Outdated Show resolved Hide resolved
ignite/cmd/plugin.go Outdated Show resolved Hide resolved
ignite/cmd/plugin.go Outdated Show resolved Hide resolved
ignite/cmd/plugin.go Outdated Show resolved Hide resolved
ignite/cmd/plugin_default.go Outdated Show resolved Hide resolved
ignite/cmd/plugin_default.go Show resolved Hide resolved
julienrbrt
julienrbrt previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

@Pantani Pantani self-requested a review October 4, 2023 11:37
Pantani
Pantani previously approved these changes Oct 4, 2023
View reviewed changes
@jeronimoalbi jeronimoalbi dismissed stale reviews from Pantani and julienrbrt via 2c2fdca October 4, 2023 13:57
@jeronimoalbi jeronimoalbi mentioned this pull request Oct 5, 2023
Merged
julienrbrt
julienrbrt approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@jeronimoalbi jeronimoalbi merged commit 88ffe62 into main Oct 5, 2023
26 checks passed
@jeronimoalbi jeronimoalbi deleted the feat/ignite-apps branch October 5, 2023 10:27
@salmad3 salmad3 mentioned this pull request Jul 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:extensions Related to Ignite Extensions. component:packages type:internal type:refactor type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeronimoalbi @Pantani @Ehsan-saradar @julienrbrt