Use "selector" instead of "matcher" #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I particularly welcome @gregsdennis's comments since he raised #20. |
gregsdennis
requested changes
Sep 24, 2020
| Each selector acts on its input list of nodes as follows. For each | ||
| node in the list, the selector selects zero or more nodes, each of | ||
| which is a descendant of the node or the node itself. The output | ||
| list of nodes of a selector is the concatenation of the lists of |
There was a problem hiding this comment.
"distinct concatenation"
There was a problem hiding this comment.
Does distinct concatenation mean with duplicates removed? That term is unfamiliar to me.
There was a problem hiding this comment.
Correct, no duplicates. I think mine currently regards the same value from different locations as distinct from one another, meaning it'll keep both.
It's worth discussing further, probably. Maybe just merge this for now, and I'll open an issue for it.
There was a problem hiding this comment.
Yes, I'd like to keep that as a separate issue. It's somewhat related to the placeholder we have in the spec about whether to remove duplicates from unions.
gregsdennis
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
See the rendered HTML version of this PR.