Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify terms #20

Closed
gregsdennis opened this issue Sep 24, 2020 · 5 comments · Fixed by #22
Closed

Unify terms #20

gregsdennis opened this issue Sep 24, 2020 · 5 comments · Fixed by #22
Assignees

Comments

@gregsdennis
Copy link
Collaborator

gregsdennis commented Sep 24, 2020

Sometimes in the draft, as it currently is, the terms "matcher," "selector," and "filter" seem to be used interchangeably. These terms need to be explicitly defined, and where we have synonyms, we should only use one.

Personally, I'm in favor of "selector" for everything since JSON Path is technically a query language. "Matcher", to me, sounds redundant when talking about its action: "A matcher may match a node and, if it matches, ..." (Section 2.5). Using the word "selector" here reduces some of the redundancy.

@glyn
Copy link
Collaborator

glyn commented Sep 24, 2020

Are we looking at the same draft and version? https://jsonpath-standard.github.io/internet-draft/ does not use the term filter, you see.

@gregsdennis
Copy link
Collaborator Author

I think I picked up "filter" from one of my issues. Still, we should use a single term.

It looks like we've made an effort to define "matcher," but "selector" sounds more appropriate to me.

@glyn glyn self-assigned this Sep 24, 2020
@glyn
Copy link
Collaborator

glyn commented Sep 24, 2020

Ok, I'll take a crack at this.

@remorhaz
Copy link
Contributor

Filter is a ?(...) construction. In fact, it's concrete case of a union-element.

@glyn
Copy link
Collaborator

glyn commented Sep 24, 2020

Right, let's ignore filters for this issue. I'll see if we can replace "matcher" with "selector" sensibly.

glyn added a commit to glyn/internet-draft that referenced this issue Sep 24, 2020
@glyn glyn closed this as completed in #22 Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants