Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#65 Fixes No value passed error in prometheus metrics #66

Merged
merged 1 commit into from
Oct 19, 2019

Conversation

jmonterrubio
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

Updated prometheus config file checking nil value before updating timed metrics

Benefits

Fixes No value passed error in prometheus metrics

Applicable Issues

#65

@jmonterrubio jmonterrubio merged commit 595b97f into develop Oct 19, 2019
@jmonterrubio jmonterrubio deleted the bugs/65 branch October 19, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants