Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recommended setting validation_query_timeout to dbconfig.xml #18

Merged
merged 4 commits into from
May 21, 2019

Conversation

mmolinac
Copy link
Contributor

@mmolinac mmolinac commented Jan 16, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

At JIRA startup, you may receive a message about configuring validation_query_timeout in dbconfig.xml as a recommendation.
I've setup recommended values for MySQL and the same default values for Oracle and MSSQL, although they only recommend a default value for MySQL.

Benefits

Follow Atlassian direction about MySQL configuration.

Possible Drawbacks

None that I know of.

Applicable Issues

Fixes #20

@mmolinac
Copy link
Contributor Author

Hmm. The Java version problem striked the test suite again, I'm afraid.

@jnogol jnogol changed the base branch from master to develop January 18, 2019 13:10
@jnogol
Copy link

jnogol commented Jan 18, 2019

It's freaking annoying. Could you please update the Changelog with this PR's change and https://github.com/idealista/jira_role/blob/master/molecule/default/requirements.yml#L3 to 3.4.2?

Thank you very much for your contributions 👏

@mmolinac
Copy link
Contributor Author

@jnogol Done!

@jnogol jnogol merged commit 3ba1f37 into idealista:develop May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants