Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bs4 fix update consumer error #4480

Merged

Conversation

charlienparker
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements

  • The title follows our guidelines
  • Tests for the changes have been added (for bugfixes/features), they use let helpers and before blocks
  • For all UI changes, there is cucumber coverage
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, reasoning is documented in PR and code
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run it is documented on both the PR and in the code
  • There are no inline styles added
  • There are no inline javascript added
  • There is no hard coded text added/updated in helpers/views/Javascript. New/updated translation strings do not include markup/styles, unless there is supporting documentation
  • Code does not use .html_safe
  • All images added/updated have alt text
  • Doesn’t bypass rubocop rules in any way

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: https://www.pivotaltracker.com/story/show/188226926

Copy link
Contributor

@kristinmerbach kristinmerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristinmerbach kristinmerbach merged commit beda78e into clean-bootstrap-4-upgrade Sep 5, 2024
104 of 112 checks passed
@kristinmerbach kristinmerbach deleted the bs4-fix-update-consumer-error branch September 5, 2024 16:52
kristinmerbach pushed a commit that referenced this pull request Sep 6, 2024
kristinmerbach pushed a commit that referenced this pull request Sep 10, 2024
polographer pushed a commit that referenced this pull request Sep 11, 2024
* bs4 review app fixes (#4188)

* update reason translation, remove required logic on dds and helper, update dd/dls to favor dl content when it is long

* phone number display check fix

* translation cleanup

mc

* Fix faa job phone bug (#4212)

fix job phone number bug

* use plan shopping partial for shopping details (#4205)

Signed-off-by: kristinmerbach <[email protected]>

* bs4 benefits fix edit esi (#4210)

* fix insurance kind bug for esi view, fix employee cost bug, store insurance fields in data for esi, update js to use new data esi values for esi edit functionality

* remove unneeded diff

* Refactor the faa eligibility results accordion UI navigation. (#4211)

* bs4 fix fa doc title (#4216)

fix variable name

* chore: update form styles for checkboxes and radio buttons (#4213)

* bs4 fix sep tooltips (#4207)

* fix tooltip hide, update qle tooltip for bs4 to be right aligned, update js to hide tooltip on click

* use template instead of style to override broken fade

* general spec fixes for bootstrap upgrade (#4193)

* family members controller spec fixes

* rspec fixes

* bs4 fix personal edit (#4202)

* move edit personal container to above dependent list, fix show.js to not fail on family info page, fix personal cancel button, fix FA consumer demo fields header

* update consumer header to default to this person, rename this person key to be agnostic to other questions

mc

* bs4 add outline for missing (#4214)

* add check for nil relation

* remove missing banner

* chore: Update enrollment actions dropdown item class in families view (#4215)

* bs4 fix sep focus tooltip (#4221)

add focus tooltip, remove unneeded tooltip attrs for bs4

* bs4 benefits fixes (#4217)

* update translation for hra field, fix logic error in esi helper, fix hra arg to helper call in add new

* require fields

* layout fixes

* more required fixes

* fix hra modal

* fix esi modal modal

* dry esi handling

* layout work for breakpoints, further edit refactor

* fix hra check

* fix hra check, add missing closing tag

* further layout cleanup

* margin fixes

* fix insurance_kind for non-esi

* require start date for non-esi

* add address fields

* bs4 family info edit primary fix (#4223)

* Updates to scenarios for Insured consumer flow dc (#3990)

* update admin consumer steps

* update pom libaries

* disable bs4 for individual features

* diable bs4 consumer flow insured folder dc

* update disable bs4 for dc

* update scenarios for dc client

* update scenarios for dc and maine

* update scenarios for dc

* update maine and dc scenarios

* update dc account creation steps

* remove unnecessarry comments #binding.irb

* update wait for eligiblity response feature for maine and dc

* update account creation feature for dc

* update documents_page feature for dc

* update household coverage page feature for dc

* update message pages feature for dc

* update individual_sep_signup feature for dc

* update contast level aa scenarios for maine

* update help_me_sign_up_steps

* update dc insured scenarios

* update other income scenarios for dc

* update individual_sep_signup scenarios for dc

* update individual_with_existing_sep scenarios for dc

* add wait to individual steps for dc

* disable bs4 changes for manage family personal information dc

* update ageoff_sep_employee_adding_dependent scenario for dc

* update household_info_continue_button_steps for dc

* update health_coverage scenario

* update continue button for dc

* udate contrast level aa scenarios and remove comments from feature file

* update comments around bugs introduce with details

* update individual steps for maine

* update job income steps for dc

* update job income POM

* update health coverage pom locators

* fix health coverage eligible question

* print cucumber failures in summary (#3987)

* adding cucumber failures to summary

* trying another way to pipe it

* trying with tee instead of just redirection

* tee didn't work

* print error on screen too

* update accessbility scenarios

* more FAA cleanup

* tax info continue button selector

* tax info scnearios

* missing translations

* waiting for results cucumber

* start on manage seps

* don't use new bootstrap layout

* convert response_id to string

* more welcome screen work

* ridp continue button

* proper log out location

* update individual steps for dc

---------

Co-authored-by: Diana Quisbert <[email protected]>
Co-authored-by: Kristin Merbach <[email protected]>
Co-authored-by: Marco (Polo) Ornelas <[email protected]>
Co-authored-by: Alec Turnbull <[email protected]>

mc

* add html sanitization as needed (#4112)

* add html sanitization as needed

* always check app scan

mc

* use readonly attrs for ssn and dob, add readonly selector following disabled style, fix applicants partial to load primary attrs correctly

* rebase cleanup

---------

Co-authored-by: quisbertdiana <[email protected]>
Co-authored-by: kristinmerbach <[email protected]>

* bs4 fix benefits household income input (#4230)

remove redundant for, fix id so js can listen to post

* header and footer cleanup (#4176)

* header and footer cleanup

* fix rubocop

* revise based on PR comments

* more header cleanup

* include missing file

* don't display text til logged in, don't link unless portal available

* push file change missed

* bs4 plan shopping with aptc, remove default (#4231)

* remove default option for param

* remove default option for param

* bs4 fix family edit kb nav (#4227)

* set tabindex and blur on edit button

* defocus and set tab index for dep edit buttons

* fix translations for financial assistance other incomes (#4229)

* fix translations for financial assistance other incomes

* Fix translations for financial assistance other incomes

* fix other actions accordion style and a11y (#4233)

* bs4 fix dependent address fields on applying (#4239)

add missing closing tag

* chore: Update enrollment actions dropdown item class in families view (#4236)

* bs4 fix vlp primary fields (#4238)

* include manage family in vlp update check - not sure either referrer check is really needed

* gate referrer check for bs4

* bs4 fix mh warning banner (#4232)

add warning 2 translation and markup

* rspec fixes (#4226)

* fix hsa tooltip translation (#4243)

* submit your application fixes (#4244)

submit your application page changes

* fix portal links (#4245)

fix portals links for consumers

* bs4 fix mh edit buttons (#4234)

* add cancel/save buttons to row, display them when edit and hide edit

* add cancel/save buttons to row and update edit/personal js to handle hiding edit and showing these, add handling for new save, remove unneeded member id edit in favor of finding the edit in the given container

* translation cleanup

* fix add new buttons

* reset edit buttons on destroy

* bs4 health coverage delete fixes (#4241)

* make sure asterisks show when css is disabled (#4248)

* Cuke dc fixes (#4240)

* test disabling feature prior to tests

* add disable

* try moving disable

* test one other thing

* remove test group 45

* more reordering

* small note on test

* restore config to origin

* fix config order

* fix warning

* codeql

* bearer failure

* bearer failure

* bearer failure

* refactor: Update plan shopping filters and summary display (#4246)

* refactor: Update plan shopping filters and summary display

* add translation for filter and sort

* chore: fix plan shopping receipt print layout (#4253)

* make sure validations are available for the personal form (#4252)

* bs4 family info fix immigrant fields (#4256)

move script end tag to allow field div to load for bs4, fix exp date parsing

* when application is not a draft, show view all applications link (#4249)

* fix needs coverage primary member (#4258)

fix needs coverage bug

* add class used for mask to zip field (#4262)

* add missing benefit page asterisks (#4257)

add missing required details

* add secondary check for continue button (#4261)

* add secondary check for continue button

* rubocop fix

* add conditionals for step reuse in other tests

* switch click continue steps

* edit continue steps in cucumber

* fix step name

* bs4 fix benefits saved/edit titles (#4265)

* break out benefit title into helper, refactor options helper to use map, call new title helper in form partials in favor of humanizing the kind

* comments

* add zip mask

* rubocop fix

* plan shopping options (#4255)

* 107 plan shopping flow

* missing if

* rubocop

* started fixing cucumbers

* fix compare url

* 188034872 plan shopping flow print in compare flow (#4266)

* update alt receipt.html.erb file to mach en.erb file (#4271)

* disabled fields on my household (#4267)

fix greyed out / not greyed out on my household page

* keydown tooltips (#4268)

tooltips via keyboard

* switch class to eliminate double select plan buttons on silver plans (#4269)

* bs4 fix address titles (#4263)

* fix indentation on family row, move home title out of form and into address partial

* remove redundant header from edit partial

* move dep home address header into dep address partial, add mailing address to partial

* remove unneeded args

* stylesheet media type

* fix glossary keyboard nav for multiple plan tiles (#4275)

* add index to distinguish glossaries between tiles

* use id rather than random string

* bs4 fix sep kb nav (#4270)

* fix enter suppression for bs4

* allow button and link clicks

* comment fix

* bs4 fix contact subheader (#4272)

* add missing translation, add header to other consumer forms

* fix font size in table form

* plan shopping options page fixes (#4274)

plan shopping options fixes

* bs4 family info wave error fix (#4277)

* fix manage family wave errors

* fix fa wave

* fix doc fields and eligible radio for fa

* remove debug, remove seemingly unrequired class

* refactor required class

* remove empty link from enrollment submitted page (#4276)

* remove empty useless link

* fix styling too

* dont have secondary modal for dependent table (#4273)

* don't open secondary modal when in comparison modal

* forgot to commit a file

* rubocop

* fix spec by undoing rubocop suggestions

* help me sign up copy (#4278)

* add bs4 compatibility to select plan btn in csr modal (#4280)

* add plan compare without modal method (#4281)

* bs4 fix doc status question (#4282)

* fix manage family wave errors

* fix fa wave

* fix doc fields and eligible radio for fa

* remove debug, remove seemingly unrequired class

* refactor required class

* support bs4 for view

* remove unneeded ids

* bs4 fix no ssn modal translation (#4283)

fix translation key

* enrollment submitted logic fix

* more aptc logic

* set sort to work on apply instead of on change of sort radios (#4284)

* aptc calculator adjust amount applied (#4286)

adjust the max amount of aptc to account for if the aptc is higher than the premium

* take aptc into account when sorting by premium (#4285)

* take aptc into account when sorting by premium

* use the new premium for sorting

* don't duplicate logic

* aptc calc results should have round values (#4288)

* fix rounding issue

* fix rounding

* set value to proper max

* use default cancel translation sting (#4290)

* bs4 deductions ai an cancel fixes (#4291)

use default translation for cancel on deductions and ai/ain

* remove get help link pre ridp (#4292)

get help signing up before identity verified

* fix eligibility error for "family_relationships" (#4289)

* fix eligibility error for "family_relationships"

* feat: Add error message for "family_relationships" eligibility issue

* fix cucumber content text

---------

Co-authored-by: Alec Turnbull <[email protected]>

* bs4 fix extra other income cancel (#4296)

* choose shopping method: fix copy, add default selection (#4297)

fix translations, add default selection

* don't initially disable the continue button

* bs4 fix applications dropdown clipping (#4318)

add data-boundary to fix clipping on small tables

* bs4 fix ssn exclusivity (#4316)

* apply missing class used to ensure exclusivity on dep ssn fields

* add classes and ids to other forms

* allow submit to not be listened

* only exclusive when creating not editing

* restore time jump

* restore edit

* fix syntax

* Update disability question translations for Not Sure modal (#4312)

* Update shared.rb translations for activities of daily living help (#4311)

* Clicking on links is not opening a new window (#4317)

* Fix link not target blank for "Learn more about SEPs" on FAA start

* Update link target for "Documents FAQ" on Verify Identity page.

* update link sanitize to h function

* Update voter registration link and description (#4295)

* Update Medicaid or CHIP text in financial assistance translations (#4308)

* translation Update income note for current and future income (#4301)

* Prepare translation file for incoming text (#4299)

* Prepare translation file for incoming text

* translation for modal update eligibility change question with additional information

* 187717533 not sure modal for recent denial of medicaid (#4309)

* Update Medicaid or CHIP text in financial assistance translations

* Add translation for has_eligible_medicaid_cubcare

* Update "is_self_assisted_blind" question in shared translations (#4310)

* 187987337 not sure modal for income or household size change (#4300)

* Prepare translation file for incoming text

* Add new translation for "has_household_income_changed"

* feat: Remove unused translation for "en.has_eligibility_changed"

* bs4 support unread message styling (#4319)

* refactor message from and to checks, refactor inbox styles to support bolding of unread, remove sender class and use strong tags

* wrap strong tag

* fix count alignment

* remove classes

* broker account pages to bs4 (#4315)

* refactor: Update link target for "Documents FAQ" on Verify Identity page (#4326)

* update add new member content (#4323)

* update add new member content

* update other family pages

* update fa family info to match figma (#4325)

* refactor homepage sep info message container (#4336)

* bs4 update warning for denied sep (#4334)

* use warning alert for error div

* class fixing

* update "show all enrollments" button (#4332)

* format js file

* update "Show All Enrollments" button on enrollment history page - no toggle

* bs4 limit chars date fields (#4328)

add min and max attrs

* bs4 verifications download key fix (#4338)

add missing key variable

* bs4 check medicaid flag for question (#4324)

* check flag for question

* restore

* flag legacy and bs4 medicaid question

* bs4 verify identity experian text fix (#4329)

replace l10ns with ts

* bs4 auth and consent back fix (#4339)

call off on back listener to prevent duplicate firings

* bs4 more family info add new/edit behavior fixes (#4287)

* hide add new on dep/primary edit, hide edits on add new

* add content for save vs edit on submit button

* remove logs

* bs4 eligiblity results back fix (#4340)

* remove back class if there is a link

* remove back class

* restore non fa progress buttons partial

* refactor variable setup

* never show choose shopping for dental (#4333)

* add cucumbers and make sure never see choose shopping when in dental

* remove binding

* add spec coverage

* undo prettier so doesn't look like so many changes

* rubocop

* remove commented out code

* spec cleanup

* edit plan page uplift (#4327)

* first steps to plan details page

* more work on cancellation

* more improvements

* finish UI changes

* trying to fix form submittal

* finish cancel plan work

* need to run aptc update post outside

* fix rspecs

* fix cucumber

* change form_for, remove bindings

* cleanup rubocop

* nit extra line

* clean up, feature flag addition

* add to config templates

* improve tax credit section

* finish tax credit

* fix rubocop

* put a restriction around tax credit button

* cancellation reason added to plan details

* checkbook current date variable name (#4348)

update date variable name sent to checkbook

* fix broken spec

* bs4 fix past due text (#4356)

update translation for past due

* bootstrap 4 broker form updates (#4337)

* registration page

* more broker setup

* set new feature flag

* more work on brokers

* agency profile pages

* continue broker work

* dont have secondary modal for dependent table (#4273)

* don't open secondary modal when in comparison modal

* forgot to commit a file

* rubocop

* fix spec by undoing rubocop suggestions

* aptc calculator adjust amount applied (#4286)

adjust the max amount of aptc to account for if the aptc is higher than the premium

* aptc calc results should have round values (#4288)

* fix rounding issue

* fix rounding

* use default cancel translation sting (#4290)

* add method for determining bootstrap

* consolidate with broker_setup

* rewrite slim as html

* remove method

* fix render error

* initial pass at broker forms

* readd auth to update broker

* revert minor changes

* render correct layout when bs4 not active

* update spec adhere to new validations

* make rubocop requested changes

* troubleshoot translation files

* add missing comma

* add minor fixes

* revert changes to messages.js

* make changes for cucumber

* update features for bs4 updates

* update features for bs4 updates 2

* do more cucumber tinkering

* remove ssn changes

* ssn not taking

* readd ssn to table

* troubleshoot cucumbers

* fix cucumber

* fix possible rubocop issue

* remove redundant return

* reformat rubocop issues

* remove consumer_flow from employer_profile

* fix broken cucumber

* remove trailing whitespace

* disable bs4_consumer_flow for employer profile

* fix cucumber but really this time

* fix issue with slim to erb conversion

* remove unnecessary code

* reenable removal of address from edit broker

* add more unique translations

* add missing translations

* remove unused change

* remove console.log, prevent default on addLocation call

---------

Co-authored-by: Kristin Merbach <[email protected]>
Co-authored-by: kristinmerbach <[email protected]>

* deleted messages for brokers in bs4 (#4351)

* handle message deletion in bs4 for brokers

* add translation

* bs4 hide add on fa edit (#4355)

hide and show class on edit/cancel respectively

* eligibility results text updates (#4358)

* eligibility result page text updates

* update translations

* open link from partial in new tab (#4353)

open document faq in new tab

* mask all ssn fields (#4279)

* complete initial pass on new ssn field reqs

* add slight modification to new family policy method

* add event listener for accessibility

* complete spec for new endpoints

* remove unnecessary changes from enroll system config file

* adds ssn masks to my household section

* bearer failure

* bearer failure

* bearer failure

* fix failing spec in family policy

* remove console.logs

* make env var true on failing spec

* bearer failure

* readd bearer fix

* remove excessive line breaks

* remove unnecessary helper_method in family_members controller

* complete first pass at applicant ssn field masking

* remove ssn display in all admin tables

* making brief switch to update broker permissions

* complete initial pass on new ssn field reqs

* add event listener for accessibility

* remove unnecessary changes from enroll system config file

* adds ssn masks to my household section

* bearer failure

* bearer failure

* bearer failure

* bearer failure

* readd bearer fix

* remove excessive line breaks

* remove unnecessary helper_method in family_members controller

* complete first pass at applicant ssn field masking

* add addtl permissions and update specs

* remove unnecessary line break

* finalize permission details

* complete first iteration of ssn fields

* remove changes for testing drop enrollment members

* remove comment

* reformat explanatory comment

* remove unused attrs from ssn_form_presenter

* update dependent form input

* remove unused id from edit enrollment partial

* plan shopping options page fixes (#4274)

plan shopping options fixes

* dont have secondary modal for dependent table (#4273)

* don't open secondary modal when in comparison modal

* forgot to commit a file

* rubocop

* fix spec by undoing rubocop suggestions

* enrollment submitted logic fix

* more aptc logic

* aptc calculator adjust amount applied (#4286)

adjust the max amount of aptc to account for if the aptc is higher than the premium

* aptc calc results should have round values (#4288)

* fix rounding issue

* fix rounding

* use default cancel translation sting (#4290)

* fix issue with failing cucumber

* remove console log in coffee file

* remove family_helper changes

* remove changes with unemployment form

* add translations and update w/feedback from comments

* remove extra row column in table

* add admin css file

* small changes for rubocop

* reversed logic on column list

---------

Co-authored-by: Kristin Merbach <[email protected]>
Co-authored-by: kristinmerbach <[email protected]>

* add classes to labels for color change (#4363)

* add classes to labels for color change

* add missing translation

* add layout option for error redirect (#4365)

* add layout option for error

* update config

* set datepicker min date for brokers to 16 years ago from today (#4366)

* set datepicker min date for brokers to 16 years ago from today

* update config

* default tobacco u ui (#4302)

* bs4 faa family info pg (#3937)

* faa family info pg

* small fixes

* moved strings to translations

* wave scan fixes

mc

* FAA fixes

mc

* add flag to config, hide UI

* disregard tobacco update

* rename flag

* remove helper

* move into family helper

* fix specs

* fix tobacco use spec

* add UI test

* fix given for flag

* move gherkins around

* add is enabled postfix

* rebase cleanup

* add default value U for tobacco use if flag enabled (#4313)

* add default value U for tobacco use if flag enabled

* refactor default tobacco values on models

* rubocop fix

* spec fixes

* person spec fix

---------

Co-authored-by: Sarah Austin <[email protected]>
Co-authored-by: Kristin Merbach <[email protected]>
Co-authored-by: Ryan Eddy <[email protected]>

* fix spec

* indicate show hide (#4368)

* broker show wave error (#4367)

fix WAVE error

* broker deleted message banner (#4371)

* fix comments from previous merged PR and set color of banner

* consisten quote marks

* remove keydown event from ssn field (#4372)

* Change feature flag to bs4 broker flow (#4373)

* replace bs4_consumer_flag with bs4_broker_flag

* add bs4 flag to messages inbox

* fix for ssn not being visible on person info page (#4374)

* fix jquery to js bug

* remove comments

* chore: Fix UI issues and improve form submission on plan details page (#4346)

* remove event listener from person controller js (#4377)

* remove event listener in person controller and rearrange ssn buttons

* add components

* fix market kind label typo (#4379)

fix typo

* add back missing file updates

* We have Received your Broker Application page (#4369)

* feat: Add JavaScript and CSS packs for enrollment page (#4347)

* bs4 fix household include modal text (#4376)

use fa non household modal

* bs4 fix inbox header (#4375)

* add new string and update show to change text

* flag header

* flag header and fix small breakpoint button margins

* refactor header set for broker, update consumer mailbox to follow

* enrollments page debuggng

* add missing colon to messages pages (#4381)

add missing colon to messages page

* assign expert button should always show when modal is opened (#4382)

make sure the assign an expert view status is reset when modal opened

* more enrollments show work

* more show enrollment work

* enrollment history bug

* Update non-magi referral text in financial assistance translations (#4378)

Co-authored-by: Tristan <[email protected]>

* feat: Update MaineCare (Medicaid) eligibility message (#4380)

* Update translation for not-sure modal faa-healthcoverage-page (#4350)

* update translation for has_eligibility_changed

* chore: Update translation for has_eligibility_changed

* chore: Update translation for has_eligibility_changed

* Update "is_self_assisted_blind" question in shared translations (#4383)

* update translation for has_eligibility_changed

* chore: Update translation for has_eligibility_changed

* chore: Update translation for has_eligibility_changed

* chore: Update translation for is_self_assisted_blind

* chore: Update shared.rb translations for activities of daily living help (#4384)

Signed-off-by: Tristan <[email protected]>
Co-authored-by: Tristan <[email protected]>

* feat: Update shared.rb translations for disability question (#4385)

* Update shared.rb

Fix overridden line due to multiple prs to the same file. 

Signed-off-by: Brad Bodine <[email protected]>

* remove console logs

* set minimum date for calendar field on cancel plan (#4386)

set minimum on cancel plan date field

* chore: Update button styles for secondary outline buttons (#4349)

* family info bug in bs4 (#4388)

* remove workflow specific to bootstrap branch, fix bug

* don't mix prs

* undo bs4 workflow changes (#4391)

undo weorkflow changes

* chore: Update grid-template-columns in main.scss (#4389)

Override styles used in enrollment.scss by adding !important to grid-template-columns in dl.parent. This can be deleted when bs4 flag is removed and bs4 is default.

* feat: Update contact info keydown event handler (#4390)

* turn back on auto deploys

* put broker registration flash message into translation and make banner green (#4387)

* refactor aptc form to move logic from views and clean up (#4395)

* fix compile error

* fix compile error

* fix compile error

* add ssn field handling for primaries without ssn (#4397)

* add attr to form presenter

* disable checkbox if has ssn

* add conditions for adding primary ssn

* remove unused attrs for ssn_form_presenter

* add small change to consumer sign up view

* remove method from app helper

* remove add extra line

* add small logic change

* fix for rubocop

* remove ssn from dom on remask (#4400)

* change broker broker staff calendar to match prod dates (#4403)

* bs4 fix dependent edit (#4408)

* remove disabled attrs

* fix syntax error

* re-add readonly check

* bs4 fix table font size (#4411)

* bumpy data size to 14 and first data to 16

* remove redundant sender class

* make close button keyboard accessible (#4399)

add tabindex and enter handler to close span, add css cusor for icon

* update broker show page calendar (#4405)

update max calendar date

* remove unnecessary element post aptc update fix (#4410)

* enable ssn toggle after aptc update

* remove inner html of aptc data instead of removing element

* uncomment out lines

* readd line

* fix closing popup canceling ssn form field (#4412)

* Fix accessibility errors and alerts for broker registration views (#4402)

* edit plan page uplift (#4327)

* first steps to plan details page

* more work on cancellation

* more improvements

* finish UI changes

* trying to fix form submittal

* finish cancel plan work

* need to run aptc update post outside

* fix rspecs

* fix cucumber

* change form_for, remove bindings

* cleanup rubocop

* nit extra line

* clean up, feature flag addition

* add to config templates

* improve tax credit section

* finish tax credit

* fix rubocop

* put a restriction around tax credit button

* cancellation reason added to plan details

* chore: Update select language checkboxes in broker form

Simplify and improve the code for rendering the select language checkboxes in the broker form. This change adds an ID attribute to each checkbox for better accessibility and updates the label element accordingly.

* chore: Remove unnecessary h4 tag in _agency_information.html.erb

* fix formating

* Fix the date of birth field to broker personal information for accessibility.

* Update the legal name field for accessibility.

* Update the dba field for accessibility.

* chore: Update label for market kind field in broker profile form for accessibility

* chore: Update select language checkboxes in broker form

* chore: Update address form fields for accessibility

Improve accessibility in the address form by updating the labels and input fields. This change adds appropriate label elements and removes unnecessary attributes for better accessibility.

* chore: Improve accessibility of attestation agreement fields

Update the attestation agreement fields in the broker form to improve accessibility. This change adds appropriate label elements and updates the input fields for better accessibility.

* chore: Update heading level in _address.html.erb for better accessibility

* add tabindex to "add office location" button

* chore: Add tabindex to "tabs" at top of page

* chore: Improve accessibility of staff registration form

Update the staff registration form to improve accessibility. This change includes adding appropriate label elements and updating the input fields for better accessibility.

---------

Co-authored-by: Alec Turnbull <[email protected]>

* remove value attribute present in dom (#4414)

* enable ssn toggle after aptc update

* remove attribute from element on remask

* remove commented out code

* readd space

* dont compare strings in aptc calc (#4416)

compare floats rather than strings

* add contrast for links on a red background (#4417)

* bs4 fix repeat ssn banner (#4413)

sanitize text to render anchor tags, fix double redirect

* copy should reflect the type of plan (#4419)

* Fix accessibility errors on invalid email sweet alert popup (#4421)

* fix ssn styling (#4420)

* enable ssn toggle after aptc update

* uncomment lines locally

* fix styling + qol updates

* update dental calendar logic (#4418)

* enable ssn toggle after aptc update

* uncomment lines locally

* make cancel plan calendar not appear for plans that have not started and add styles to cancel form

* update labels

* readd break tag

* readd other break tag

* remove nbsp and add bs4 class

* list new coverage kind

---------

Signed-off-by: Tristan <[email protected]>

* bs4 fix child relationship check error (#4422)

guard that the kind is not blank

* readd dob limits and alert (#4423)

* enable ssn toggle after aptc update

* uncomment lines locally

* readd dob limits and add alert to invalid dob

* prevent keep plan from submitting form (#4429)

prevent keep both from submitting form

* bs4 add qle date element to home (#4432)

* bs4 fix home modal shop sep button (#4435)

* readd create broker registration and translations (#4433)

readd create broker registration button text and translations

* style: add .pre-line class for pre-formatted text (#4434)

* fix accessibility issues on cancel plans page (#4430)

* fix accessibility issues on cancel plans page

* remove calendar if not terminating plan

* style datatable alerts (#4436)

* print title via datatables (#4437)

* brokers no messages copy (#4438)

* adjust copy when no messages

* adjust copy when no messages

* bs4 fix account created banner type (#4440)

use success banner for bs4

* bs4 fix broker search table header error (#4439)

remove extra column and refactor broker table classes

* warn about no languages selectd for brokers (#4443)

* bs4 fix family helper spec (#4442)

add whitespace to class string comparison

* create unique labels for new office locations (#4441)

* create unique labels for new office locations

* uncomment out add id

* turbolinks

* add translation

* bs4 fix effective on date plan shopping page (#4444)

* refactor continue button to match legacy for change_plan case, combine repeated params and move find_sep into else

* restore main app and remove unneeded var

* bs4 fix broker form kb nav office (#4445)

* handle keydowns for add office, support kb nav for trash

* support delete keydown

* bs4 fix broker required without css (#4448)

* chore: Update Medicaid cancelation text to reflect MaineCare (Medicaid) (#4447)

* only use the first title element for all datatables buttons (#4449)

* only use the first title element

* fix security issue

* bs4 fix add office (#4453)

restore sponsor web pack

* bs4 fix staff required fields (#4454)

manually call indicate method on staff load

* discard button functionality for self service aptc (#4452)

* navigate to broker homepage from broker families (#4456)

* move families reroute to families table file

* remove console.log

* add multi-role dropdown to my_portal (#4455)

* remove link for clarification

* remove header changes

* remove lines

* ignore module length warning from rubocop

* bs4 fix broker form website label (#4457)

remove floatlabel class

* handle consumer creation (#4458)

add logic to prevent break

* remove extra heading (#4461)

* hide title

* only print single line for enrollment year

* remove local plan handling

* remove puts + small fix for disable checkbox

* add contrast colors to separate file (#4460)

* Insured role exists hotfix (#4462)

* change check user role order in bs4 header helper (#4463)

change order of user role checks

* add more specific error on form level (#4465)

* add more specific error on form level

* add feature flag to validation

* add translations for language error

* Update heading level for ridp_type in outstanding_ridp_documents.html… (#4451)

Update heading level for ridp_type in outstanding_ridp_documents.html.erb

* chore: Update button styles for text buttons (#4450)

* Language error translation hotfix (#4466)

* add more specific error on form level

* add feature flag to validation

* add translations for language error

* fix translation error

---------

Signed-off-by: Tristan <[email protected]>

* fix aptc calculator (#4467)

* check for languages_spoken rather than language_options (#4469)

* fix rubocop

* update plan tiles to match mockups (#4471)

plan tile match mockups

* fix aptc save button and zero input handling (#4473)

* bs4 fix thankyou aptc changing (#4477)

remove calls to setUpdatedAptc on amount applied/percent blur handlers

* getting tiles even closer, including dental (#4476)

* bs4 fix discard aptc edit (#4478)

* bs4 fix default pct on discard aptc edit (#4479)

set precision 0 arg on initial percent data attr

* update text to reflect button copy (#4427)

* remove plan shopping link, put text in flash into translation (#4426)

remove link, put text in flash into translation

* bs4 fix update consumer error (#4480)

* compare error pop up use modal styling (#4428)

* shift question placement on the coverage for your household page (#4425)

Signed-off-by: Kristin Merbach <[email protected]>

* make sure application is found for raw_application and review_application (#4482)

* undo the page switch around

* refactor last alpha pagination to condense letters (#4486)

* refactor last alpha pagination to condense letters

* rubocop fix

* switch onblur to oninput so modal doesn't show if date hasn't changed (#4488)

* bs4 fix not sure quotes (#4491)

consistent quotations for not sure options in bodies

* bs4 fix edit broker add address submit (#4496)

* set person so the assign an expert functions correctly (#4487)

* bs4 fix fa family info add new (#4499)

* fix submit handling for edit form

* disable and blur confirm on submit, remove modal from edit

* remove console.log

* update tabindex on reenable

* remove debug headers

* remove unneeded char

* remove unneeded char

* store user input for validation (#4498)

* bs4 fix broker address text (#4501)

remove unneeded translations, use correct text for address 1 label and placeholder

* bs4 fix edit plan cancel translation (#4500)

fix cancellation spelling

* add bs4 admin FF (#4481)

* add a phone number pattern for broker forms (#4495)

* change quote style in cucumber expectation to match translation (#4502)

* plan tile headers should have an underline during hover (#4505)

---------

Signed-off-by: kristinmerbach <[email protected]>
Signed-off-by: Tristan <[email protected]>
Signed-off-by: Brad Bodine <[email protected]>
Signed-off-by: Kristin Merbach <[email protected]>
Co-authored-by: Charlie Parker <[email protected]>
Co-authored-by: Alec Turnbull <[email protected]>
Co-authored-by: Brad Bodine <[email protected]>
Co-authored-by: Ryan Eddy <[email protected]>
Co-authored-by: quisbertdiana <[email protected]>
Co-authored-by: Alec Turnbull <[email protected]>
Co-authored-by: Tristan <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
Co-authored-by: Ann Caballero <[email protected]>
charlienparker added a commit that referenced this pull request Sep 13, 2024
charlienparker added a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants