Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap 4 upgrade #3707

Merged
merged 607 commits into from
Sep 11, 2024
Merged

bootstrap 4 upgrade #3707

merged 607 commits into from
Sep 11, 2024

Conversation

kristinmerbach
Copy link
Contributor

@kristinmerbach kristinmerbach commented Mar 22, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements

  • The title follows our guidelines
  • Tests for the changes have been added (for bugfixes/features)

PR Type

What kind of change does this PR introduce?

This is the complete refactor of the UI. Details on individual commits are on the PRs that came into this branch.

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: This is not one singular ticket but multiple epics:

A brief description of the changes

Current behavior: Old outdated UI based on Bootstrap 3

New behavior: New UI based on Bootstrap 4

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.

Variable names:
BS4_CONSUMER_FLOW_IS_ENABLED -> used for all pages in the consumer flow (aka, that can be used by an individual looking for coverage)
BS4_BROKER_FLOW_IS_ENABLED -> used for all broker specific pages
CHOOSE_SHOPPING_METHOD_IS_ENABLED -> adds a new page to the plan shopping flow to send users to Checkbook rather than our plan shopping
SEND_EXTRA_FIELDS_TO_CHECKBOOK_IS_ENABLED -> sends two new fields to the checkbook service in order to enhance the Checkbook UI
CANCELLATION_REASON_FIELD_IS_ENABLED -> Adds a new field to the cancel plan form to be stored in the data warehouse.
MASK_SSN_UI_FIELDS -> hides full SSNs from the UI. For non-inputs, they have been removed from the UI. For inputs they can be made visible (with the proper permissions) by clicking the "eye" icon in the input
SENSOR_TOBACCO_CARRIER_USAGE_IS_ENABLED -> hides the tobacco use question from the UI and sends a default U to the carriers.

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

AppScan CodeSweep Failure

In the event of a failed check on the AppScan CodeSweep step of our GitHub Actions workflow, please review the False Positive protocol outlined here: appscan_codesweep/CODESWEEP_FALSE_POSITIVES_README.MD

Add all required notes to this section if the failure is a suspected false positive.

@kristinmerbach kristinmerbach marked this pull request as draft March 22, 2024 15:35
@scaustin34 scaustin34 force-pushed the clean-bootstrap-4-upgrade branch 3 times, most recently from 7b640f8 to eddc800 Compare April 8, 2024 17:53
@kristinmerbach kristinmerbach force-pushed the clean-bootstrap-4-upgrade branch 3 times, most recently from 41f8d66 to 3f35160 Compare May 9, 2024 16:26
@kristinmerbach kristinmerbach force-pushed the clean-bootstrap-4-upgrade branch 2 times, most recently from 4b438d2 to ad1ff05 Compare May 20, 2024 14:15
@kristinmerbach kristinmerbach force-pushed the clean-bootstrap-4-upgrade branch from 1b16d47 to 4d894e3 Compare May 29, 2024 14:56
@scaustin34 scaustin34 force-pushed the clean-bootstrap-4-upgrade branch from 1de0183 to daa0a07 Compare June 3, 2024 15:10
@kristinmerbach kristinmerbach force-pushed the clean-bootstrap-4-upgrade branch 2 times, most recently from dc5f57d to 2dfb81c Compare June 10, 2024 14:30
@kristinmerbach kristinmerbach force-pushed the clean-bootstrap-4-upgrade branch from 0ec06d1 to ecacb27 Compare June 13, 2024 15:27
@scaustin34 scaustin34 force-pushed the clean-bootstrap-4-upgrade branch from 6ad8ab4 to 49d0dcc Compare June 18, 2024 15:01
@scaustin34 scaustin34 force-pushed the clean-bootstrap-4-upgrade branch from d38df6b to 714bed1 Compare June 26, 2024 17:18
@kristinmerbach kristinmerbach force-pushed the clean-bootstrap-4-upgrade branch from 45218ba to a37bca3 Compare July 12, 2024 14:43
@ATBull81 ATBull81 force-pushed the clean-bootstrap-4-upgrade branch from 36a22ff to 5a7b9c4 Compare July 19, 2024 13:07
@bbodine1 bbodine1 force-pushed the clean-bootstrap-4-upgrade branch 2 times, most recently from 1c54925 to de83421 Compare July 26, 2024 13:51
@bbodine1 bbodine1 force-pushed the clean-bootstrap-4-upgrade branch 3 times, most recently from 239fd57 to c242e09 Compare August 1, 2024 11:14
@kristinmerbach kristinmerbach force-pushed the clean-bootstrap-4-upgrade branch from 421270d to 56604b6 Compare August 1, 2024 17:48
@bbodine1 bbodine1 force-pushed the clean-bootstrap-4-upgrade branch 4 times, most recently from 0316071 to 4b97af7 Compare August 7, 2024 11:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2024
View reviewed changes
app/views/insured/plan_shoppings/show.html.erb Dismissed Show dismissed Hide dismissed
app/views/insured/plan_shoppings/show.html.erb Dismissed Show dismissed Hide dismissed
app/views/layouts/bootstrap_4.html.erb Fixed Show fixed Hide fixed
app/views/layouts/bootstrap_4.html.erb Fixed Show fixed Hide fixed
app/views/layouts/bootstrap_4.html.erb Fixed Show fixed Hide fixed
app/views/layouts/bootstrap_4.html.erb Fixed Show fixed Hide fixed
app/views/layouts/progress.html.erb Fixed Show fixed Hide fixed
app/views/layouts/progress.html.erb Fixed Show fixed Hide fixed
@bbodine1 bbodine1 force-pushed the clean-bootstrap-4-upgrade branch from cfc026d to 8115067 Compare August 9, 2024 11:04
kristinmerbach and others added 20 commits September 10, 2024 13:27
@kristinmerbach
update text to reflect button copy (#4427)
f8b73cf
@kristinmerbach
remove plan shopping link, put text in flash into translation (#4426)
fd97860 
remove link, put text in flash into translation
@charlienparker @kristinmerbach
bs4 fix update consumer error (#4480)
a515f58
@kristinmerbach
compare error pop up use modal styling (#4428)
537be90
@kristinmerbach
shift question placement on the coverage for your household page (#4425)
82429f5 
Signed-off-by: Kristin Merbach <[email protected]>
@kristinmerbach
make sure application is found for raw_application and review_applica…
0d5f8d4 
…tion (#4482)
@kristinmerbach
undo the page switch around
9dbee68
@kristinmerbach
refactor last alpha pagination to condense letters (#4486)
dbf36c0 
* refactor last alpha pagination to condense letters

* rubocop fix
@kristinmerbach
switch onblur to oninput so modal doesn't show if date hasn't changed (…
857ab11 
…#4488)
@charlienparker @kristinmerbach
bs4 fix not sure quotes (#4491)
adbbd14 
consistent quotations for not sure options in bodies
@charlienparker @kristinmerbach
bs4 fix edit broker add address submit (#4496)
ee6db41
@kristinmerbach
set person so the assign an expert functions correctly (#4487)
85bb84c
@charlienparker @kristinmerbach
bs4 fix fa family info add new (#4499)
96971fd 
* fix submit handling for edit form

* disable and blur confirm on submit, remove modal from edit

* remove console.log

* update tabindex on reenable

* remove debug headers

* remove unneeded char

* remove unneeded char
@kristinmerbach
store user input for validation (#4498)
3cfa0ae
@charlienparker @kristinmerbach
bs4 fix broker address text (#4501)
bbe8663 
remove unneeded translations, use correct text for address 1 label and placeholder
@charlienparker @kristinmerbach
bs4 fix edit plan cancel translation (#4500)
cdbf64f 
fix cancellation spelling
@kristinmerbach
add bs4 admin FF (#4481)
94e567e
@kristinmerbach
add a phone number pattern for broker forms (#4495)
0f1b631
@kristinmerbach
change quote style in cucumber expectation to match translation (#4502)
845746e
@kristinmerbach
plan tile headers should have an underline during hover (#4505)
cae4825
@kristinmerbach kristinmerbach force-pushed the clean-bootstrap-4-upgrade branch from 57ba926 to cae4825 Compare September 10, 2024 20:28
polographer
polographer approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@polographer polographer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work from the whole team, this raises the bar of what we can do on UI

saikumar9
saikumar9 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@saikumar9 saikumar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🔥

@polographer polographer enabled auto-merge (squash) September 11, 2024 12:56
@polographer polographer merged commit d81da57 into trunk Sep 11, 2024
128 checks passed
@polographer polographer deleted the clean-bootstrap-4-upgrade branch September 11, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumar9 saikumar9 saikumar9 approved these changes

@polographer polographer polographer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kristinmerbach @polographer @saikumar9 @charlienparker @bbodine1 @RyanEddyIC @ATBull81 @TristanB17 @anncaballeroo