-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bs4 fix dependent spousal validation #4194
Merged
kristinmerbach
merged 2 commits into
clean-bootstrap-4-upgrade
from
bs4-fix-dependent-spousal-validation
Aug 5, 2024
Merged
bs4 fix dependent spousal validation #4194
kristinmerbach
merged 2 commits into
clean-bootstrap-4-upgrade
from
bs4-fix-dependent-spousal-validation
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristinmerbach
approved these changes
Aug 4, 2024
Looks good, but please run rubocop and make needed fixes |
I fixed the rubocop error I introduced |
TristanB17
approved these changes
Aug 5, 2024
kristinmerbach
merged commit Aug 5, 2024
94aac30
into
clean-bootstrap-4-upgrade
103 of 119 checks passed
bbodine1
pushed a commit
that referenced
this pull request
Aug 6, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 7, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 9, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 10, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 13, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 14, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 15, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 16, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 19, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 20, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 20, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 22, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 23, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 27, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 28, 2024
* fix dependent check * fix rubocop error on updated function
bbodine1
pushed a commit
that referenced
this pull request
Aug 29, 2024
* fix dependent check * fix rubocop error on updated function
kristinmerbach
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix dependent check * fix rubocop error on updated function
kristinmerbach
pushed a commit
that referenced
this pull request
Sep 6, 2024
* fix dependent check * fix rubocop error on updated function
kristinmerbach
pushed a commit
that referenced
this pull request
Sep 10, 2024
* fix dependent check * fix rubocop error on updated function
charlienparker
added a commit
that referenced
this pull request
Sep 13, 2024
* fix dependent check * fix rubocop error on updated function
charlienparker
added a commit
that referenced
this pull request
Sep 16, 2024
* fix dependent check * fix rubocop error on updated function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements
PR Type
What kind of change does this PR introduce?
What is the ticket # detailing the issue?
Ticket: https://www.pivotaltracker.com/n/projects/2640062/stories/188014957#
A brief description of the changes
Current behavior:
New behavior:
Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.
Variable name:
Additional Context
Include any additional context that may be relevant to the peer review process.
AppScan CodeSweep Failure
In the event of a failed check on the AppScan CodeSweep step of our GitHub Actions workflow, please review the False Positive protocol outlined here: appscan_codesweep/CODESWEEP_FALSE_POSITIVES_README.MD
Add all required notes to this section if the failure is a suspected false positive.