Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bs4 fix dependent spousal validation #4194

Merged

Conversation

charlienparker
Copy link
Contributor

@charlienparker charlienparker commented Aug 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements

  • The title follows our guidelines
  • Tests for the changes have been added (for bugfixes/features), they use let helpers and before blocks
  • For all UI changes, there is cucumber coverage
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, reasoning is documented in PR and code
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run it is documented on both the PR and in the code
  • There are no inline styles added
  • There are no inline javascript added
  • There is no hard coded text added/updated in helpers/views/Javascript. New/updated translation strings do not include markup/styles, unless there is supporting documentation
  • Code does not use .html_safe
  • All images added/updated have alt text
  • Doesn’t bypass rubocop rules in any way

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: https://www.pivotaltracker.com/n/projects/2640062/stories/188014957#

A brief description of the changes

Current behavior:

New behavior:

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

AppScan CodeSweep Failure

In the event of a failed check on the AppScan CodeSweep step of our GitHub Actions workflow, please review the False Positive protocol outlined here: appscan_codesweep/CODESWEEP_FALSE_POSITIVES_README.MD

Add all required notes to this section if the failure is a suspected false positive.

@charlienparker charlienparker requested a review from a team as a code owner August 3, 2024 23:10
@charlienparker charlienparker changed the base branch from trunk to clean-bootstrap-4-upgrade August 3, 2024 23:10
@kristinmerbach
Copy link
Contributor

Looks good, but please run rubocop and make needed fixes

@charlienparker
Copy link
Contributor Author

Looks good, but please run rubocop and make needed fixes

I fixed the rubocop error I introduced

@kristinmerbach kristinmerbach merged commit 94aac30 into clean-bootstrap-4-upgrade Aug 5, 2024
103 of 119 checks passed
@kristinmerbach kristinmerbach deleted the bs4-fix-dependent-spousal-validation branch August 5, 2024 16:28
bbodine1 pushed a commit that referenced this pull request Aug 6, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 7, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 9, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 10, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 13, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 14, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 15, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 16, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 19, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 20, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 20, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 22, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 23, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 27, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 28, 2024
* fix dependent check

* fix rubocop error on updated function
bbodine1 pushed a commit that referenced this pull request Aug 29, 2024
* fix dependent check

* fix rubocop error on updated function
kristinmerbach pushed a commit that referenced this pull request Sep 4, 2024
* fix dependent check

* fix rubocop error on updated function
kristinmerbach pushed a commit that referenced this pull request Sep 6, 2024
* fix dependent check

* fix rubocop error on updated function
kristinmerbach pushed a commit that referenced this pull request Sep 10, 2024
* fix dependent check

* fix rubocop error on updated function
charlienparker added a commit that referenced this pull request Sep 13, 2024
* fix dependent check

* fix rubocop error on updated function
charlienparker added a commit that referenced this pull request Sep 16, 2024
* fix dependent check

* fix rubocop error on updated function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants