bs4 fix dependent spousal validation (#4194)

* fix dependent check * fix rubocop error on updated function
ideacrew · Sep 13, 2024 · 46cbcaf · 46cbcaf
1 parent 239e977
commit 46cbcaf
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/components/financial_assistance/app/models/financial_assistance/applicant.rb b/components/financial_assistance/app/models/financial_assistance/applicant.rb
@@ -622,12 +622,11 @@ def invalid_family_relationships
     def invalid_spousal_relationship
       partner_relationships = application.relationships.where({
                                                                 "$or" => [
-                                                                { :applicant_id => id, :kind.in => ['spouse', 'domestic_partner'] },
-                                                                { :relative_id => id, :kind.in => ['spouse', 'domestic_partner'] }
+                                                                  { :applicant_id => id, :kind.in => ['spouse', 'domestic_partner'] },
+                                                                  { :relative_id => id, :kind.in => ['spouse', 'domestic_partner'] }
                                                                 ]
                                                               })
-      partner_relationships_for_applicant = partner_relationships.filter { |relationship| relationship.applicant_id == id }
-      return partner_relationships_for_applicant.drop(1) if partner_relationships_for_applicant.present?
+      return partner_relationships.drop(1) if partner_relationships.size > 2
     end
 
     def invalid_sibling_relationship