Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Positioning Bug of CombinerGenerator #29597

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

miaoyinb
Copy link
Contributor

closes #29596

@miaoyinb miaoyinb marked this pull request as ready for review December 20, 2024 22:29
@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 842fa6b wanted to post the following:

Framework coverage

7d4ab7 #29597 842fa6
Total Total +/- New
Rate 85.25% 85.25% -0.00% 100.00%
Hits 108007 108009 +2 3
Misses 18682 18683 +1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 842fa6b wanted to post the following:

View the site here

This comment will be updated on new commits.

Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! thanks for the fix

@GiudGiud GiudGiud merged commit 90a2914 into idaholab:next Dec 22, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The First Position in CombinerGenerator Not Applied
3 participants