Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full path rather than real path #21147

Merged
merged 2 commits into from
May 27, 2022
Merged

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented May 25, 2022

Closes #21134

This is an alternative to #21137

@moosebuild
Copy link
Contributor

Job Documentation on a82c6c7 wanted to post the following:

View the site here

This comment will be updated on new commits.

@dschwen
Copy link
Member Author

dschwen commented May 25, 2022

There are several failure in the blackbear assessment cases, in which an input file is symlinked into a directory, but a data file (csv for a tabulated function) resides next to the real input file (not the symlink). This arguably is a case where real path would be more convenient than full path. But in general I'm against resolving symlinks and for treating them a like files, which is more expected behavior IMO.

@moosebuild
Copy link
Contributor

Job Coverage on a82c6c7 wanted to post the following:

Framework coverage

74d60f #21147 a82c6c
Total Total +/- New
Rate 82.57% 82.57% -0.00% 100.00%
Hits 75294 75292 -2 1
Misses 15891 15891 - 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@dschwen
Copy link
Member Author

dschwen commented May 26, 2022

Fix for blackbear is here: idaholab/blackbear#302

Update: merged

@dschwen
Copy link
Member Author

dschwen commented May 27, 2022

@loganharbour looks like there is a comm issue between civet and GitHub. All tests passed but one is still marked in progress here.

@loganharbour loganharbour merged commit 882dc6d into idaholab:next May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent symlink following behavior in checkpoint/restart
3 participants