-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::filesystem #21137
Use std::filesystem #21137
Conversation
If I remember right one of our min compilers doesn't fully support filesystem... |
Let's see if they do with the additional |
Ugh, both min compilers error out on the include already:
|
So it's actually "Both of our min compilers fully don't support filesystem." |
79de564
to
4533bbf
Compare
Job Documentation on 1af1d72 wanted to post the following: View the site here This comment will be updated on new commits. |
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
@loganharbour we've done some min compiler bumping since this PR was first opened, haven't we? |
I think the current min still doesn't fully support std::filesystem, @dschwen sound right? |
From the issue:
We haven't bumped this much, have we? |
@YaqiWang sounds like we're still a little ways off from supporting |
Thanks for letting me know. I think I can still wait. |
4533bbf
to
d641dda
Compare
sigh, yea still failing gcc. 😢 |
It is not a building failure though. The tests might be fixable. Oh, gcc test is a building failure. |
I'll refold the uexternaldb test. Whether the output directory is |
Can we do something like they do here? For gcc 7.5 |
db3e739
to
1af1d72
Compare
Job Coverage on 1af1d72 wanted to post the following: Framework coverage
Modules coverageTensor mechanics
Full coverage reportsReports
This comment will be updated on new commits. |
1af1d72
to
5f82201
Compare
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Closes #21134