Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::filesystem #21137

Closed
wants to merge 3 commits into from
Closed

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented May 25, 2022

Closes #21134

@loganharbour
Copy link
Member

If I remember right one of our min compilers doesn't fully support filesystem...

@dschwen
Copy link
Member Author

dschwen commented May 25, 2022

If I remember right one of our min compilers doesn't fully support filesystem...

Let's see if they do with the additional -l flags added...

@dschwen
Copy link
Member Author

dschwen commented May 25, 2022

Ugh, both min compilers error out on the include already:

fatal error: 'filesystem' file not found
#include <filesystem>
         ^~~~~~~~~~~~
1 error generated.

@dschwen
Copy link
Member Author

dschwen commented May 25, 2022

If I remember right one of our min compilers doesn't fully support filesystem...

So it's actually "Both of our min compilers fully don't support filesystem."

@moosebuild
Copy link
Contributor

moosebuild commented May 25, 2022

Job Documentation on 1af1d72 wanted to post the following:

View the site here

This comment will be updated on new commits.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale PRs that have reached or exceeded 90 days with no activity label Sep 28, 2022
@github-actions github-actions bot closed this Oct 6, 2022
@lindsayad lindsayad reopened this Mar 6, 2023
@lindsayad lindsayad self-requested a review as a code owner March 6, 2023 17:09
@lindsayad
Copy link
Member

@loganharbour we've done some min compiler bumping since this PR was first opened, haven't we?

@loganharbour
Copy link
Member

@loganharbour we've done some min compiler bumping since this PR was first opened, haven't we?

I think the current min still doesn't fully support std::filesystem, @dschwen sound right?

@dschwen
Copy link
Member Author

dschwen commented Mar 6, 2023

From the issue:

Using this library may require additional compiler/linker options. GNU implementation prior to 9.1 requires linking with -lstdc++fs and LLVM implementation prior to LLVM 9.0 requires linking with -lc++fs.

We haven't bumped this much, have we?

@lindsayad
Copy link
Member

@YaqiWang sounds like we're still a little ways off from supporting std::filesystem

@YaqiWang
Copy link
Contributor

YaqiWang commented Mar 6, 2023

@YaqiWang sounds like we're still a little ways off from supporting std::filesystem

Thanks for letting me know. I think I can still wait.

@dschwen dschwen removed the stale PRs that have reached or exceeded 90 days with no activity label Mar 6, 2023
@dschwen dschwen force-pushed the std_filesystem_21134 branch from 4533bbf to d641dda Compare March 6, 2023 23:52
@lindsayad
Copy link
Member

sigh, yea still failing gcc. 😢

@YaqiWang
Copy link
Contributor

YaqiWang commented Mar 7, 2023

It is not a building failure though. The tests might be fixable. Oh, gcc test is a building failure.

@dschwen
Copy link
Member Author

dschwen commented Mar 7, 2023

I'll refold the uexternaldb test. Whether the output directory is '.' or '' should not matter.

@GiudGiud
Copy link
Contributor

Can we do something like they do here? For gcc 7.5
nlohmann/json#3090

@dschwen dschwen force-pushed the std_filesystem_21134 branch from db3e739 to 1af1d72 Compare March 16, 2023 20:12
@moosebuild
Copy link
Contributor

Job Coverage on 1af1d72 wanted to post the following:

Framework coverage

ae61f4 #21137 1af1d7
Total Total +/- New
Rate 84.83% 84.83% -0.00% 100.00%
Hits 84017 84005 -12 10
Misses 15026 15024 -2 0

Diff coverage report

Full coverage report

Modules coverage

Tensor mechanics

ae61f4 #21137 1af1d7
Total Total +/- New
Rate 89.23% 89.23% +0.00% -
Hits 26560 26562 +2 0
Misses 3207 3207 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale PRs that have reached or exceeded 90 days with no activity label Aug 18, 2023
@github-actions github-actions bot closed this Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PRs that have reached or exceeded 90 days with no activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent symlink following behavior in checkpoint/restart
6 participants