Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand_MK5: add coupling law documentation #249

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Feb 3, 2023

This has been written converting the existing documentation from docx to markdown.

cc @traversaro @ale-git @fiorisi @xEnVrE

@Nicogene Nicogene requested a review from pattacini as a code owner February 3, 2023 11:42
@Nicogene Nicogene self-assigned this Feb 3, 2023
@Nicogene Nicogene linked an issue Feb 3, 2023 that may be closed by this pull request
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few preliminary comments to begin with:

@pattacini
Copy link
Member

Sorry, I overlooked the point.
Better off dedicating a file for the coupling instead of filling in the main one.
Then, we need to update the main resources pointing to the new file.

@Nicogene
Copy link
Member Author

Nicogene commented Feb 3, 2023

Sorry, I overlooked the point.
Better off dedicating a file for the coupling instead of filling in the main one.
Then, we need to update the main resources pointing to the new file.

Done

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

The page is rendered like this for what concerns the images:

image

Perhaps, we can increase the resolution so that the variables are more visible?

What do you think @Nicogene?

@pattacini
Copy link
Member

I'm merging the PR anyway.
Later, I'll increase the resolution of those images.

@pattacini pattacini merged commit f00d25f into icub-tech-iit:master Feb 4, 2023
@pattacini
Copy link
Member

Later, I'll increase the resolution of those images.

Actually, the final rendering is sufficient!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the coupling law of Hand MK5
2 participants