fix(tar): create translated files in temp #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
=======================================
Coverage 73.30% 73.30%
=======================================
Files 68 68
Lines 8309 8309
=======================================
Hits 6091 6091
Misses 2218 2218
Continue to review full report at Codecov.
|
HowToDoThis
added a commit
to HowToDoThis/SharpZipLib
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #622 the temporary file path was changed to use
Path.GetRandomFileName()instead ofPath.GetTempFileName(), which resulted in the current working directory being used for storing the translated tar files while creating archives.This instead uses the
PathUtils.GetTempFileName()that was created for this purpose.Fixes #644