Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security fixes for v1.3.2 #622

Merged
merged 4 commits into from
May 8, 2021
Merged

security fixes for v1.3.2 #622

merged 4 commits into from
May 8, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented May 8, 2021

Fixes #543

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #622 (4875a45) into master (1b9fcfc) will decrease coverage by 0.11%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   73.35%   73.23%   -0.12%     
==========================================
  Files          68       68              
  Lines        8718     8721       +3     
==========================================
- Hits         6395     6387       -8     
- Misses       2323     2334      +11     
Impacted Files Coverage Δ
src/ICSharpCode.SharpZipLib/Tar/TarArchive.cs 42.96% <0.00%> (ø)
...CSharpCode.SharpZipLib/Zip/WindowsNameTransform.cs 75.30% <100.00%> (+0.94%) ⬆️
...ICSharpCode.SharpZipLib/BZip2/BZip2OutputStream.cs 78.40% <0.00%> (-1.13%) ⬇️
...Code.SharpZipLib/Zip/Compression/DeflaterEngine.cs 87.12% <0.00%> (-0.34%) ⬇️
src/ICSharpCode.SharpZipLib/Zip/ZipEntry.cs 91.47% <0.00%> (-0.07%) ⬇️
...ICSharpCode.SharpZipLib/Encryption/ZipAESStream.cs 84.00% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9fcfc...4875a45. Read the comment docs.

@piksel piksel merged commit ffe69c0 into master May 8, 2021
@piksel piksel deleted the sec/v1.3.2 branch May 8, 2021 17:00
HowToDoThis added a commit to HowToDoThis/SharpZipLib that referenced this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid Path.GetTempFileName() due to CWE 377 in TarArchive.cs.
1 participant