Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Do not use rebind in StringConcatFactory" #42

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Revert "Do not use rebind in StringConcatFactory" #42

merged 1 commit into from
Oct 27, 2021

Conversation

babsingh
Copy link
Member

This reverts commit 64624cb.

Related: eclipse-openj9/openj9#9895.

Signed-off-by: Babneet Singh [email protected]

@babsingh babsingh mentioned this pull request Oct 27, 2021
Closed
@babsingh
Copy link
Member Author

Running a personal build. Will remove the DRAFT state if no failures are seen in the personal build.

@babsingh babsingh marked this pull request as ready for review October 27, 2021 11:30
@babsingh babsingh requested a review from pshipton October 27, 2021 11:30
@babsingh
Copy link
Member Author

JDK17 personal build passed with no failures.

@pshipton
Copy link
Member

@babsingh what test suites did you run in the personal build?

@babsingh
Copy link
Member Author

@babsingh what test suites did you run in the personal build?

sanity.functional and extended.functional

@pshipton
Copy link
Member

jenkins test sanity.openjdk alinux64 jdk17

@pshipton
Copy link
Member

Pls cherry pick for the 0.29.1 branch either now or once I merge this.

@pshipton
Copy link
Member

Are there any excluded tests related to this? I'm wondering why we didn't notice any problems.

@pshipton pshipton mentioned this pull request Oct 27, 2021
Merged
@babsingh
Copy link
Member Author

babsingh commented Oct 27, 2021 •
edited
Loading

Pls cherry pick for the 0.29.1 branch either now or once I merge this.

Created #43 to port this PR to the 0.29.1-release branch.

Are there any excluded tests related to this? I'm wondering why we didn't notice any problems.

No tests were excluded. rebind only adds perf benefits. It does not change the functionality. This is why the code functioned correctly even after removing the rebind call.

@pshipton pshipton merged commit dee9f34 into ibmruntimes:openj9 Oct 27, 2021
@pshipton pshipton mentioned this pull request Oct 27, 2021
Merged
keithc-ca pushed a commit to keithc-ca/openj9-openjdk17 that referenced this pull request Oct 27, 2022
Merge pull request ibmruntimes#42 from yaroklochko/security-util-reso…
8d7efd0 
…urces-patch

Port 7 z/OS patches for security/util/resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babsingh @pshipton