Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track JDK commits which need OpenJDK MethodHandle support #9895

Closed
babsingh opened this issue Jun 16, 2020 · 8 comments
Closed

Track JDK commits which need OpenJDK MethodHandle support #9895

babsingh opened this issue Jun 16, 2020 · 8 comments
Assignees
@babsingh
Labels
comp:build comp:vm project:MH Used to track Method Handles related work
Milestone
Release 0.29.1 (J...

Comments

@babsingh
Copy link
Contributor

In JDK15+, commits dependent on the OpenJDK MethodHandle(s) were noticed. These commits cannot be supported with the OpenJ9 MethodHandle implementation. These commits are temporarily reverted (disabled) until OpenJ9 supports the OpenJDK MethodHandle(s). This issue will track all such commits so that their revert can be undone once OpenJ9 supports the OpenJDK MethodHandles(s).
@babsingh babsingh mentioned this issue Jun 16, 2020
Closed
@babsingh
Copy link
Contributor Author

babsingh commented Jun 16, 2020 •
edited
Loading

fyi @DanHeidinga @fengxue-IS

Issue MethodHandle.rebind() not supported in OpenJ9: #9771
Fix (JDK15): ibmruntimes/openj9-openjdk-jdk15#4
Fix (JDK-Latest): ibmruntimes/openj9-openjdk-jdk#215

@pshipton pshipton added this to the Release 0.22 (Java 15) milestone Jun 16, 2020
@babsingh babsingh mentioned this issue Jun 30, 2020
Closed
@DanHeidinga
Copy link
Member

@babsingh Is this still relevant or can it be closed?

@babsingh
Copy link
Contributor Author

@babsingh Is this still relevant or can it be closed?

This issue will be kept open until all the listed JDK changes/modifications are reverted ... once OpenJ9 adopts OpenJDK MethodHandles and VarHandles.

@babsingh
Copy link
Contributor Author

JDK changes to support JEP383 with OpenJ9: ibmruntimes/openj9-openjdk-jdk15#11

@DanHeidinga
Copy link
Member

@babsingh Is this still relevant or can it be closed?

This issue will be kept open until all the listed JDK changes/modifications are reverted ... once OpenJ9 adopts OpenJDK MethodHandles and VarHandles.

That clears it up. We need to keep this open but it's not a 15 specific item and therefore should be moved out of the 0.22.0 release

@pshipton pshipton added the project:MH Used to track Method Handles related work label Nov 13, 2020
@tajila tajila added the comp:vm label Oct 26, 2021
@pshipton
Copy link
Member

@babsingh is there still something to do here?

@babsingh
Copy link
Contributor Author

is there still something to do here?

Since OJDK MHs are enabled in JDK17 and JDK-next, we can revert the Do not use rebind in StringConcatFactory commit in the two extension repos.

@babsingh babsingh mentioned this issue Oct 27, 2021
Closed
babsingh added a commit to babsingh/openj9-openjdk-jdk17 that referenced this issue Oct 27, 2021
@babsingh
Revert "Do not use rebind in StringConcatFactory"
b9f11a8 
This reverts commit 64624cb.

Related: eclipse-openj9/openj9#9895.

Signed-off-by: Babneet Singh <[email protected]>
@babsingh babsingh mentioned this issue Oct 27, 2021
Merged
@babsingh
Copy link
Contributor Author

babsingh commented Oct 27, 2021 •
edited
Loading

re #9895 (comment)

Created the following PRs to revert Do not use rebind in StringConcatFactory:

@babsingh babsingh mentioned this issue Oct 27, 2021
Merged
babsingh added a commit to babsingh/openj9-openjdk-jdk17 that referenced this issue Oct 27, 2021
@babsingh
Revert "Do not use rebind in StringConcatFactory"
8eebd0d 
This reverts commit 64624cb.

Related: eclipse-openj9/openj9#9895.

Signed-off-by: Babneet Singh <[email protected]>
@babsingh babsingh mentioned this issue Oct 27, 2021
Merged
pshipton pushed a commit to ibmruntimes/openj9-openjdk-jdk that referenced this issue Oct 27, 2021
@babsingh
Revert "Do not use rebind in StringConcatFactory"
b511ec1 
Reverts #215.

Related: eclipse-openj9/openj9#9895.

Related: #371.

Signed-off-by: Babneet Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@babsingh babsingh

Labels
comp:build comp:vm project:MH Used to track Method Handles related work
Projects
None yet
Milestone
Release 0.29.1 (Java 17)
Development

No branches or pull requests
5 participants
@DanHeidinga @babsingh @tajila @JasonFengJ9 @pshipton