Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information regarding Model and Manufacturer #474

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Jul 14, 2021

Somfy recently added core:Manufacturer as attribute and we were missing a few other keys for Models, which I found out during the implementation of climate devices.

@github-actions github-actions bot added the enhancement New feature or request label Jul 14, 2021
tetienne
tetienne previously approved these changes Jul 14, 2021
Copy link
Collaborator

@tetienne tetienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you some examples?

@iMicknl
Copy link
Owner Author

iMicknl commented Jul 14, 2021

Have you some examples?

The first one (attribute -> manufacturer) is for Somfy devices, see:

Screen Shot 2021-07-14 at 22 30 55

I renamed our fallback to Somfy default and apparently only the alarm controller doesn't have this attribute.

The others were mainly used for Atlantic devices and I pulled those from other open PR's.

@tetienne
Copy link
Collaborator

I mean a raw json. Just for history.

@iMicknl
Copy link
Owner Author

iMicknl commented Jul 14, 2021

I mean a raw json. Just for history.

	"attributes": [{
			"name": "core:SupportedManufacturerSettingsCommands",
			"type": 10,
			"value": ["dead_man_up", "dead_man_down", "dead_man_stop", "dead_man_impulse_up", "dead_man_impulse_down", "enter_settings_mode", "save_upper_end_limit", "save_lower_end_limit", "stop_after_save_limit", "set_auto_end_limits", "save_settings", "invert_rotation", "save_my_position", "delete_my_position", "set_obstacle_detection", "set_type_lock", "save_auxiliary_end_limit_entry", "save_auxiliary_end_limit_exit", "set_dbe_up", "reset_actuator", "double_power_cut", "eject_from_setting_mode", "enter_back_impulse_setting_mode", "save_back_impulse_position", "set_x_time"]
		}, {
			"name": "core:FirmwareRevision",
			"type": 3,
			"value": "5121525A07?"
		}, {
			"name": "core:Manufacturer",
			"type": 3,
			"value": "Somfy"
		}],

@iMicknl iMicknl merged commit 65de131 into master Jul 14, 2021
@iMicknl iMicknl deleted the enhancement/add_model_product_info branch July 14, 2021 20:41
iMicknl added a commit that referenced this pull request Jul 14, 2021
commit 93a02ff
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:30:49 2021 -0700

    Add support for AtlanticElectricalTowelDryer (#423)

    * Add scaffold for feature/AtlanticElectricalTowelDryer

    * Update presets and other features

    * First clean up

    * remove comments

commit a4709cd
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:18:00 2021 -0700

    Adjust Atlantic Electrical Heater to new standards and fix issues (#454)

    * Adjust Atlantic Electrical Heater to new standards and fix issues

    * Add comfort mode

    * Add missing extra comfort presets

commit 65de131
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 13:41:35 2021 -0700

    Add more information regarding Model and Manufacturer (#474)

commit 76d566c
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 11:56:06 2021 -0700

    Improve reauth, Config Flow and error handling (#452)

commit 847ee29
Author: Thibaut <[email protected]>
Date:   Wed Jul 14 19:09:43 2021 +0200

    Fix is_opening/closing for RTS devices (#464)

    Co-authored-by: Mick Vleeshouwer <[email protected]>

commit 560db42
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 10:01:12 2021 -0700

    Update pyhoma and require latest Home Assistant version (#473)
iMicknl added a commit that referenced this pull request Jul 14, 2021
commit 4a77161
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:52:07 2021 -0700

    Adds basic support for AtlanticElectricalHeaterWithAdjustableTemperatureSetpoint (#362)

commit 93a02ff
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:30:49 2021 -0700

    Add support for AtlanticElectricalTowelDryer (#423)

    * Add scaffold for feature/AtlanticElectricalTowelDryer

    * Update presets and other features

    * First clean up

    * remove comments

commit a4709cd
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:18:00 2021 -0700

    Adjust Atlantic Electrical Heater to new standards and fix issues (#454)

    * Adjust Atlantic Electrical Heater to new standards and fix issues

    * Add comfort mode

    * Add missing extra comfort presets

commit 65de131
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 13:41:35 2021 -0700

    Add more information regarding Model and Manufacturer (#474)

commit 76d566c
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 11:56:06 2021 -0700

    Improve reauth, Config Flow and error handling (#452)

commit 847ee29
Author: Thibaut <[email protected]>
Date:   Wed Jul 14 19:09:43 2021 +0200

    Fix is_opening/closing for RTS devices (#464)

    Co-authored-by: Mick Vleeshouwer <[email protected]>

commit 560db42
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 10:01:12 2021 -0700

    Update pyhoma and require latest Home Assistant version (#473)

commit 242e21d
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 08:01:55 2021 -0700

    Currently stale issues are closed too soon (#470)

commit c467aa4
Author: Thibaut <[email protected]>
Date:   Tue Jun 29 17:13:52 2021 +0200

    Fix is_opening/is_closing for RTS covers (#463)

commit 60f0766
Author: Thibaut <[email protected]>
Date:   Mon Jun 21 09:17:18 2021 +0200

    Support is_opening/closing when moving position (#460)

commit 39f485e
Author: Thibaut <[email protected]>
Date:   Mon May 31 17:27:48 2021 +0200

    Remove setPosition (#455)
iMicknl added a commit that referenced this pull request Jul 14, 2021
commit 1bbacf1
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 15:14:39 2021 -0700

    Add basic support for AtlanticPassAPCHeatingAndCoolingZone (#380)

commit 4a77161
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:52:07 2021 -0700

    Adds basic support for AtlanticElectricalHeaterWithAdjustableTemperatureSetpoint (#362)

commit 93a02ff
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:30:49 2021 -0700

    Add support for AtlanticElectricalTowelDryer (#423)

    * Add scaffold for feature/AtlanticElectricalTowelDryer

    * Update presets and other features

    * First clean up

    * remove comments

commit a4709cd
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:18:00 2021 -0700

    Adjust Atlantic Electrical Heater to new standards and fix issues (#454)

    * Adjust Atlantic Electrical Heater to new standards and fix issues

    * Add comfort mode

    * Add missing extra comfort presets

commit 65de131
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 13:41:35 2021 -0700

    Add more information regarding Model and Manufacturer (#474)

commit 76d566c
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 11:56:06 2021 -0700

    Improve reauth, Config Flow and error handling (#452)

commit 847ee29
Author: Thibaut <[email protected]>
Date:   Wed Jul 14 19:09:43 2021 +0200

    Fix is_opening/closing for RTS devices (#464)

    Co-authored-by: Mick Vleeshouwer <[email protected]>

commit 560db42
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 10:01:12 2021 -0700

    Update pyhoma and require latest Home Assistant version (#473)

commit 242e21d
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 08:01:55 2021 -0700

    Currently stale issues are closed too soon (#470)

commit c467aa4
Author: Thibaut <[email protected]>
Date:   Tue Jun 29 17:13:52 2021 +0200

    Fix is_opening/is_closing for RTS covers (#463)

commit 60f0766
Author: Thibaut <[email protected]>
Date:   Mon Jun 21 09:17:18 2021 +0200

    Support is_opening/closing when moving position (#460)

commit 39f485e
Author: Thibaut <[email protected]>
Date:   Mon May 31 17:27:48 2021 +0200

    Remove setPosition (#455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants