Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support is_opening/closing when moving position #460

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Support is_opening/closing when moving position #460

merged 1 commit into from
Jun 21, 2021

Conversation

tetienne
Copy link
Collaborator

@tetienne tetienne commented Jun 13, 2021 •
edited
Loading

Fix #459

@github-actions github-actions bot added the enhancement New feature or request label Jun 13, 2021
@tetienne tetienne force-pushed the enhancement/use_target_closure branch from 13053f3 to 3974caa Compare June 14, 2021 09:12
@tetienne tetienne marked this pull request as ready for review June 14, 2021 12:22
@tetienne
Copy link
Collaborator Author

@iMicknl It’s ok for you?

iMicknl
iMicknl reviewed Jun 20, 2021
View reviewed changes
custom_components/tahoma/cover.py
):
return True

is_moving = self.device.states[CORE_MOVING_STATE].value
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the loop through current executions, when we can look at the state as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it too. But I don’t know how it will work for the tilt. It’s why I keep it like this.

@tetienne tetienne merged commit 60f0766 into master Jun 21, 2021
@tetienne tetienne deleted the enhancement/use_target_closure branch June 21, 2021 07:17
@iMicknl iMicknl mentioned this pull request Jun 28, 2021
Closed
1 task
iMicknl added a commit that referenced this pull request Jul 14, 2021
@iMicknl
Squashed commit of the following:
93fd6df 
commit 4a77161
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:52:07 2021 -0700

    Adds basic support for AtlanticElectricalHeaterWithAdjustableTemperatureSetpoint (#362)

commit 93a02ff
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:30:49 2021 -0700

    Add support for AtlanticElectricalTowelDryer (#423)

    * Add scaffold for feature/AtlanticElectricalTowelDryer

    * Update presets and other features

    * First clean up

    * remove comments

commit a4709cd
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:18:00 2021 -0700

    Adjust Atlantic Electrical Heater to new standards and fix issues (#454)

    * Adjust Atlantic Electrical Heater to new standards and fix issues

    * Add comfort mode

    * Add missing extra comfort presets

commit 65de131
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 13:41:35 2021 -0700

    Add more information regarding Model and Manufacturer (#474)

commit 76d566c
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 11:56:06 2021 -0700

    Improve reauth, Config Flow and error handling (#452)

commit 847ee29
Author: Thibaut <[email protected]>
Date:   Wed Jul 14 19:09:43 2021 +0200

    Fix is_opening/closing for RTS devices (#464)

    Co-authored-by: Mick Vleeshouwer <[email protected]>

commit 560db42
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 10:01:12 2021 -0700

    Update pyhoma and require latest Home Assistant version (#473)

commit 242e21d
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 08:01:55 2021 -0700

    Currently stale issues are closed too soon (#470)

commit c467aa4
Author: Thibaut <[email protected]>
Date:   Tue Jun 29 17:13:52 2021 +0200

    Fix is_opening/is_closing for RTS covers (#463)

commit 60f0766
Author: Thibaut <[email protected]>
Date:   Mon Jun 21 09:17:18 2021 +0200

    Support is_opening/closing when moving position (#460)

commit 39f485e
Author: Thibaut <[email protected]>
Date:   Mon May 31 17:27:48 2021 +0200

    Remove setPosition (#455)
iMicknl added a commit that referenced this pull request Jul 14, 2021
@iMicknl
Squashed commit of the following:
1c2ac47 
commit 1bbacf1
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 15:14:39 2021 -0700

    Add basic support for AtlanticPassAPCHeatingAndCoolingZone (#380)

commit 4a77161
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:52:07 2021 -0700

    Adds basic support for AtlanticElectricalHeaterWithAdjustableTemperatureSetpoint (#362)

commit 93a02ff
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:30:49 2021 -0700

    Add support for AtlanticElectricalTowelDryer (#423)

    * Add scaffold for feature/AtlanticElectricalTowelDryer

    * Update presets and other features

    * First clean up

    * remove comments

commit a4709cd
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 14:18:00 2021 -0700

    Adjust Atlantic Electrical Heater to new standards and fix issues (#454)

    * Adjust Atlantic Electrical Heater to new standards and fix issues

    * Add comfort mode

    * Add missing extra comfort presets

commit 65de131
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 13:41:35 2021 -0700

    Add more information regarding Model and Manufacturer (#474)

commit 76d566c
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 11:56:06 2021 -0700

    Improve reauth, Config Flow and error handling (#452)

commit 847ee29
Author: Thibaut <[email protected]>
Date:   Wed Jul 14 19:09:43 2021 +0200

    Fix is_opening/closing for RTS devices (#464)

    Co-authored-by: Mick Vleeshouwer <[email protected]>

commit 560db42
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 10:01:12 2021 -0700

    Update pyhoma and require latest Home Assistant version (#473)

commit 242e21d
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Jul 14 08:01:55 2021 -0700

    Currently stale issues are closed too soon (#470)

commit c467aa4
Author: Thibaut <[email protected]>
Date:   Tue Jun 29 17:13:52 2021 +0200

    Fix is_opening/is_closing for RTS covers (#463)

commit 60f0766
Author: Thibaut <[email protected]>
Date:   Mon Jun 21 09:17:18 2021 +0200

    Support is_opening/closing when moving position (#460)

commit 39f485e
Author: Thibaut <[email protected]>
Date:   Mon May 31 17:27:48 2021 +0200

    Remove setPosition (#455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMicknl iMicknl iMicknl approved these changes

@vlebourl vlebourl vlebourl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update state and attributes when event received from TahomaClient
3 participants
@tetienne @iMicknl @vlebourl