Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Connectionless Offer #293

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Sep 18, 2024

Description:

Handling Connectionless Credential Offer, by storing the Offer message.
Also a little refactor moving the functionality to tasks.
And fixing test config

  • DIDComm Agent - just refactored to use tasks
  • findProtocolTypeByValue - removed orpahned function, logic moved to task
  • DIDCommConnectionRunner - logic moved to task
  • DIDCommInvitationRunner - logic moved to task

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h self-assigned this Sep 18, 2024
@curtis-h curtis-h force-pushed the feature/ATL-7492-connectionless-offer branch 3 times, most recently from 35b78e7 to 7a6f3a0 Compare September 18, 2024 12:01
Copy link

github-actions bot commented Sep 18, 2024

Lines Statements Branches Functions
Coverage: 76%
76.29% (3541/4641) 66.4% (1544/2325) 79.98% (855/1069)

@coveralls
Copy link

coveralls commented Sep 18, 2024

Pull Request Test Coverage Report for Build 10956115454

Details

  • 48 of 68 (70.59%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 72.788%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/edge-agent/didcomm/HandleOOBInvitation.ts 11 12 91.67%
src/edge-agent/didcomm/ParseOOBInvitation.ts 10 11 90.91%
src/edge-agent/didcomm/Agent.ts 8 11 72.73%
src/edge-agent/didcomm/ParseInvitation.ts 18 23 78.26%
src/edge-agent/didcomm/ParsePrismInvitation.ts 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
src/domain/utils/DER.ts 3 35.14%
Totals Coverage Status
Change from base Build 10956031905: 0.6%
Covered Lines: 3434
Relevant Lines: 4514

💛 - Coveralls

Copy link
Contributor

@elribonazo elribonazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@curtis-h curtis-h force-pushed the feature/ATL-7492-connectionless-offer branch from 7a6f3a0 to 186ecb1 Compare September 20, 2024 08:43
@curtis-h curtis-h merged commit 97e05e7 into main Sep 23, 2024
6 checks passed
@curtis-h curtis-h deleted the feature/ATL-7492-connectionless-offer branch September 23, 2024 09:03
hyperledger-bot added a commit that referenced this pull request Oct 4, 2024
# [6.1.0](v6.0.1...v6.1.0) (2024-10-04)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* e2e cucumber import ([#291](#291)) ([e569d79](e569d79))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* next generation building tools and testing framework ([#258](#258)) ([54ead35](54ead35))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))
* sdk module resolution issues ([#290](#290)) ([f53d728](f53d728))
* update code-owners ([#281](#281)) ([b8409af](b8409af))

### Features

* Connectionless Offer ([#293](#293)) ([97e05e7](97e05e7))
* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
* integrating error reporting protocol  ([#289](#289)) ([02430db](02430db))
* OIDC Agent ([#278](#278)) ([295e14f](295e14f))
* separate DIDCommAgent and adding Tasks ([#277](#277)) ([3a8fd66](3a8fd66))
elribonazo pushed a commit that referenced this pull request Oct 4, 2024
hyperledger-bot added a commit that referenced this pull request Oct 4, 2024
# [6.2.0](v6.1.1...v6.2.0) (2024-10-04)

### Bug Fixes

* e2e cucumber import ([#291](#291)) ([e569d79](e569d79))
* next generation building tools and testing framework ([#258](#258)) ([54ead35](54ead35))
* sdk module resolution issues ([#290](#290)) ([f53d728](f53d728))

### Features

* Connectionless Offer ([#293](#293)) ([97e05e7](97e05e7))
* integrating error reporting protocol  ([#289](#289)) ([02430db](02430db))
* OIDC Agent ([#278](#278)) ([295e14f](295e14f))
* separate DIDCommAgent and adding Tasks ([#277](#277)) ([3a8fd66](3a8fd66))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants