Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: decoupling JWT from Pollux and adding KID header to JWTs #271

Merged
merged 1 commit into from
Aug 23, 2024
Merged

feat: decoupling JWT from Pollux and adding KID header to JWTs #271

merged 1 commit into from
Aug 23, 2024

Conversation

curtis-h
Copy link
Contributor

Description:

Adding KID header into JWT signatures created in Pollux.
Took this opportunity to decouple JWT operations from Pollux, which is needed for OIDC.

  • added getSigningKid to Pollux to determine Kid to use in JWT header
  • moved basic JWT functionality (sign, decode) to Domain
  • added new utility method to DIDDocument to get VerificationMethods

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h self-assigned this Aug 22, 2024
@elribonazo elribonazo merged commit 8a1ed3f into main Aug 23, 2024
4 of 5 checks passed
@elribonazo elribonazo deleted the feature/7187-jwt-kid branch August 23, 2024 11:47
hyperledger-bot added a commit that referenced this pull request Sep 5, 2024
@hyperledger-bot
chore(release): release 6.1.0-rc.1
65a4323 
# [6.1.0-rc.1](v6.0.1...v6.1.0-rc.1) (2024-09-05)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))

### Features

* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
hyperledger-bot added a commit that referenced this pull request Sep 11, 2024
@hyperledger-bot
chore(release): release 6.1.0
a800afe 
# [6.1.0](v6.0.1...v6.1.0) (2024-09-11)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))
* update code-owners ([#281](#281)) ([b8409af](b8409af))

### Features

* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
hyperledger-bot added a commit that referenced this pull request Sep 12, 2024
@hyperledger-bot
chore(release): release 6.1.0
d8d84e6 
# [6.1.0](v6.0.1...v6.1.0) (2024-09-12)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))
* update code-owners ([#281](#281)) ([b8409af](b8409af))

### Features

* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
hyperledger-bot added a commit that referenced this pull request Oct 4, 2024
@hyperledger-bot
chore(release): release 6.1.0
498b035 
# [6.1.0](v6.0.1...v6.1.0) (2024-10-04)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* e2e cucumber import ([#291](#291)) ([e569d79](e569d79))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* next generation building tools and testing framework ([#258](#258)) ([54ead35](54ead35))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))
* sdk module resolution issues ([#290](#290)) ([f53d728](f53d728))
* update code-owners ([#281](#281)) ([b8409af](b8409af))

### Features

* Connectionless Offer ([#293](#293)) ([97e05e7](97e05e7))
* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
* integrating error reporting protocol  ([#289](#289)) ([02430db](02430db))
* OIDC Agent ([#278](#278)) ([295e14f](295e14f))
* separate DIDCommAgent and adding Tasks ([#277](#277)) ([3a8fd66](3a8fd66))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elribonazo elribonazo elribonazo approved these changes

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk

Assignees

@curtis-h curtis-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curtis-h @elribonazo