fix: merging multiple PeerDID classes #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This I don't agree. Why should the peer DID be in the domain? |
elribonazo
reviewed
Nov 27, 2023
|
Lets try to also be careful and asses if this is introducing a breaking change, etc + also make sure the demo content run as expected + tests. |
JUnit
|
elribonazo
approved these changes
Jan 1, 2024
elribonazo
force-pushed
the
fix/ATL-6215-PeerDIDs
branch
from
53c1ed5 to
3d28da7
Compare
@goncalo-frade-iohk moved the code to peerdid i think its also the right move, it was there previous thats ok but now in peerDID, waiting for plugins to happen. |
elribonazo
force-pushed
the
fix/ATL-6215-PeerDIDs
branch
from
6a5869a to
d95de6b
Compare
goncalo-frade-iohk
approved these changes
Jan 2, 2024
elribonazo
force-pushed
the
fix/ATL-6215-PeerDIDs
branch
from
d95de6b to
43796c4
Compare
BREAKING CHANGE: If you have imported Domain.PeerDID in your typescript application, you will need to re-import from PeerDID directly
elribonazo
force-pushed
the
fix/ATL-6215-PeerDIDs
branch
from
43796c4 to
521ad4c
Compare
mixmix
pushed a commit
to mixmix/atala-prism-wallet-sdk-ts
that referenced
this pull request
May 6, 2024
Co-authored-by: Francisco Javier Ribó Labrador <[email protected]> BREAKING CHANGE: If you have imported Domain.PeerDID in your typescript application, you will need to re-import from PeerDID directly Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge two PeerDID classes into Domain model.
Jira link
https://input-output.atlassian.net/browse/ATL-6215
Checklist