Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose functionality to create peerDIDs outside of the agent. #129

Closed
wants to merge 1 commit into from

Conversation

elribonazo
Copy link
Contributor

I would like to propose to expose the peerdid create function and make it available as part of the bundle in order to be able to create peerdids from existing keys outside of the agent.

The new exportes classes had been documented in the past so they are okey.

Description

No PR, this is an open proposal of improvement.

Jira link

N/A

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

Copy link

Lines Statements Branches Functions
Coverage: 37%
36.86% (1610/4367) 25.73% (712/2767) 40.14% (505/1258)

JUnit

Tests Skipped Failures Errors Time
298 2 💤 0 ❌ 0 🔥 1m 2s ⏱️

@elribonazo elribonazo requested a review from milosh86 November 26, 2023 21:13
@curtis-h
Copy link
Contributor

nothing against this in theory, but I think we've got some consideration to do for PeerDIDs
I noticed on Friday we've got two classes (fix here #130)
but I'm also wondering why is "peer-did" it's own folder? doesn't this belong in Castor?

@goncalo-frade-iohk
Copy link
Contributor

I got the same doubt as @curtis-h shouldn't this be inside of castor?

@goncalo-frade-iohk
Copy link
Contributor

If there is a requirement to make our funcionality of creating peer did public, lets do it inside castor. And make that class public by importing Castor.

@elribonazo
Copy link
Contributor Author

If there is a requirement to make our funcionality of creating peer did public, lets do it inside castor. And make that class public by importing Castor.

My mistake @goncalo-frade-iohk Castor satisfies that indeed, thank you!
Closing

@elribonazo elribonazo closed this Nov 27, 2023
@elribonazo elribonazo deleted the feature/expose-methods branch November 27, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants