Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mercury) : Added challenge domain and presentation definition #322

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

mineme0110
Copy link
Contributor

@mineme0110 mineme0110 commented Jan 23, 2023

Overview

Fixes ATL-xxxx

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@mineme0110 mineme0110 requested review from a team, atala-dev and essbante-io and removed request for a team January 23, 2023 10:20
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

Mercury Lib Test Results

26 tests   26 ✔️  3s ⏱️
16 suites    0 💤
16 files      0

Results for commit 747dc84.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

Mercury Lib Code Coverage

File Coverage
All files 18%
io/iohk/atala/AgentPrograms.scala 0%
io/iohk/atala/QRcode.scala 0%
io/iohk/atala/AgentClientCoordinateMediation.scala 0%
io/iohk/atala/QRcode.scala 0%
io/iohk/atala/AgentClientAlice.scala 0%
io/iohk/atala/AgentClientBob.scala 0%
io/iohk/atala/AgentPrograms.scala 0%
io/iohk/atala/mercury/AgentService.scala 0%
io/iohk/atala/mercury/ZioHttpClient.scala 0%
io/iohk/atala/mercury/AgentService.scala 0%
io/iohk/atala/mercury/PeerDID.scala 96%
io/iohk/atala/mercury/MessagingService.scala 0%
io/iohk/atala/mercury/AgentHardCode.scala 0%
io/iohk/atala/mercury/PeerDID.scala 0%
io/iohk/atala/mercury/InvitationPrograms.scala 0%
io/iohk/atala/mercury/HttpClient.scala 0%
io/iohk/atala/mercury/PeerDID.scala 0%
io/iohk/atala/mercury/DidComm.scala 0%
io/iohk/atala/mercury/CoordinateMediationPrograms.scala 0%
io/iohk/atala/mercury/PeerDID.scala 61%
io/iohk/atala/mercury/DidComm.scala 0%
io/iohk/atala/mercury/AgentCli.scala 0%
io/iohk/atala/mercury/OutOfBandLoginPrograms.scala 0%
io/iohk/atala/mercury/PeerDID.scala 94%
io/iohk/atala/mercury/ZioHttpClient.scala 0%
io/iohk/atala/mercury/model/SignedMesage.scala 0%
io/iohk/atala/mercury/model/JsonUtilsForDidCommx.scala 0%
io/iohk/atala/mercury/model/UnpackResult.scala 0%
io/iohk/atala/mercury/model/AttachmentDescriptor.scala 66%
io/iohk/atala/mercury/model/AttachmentDescriptor.scala 56%
io/iohk/atala/mercury/model/Conversions.scala 0%
io/iohk/atala/mercury/model/AttachmentDescriptor.scala 75%
io/iohk/atala/mercury/model/Conversions.scala 0%
io/iohk/atala/mercury/model/AttachmentDescriptor.scala 75%
io/iohk/atala/mercury/model/Conversions.scala 0%
io/iohk/atala/mercury/model/AttachmentDescriptor.scala 75%
io/iohk/atala/mercury/model/Conversions.scala 0%
io/iohk/atala/mercury/model/package.scala 0%
io/iohk/atala/mercury/model/Conversions.scala 0%
io/iohk/atala/mercury/model/package.scala 0%
io/iohk/atala/mercury/model/Conversions.scala 0%
io/iohk/atala/mercury/model/AttachmentDescriptor.scala 0%
io/iohk/atala/mercury/model/AttachmentDescriptor.scala 94%
io/iohk/atala/mercury/model/AttachmentDescriptor.scala 0%
io/iohk/atala/mercury/model/JsonUtilsForDidCommx.scala 0%
io/iohk/atala/mercury/model/Message.scala 90%
io/iohk/atala/mercury/model/package.scala 0%
io/iohk/atala/mercury/model/EncryptedMessage.scala 0%
io/iohk/atala/mercury/model/AttachmentDescriptor.scala 0%
io/iohk/atala/mercury/model/Conversions.scala 0%
io/iohk/atala/mercury/model/error/package.scala 0%
io/iohk/atala/mercury/model/error/package.scala 0%
io/iohk/atala/mercury/model/error/package.scala 0%
io/iohk/atala/mercury/model/error/package.scala 0%
io/iohk/atala/mercury/protocol/connection/ConnectionResponse.scala 28%
io/iohk/atala/mercury/protocol/connection/ConnectionRequest.scala 75%
io/iohk/atala/mercury/protocol/connection/ConnectionResponse.scala 61%
io/iohk/atala/mercury/protocol/connection/ConnectionRequest.scala 28%
io/iohk/atala/mercury/protocol/connection/ConnectionRequest.scala 46%
io/iohk/atala/mercury/protocol/connection/OutOfBandConnection.scala 0%
io/iohk/atala/mercury/protocol/connection/ConnectionResponse.scala 16%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 83%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 50%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 50%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 83%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 50%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/coordinatemediation/CoordinateMediation.scala 0%
io/iohk/atala/mercury/protocol/invitation/OutOfBand.scala 78%
io/iohk/atala/mercury/protocol/invitation/ServiceType.scala 59%
io/iohk/atala/mercury/protocol/invitation/ServiceType.scala 0%
io/iohk/atala/mercury/protocol/invitation/ServiceType.scala 0%
io/iohk/atala/mercury/protocol/invitation/package.scala 0%
io/iohk/atala/mercury/protocol/invitation/ServiceType.scala 0%
io/iohk/atala/mercury/protocol/invitation/v1/Invitation.scala 94%
io/iohk/atala/mercury/protocol/invitation/v1/Invitation.scala 0%
io/iohk/atala/mercury/protocol/invitation/v2/Invitation.scala 59%
io/iohk/atala/mercury/protocol/invitation/v2/Invitation.scala 29%
io/iohk/atala/mercury/protocol/invitation/v2/Invitation.scala 57%
io/iohk/atala/mercury/protocol/invitation/v2/Invitation.scala 75%
io/iohk/atala/mercury/protocol/issuecredential/OfferCredential.scala 63%
io/iohk/atala/mercury/protocol/issuecredential/ProposeCredential.scala 66%
io/iohk/atala/mercury/protocol/issuecredential/IssueCredential.scala 65%
io/iohk/atala/mercury/protocol/issuecredential/IssueCredential.scala 62%
io/iohk/atala/mercury/protocol/issuecredential/OfferCredential.scala 62%
io/iohk/atala/mercury/protocol/issuecredential/Utils.scala 55%
io/iohk/atala/mercury/protocol/issuecredential/OfferCredential.scala 65%
io/iohk/atala/mercury/protocol/issuecredential/RequestCredential.scala 95%
io/iohk/atala/mercury/protocol/issuecredential/RequestCredential.scala 59%
io/iohk/atala/mercury/protocol/issuecredential/ProposeCredential.scala 61%
io/iohk/atala/mercury/protocol/mailbox/Mailbox.scala 0%
io/iohk/atala/mercury/protocol/mailbox/Mailbox.scala 0%
io/iohk/atala/mercury/protocol/mailbox/Mailbox.scala 0%
io/iohk/atala/mercury/protocol/outofbandlogin/OutOfBandLogin.scala 0%
io/iohk/atala/mercury/protocol/outofbandlogin/OutOfBandLogin.scala 0%
io/iohk/atala/mercury/protocol/outofbandlogin/OutOfBandLogin.scala 0%
io/iohk/atala/mercury/protocol/outofbandlogin/Utils.scala 0%
io/iohk/atala/mercury/protocol/outofbandlogin/OutOfBandLogin.scala 0%
io/iohk/atala/mercury/protocol/presentproof/ProposePresentation.scala 15%
io/iohk/atala/mercury/protocol/presentproof/PresentationAttachment.scala 75%
io/iohk/atala/mercury/protocol/presentproof/Presentation.scala 31%
io/iohk/atala/mercury/protocol/presentproof/PresentationAttachment.scala 58%
io/iohk/atala/mercury/protocol/presentproof/Presentation.scala 0%
io/iohk/atala/mercury/protocol/presentproof/ProposePresentation.scala 31%
io/iohk/atala/mercury/protocol/presentproof/PresentationAttachment.scala 69%
io/iohk/atala/mercury/protocol/presentproof/PresentationAttachment.scala 68%
io/iohk/atala/mercury/protocol/presentproof/RequestPresentation.scala 0%
io/iohk/atala/mercury/protocol/presentproof/Presentation.scala 13%
io/iohk/atala/mercury/protocol/presentproof/PresentationAttachment.scala 75%
io/iohk/atala/mercury/protocol/presentproof/PresentationAttachment.scala 54%
io/iohk/atala/mercury/protocol/presentproof/PresentationAttachment.scala 0%
io/iohk/atala/mercury/protocol/presentproof/RequestPresentation.scala 84%
io/iohk/atala/mercury/protocol/presentproof/RequestPresentation.scala 14%
io/iohk/atala/mercury/protocol/presentproof/PresentationAttachment.scala 75%
io/iohk/atala/mercury/protocol/presentproof/PresentationAttachment.scala 62%
io/iohk/atala/mercury/protocol/presentproof/ProofType.scala 75%
io/iohk/atala/mercury/protocol/reportproblem/v1/ReportProblem.scala 0%
io/iohk/atala/mercury/protocol/reportproblem/v1/ReportProblem.scala 0%
io/iohk/atala/mercury/protocol/reportproblem/v1/ReportProblem.scala 0%
io/iohk/atala/mercury/protocol/reportproblem/v2/ReportProblem.scala 0%
io/iohk/atala/mercury/protocol/reportproblem/v2/ReportProblem.scala 0%
io/iohk/atala/mercury/protocol/reportproblem/v2/ReportProblem.scala 0%
io/iohk/atala/mercury/protocol/routing/ForwardMessage.scala 0%
io/iohk/atala/mercury/protocol/routing/ForwardMessage.scala 0%
io/iohk/atala/resolvers/MediatorDidDoc.scala 0%
io/iohk/atala/resolvers/AliceSecretResolver.scala 0%
io/iohk/atala/resolvers/BobSecretResolver.scala 0%
io/iohk/atala/resolvers/BobDidDoc.scala 0%
io/iohk/atala/resolvers/UniversalDidResolver.scala 0%
io/iohk/atala/resolvers/DidValidator.scala 83%
io/iohk/atala/resolvers/PeerDidResolver.scala 60%
io/iohk/atala/resolvers/UniversalDidResolver.scala 0%
io/iohk/atala/resolvers/UniversalDidResolver.scala 0%
io/iohk/atala/resolvers/AliceDidDoc.scala 0%
io/iohk/atala/resolvers/PeerDidMediatorSecretResolver.scala 0%
io/iohk/atala/resolvers/PeerDidResolver.scala 81%

Minimum allowed coverage is 10%

Generated by 🐒 cobertura-action against 747dc84

@atala-dev
Copy link
Contributor

atala-dev commented Jan 23, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors
✅ REPOSITORY dustilock yes no
✅ REPOSITORY git_diff yes no
✅ REPOSITORY syft yes no

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now

}
case any => {
println("*****NotImplemented***" + any.getClass().getCanonicalName() + "**********") // FIXME
???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this method returns a ZIO
We have to change a lot of code, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it will be more refactoring required

@mineme0110 mineme0110 merged commit da288bf into main Jan 24, 2023
@mineme0110 mineme0110 deleted the ATL-2880-Challenge-Domain branch January 24, 2023 12:21
mineme0110 added a commit that referenced this pull request Aug 17, 2023
…epo subject to the Developer Certificate of Origin (DCO), Version 1.1.

cf49ac5 docs: Update status of the ADR for multi-tenancy routing [skip ci] (#547)
fe5920b docs: ADR for mediator-message-storage [skip ci] (#530)
6452ec3 docs: ADR for multi-tenancy routing [skip ci] (#523)
f3e705c test(pollux) : Added test for service (#507)
b271ac0 test(pollux): Unit test added for JDBCRepo (#494)
948f2fc feat(prism-agent): Update the connect pollux and mercury to fix to use nimbus-jose-jwt 10.0.0-preview (#467)
8444057 feat(connect): Updated the mercury version for jwt (#466)
67e3622 feat(mercury): Added the resolver and update the nimbus libray to pre… (#465)
adb7000 feat(prism-agent): Update pollux lib to 0.43.0 includes the nimbus-jo… (#460)
8c0070f feat(pollux): Update the nimbus-jose-jwt library with a patch 10.0.0-preview (#457)
ee93880 feat(prism-agent): VerificationOptions are configurable for PrismAgent (#449)
301022a feat(prism-agent): Added connectionId to the request Presentation and deleted the readme files as they are moved here https://github.com/input-output-hk/atala-prism-building-blocks/tree/main/docs/docusaurus (#432)
8f52b12 feat(mercury): Code cleanup removed the Presentation Attachment and added to the Pollux (#365)
55569ed feat(prism-agent): Added new state PresentationVerificationFailed (#412)
94031f8 feat(pollux): Added new state PresentationVerificationFailed (#400)
bff8d21 feat(connect): Updated version for mercury (#398)
faac0a7 feat(pollux): Updated version for mercury (#399)
403f4c2 feat(mercury): ReportProblem Protocol updated with test and updated t… (#396)
409b673 feat(prsim-agent): pollux version updated (#392)
2765845 feat(pollux): Moving the check when accepting the credential to crea… (#391)
35704f4 feat(pollux): Added the Issued credetinal check at the ApiEndpoint (#387)
4f0b261 feat(prism-agent): Added challenge and domain and to protect agains r… (#364)
5349a0e feat(pollux): Added New Erorr (#363)
abc007f feat(pollux) : Added challenge and domain (#361)
da288bf feat(mercury) : Added challenge domain and presentation definition (#322)
cf2b2d3 fix(mercury) : fix the test for attachment (#312)
cc7c533 feat(prismagent): prism did creation and use  updated protocol state (#291)
859c29e feat(pullux): dummy commit for release (#293)
174fe52 feat(pollux): added column credentionals_to_use and new state present… (#288) (#290)
25a1df1 feat:(pollux) added column credentionals_to_use and new state presentation generated (#289)
7c7f051 feat:(pollux) added column credentionals_to_use and new state present… (#288)
ae74e20 feat(prism-agnet): Verifiable Credential (#281)
a87dc17 feat(pollux): Added JWT verfication (#280)
7629eab feat(connect): updated  the version for mercury (#246)
a2af672 feat(pollux): updated  the version for mercury (#245)
b704abc feat(pollux): Added new state (#234)
cd416bf feat(pollux): Added a new column to the table to store the issued credential
faf3e6f added thid (#183)
f7cba3b feat(prism-agent): implement Connect flow (#130)
7f0f412 feat(pollux): Verify PresentProof Protocol (#149)
96b0fbc feat(connect): removed the unwanted dependencies (#145)
e4d4a41 feat(connect): Added Connect Lib (#138)
402248b feat(mercury): ATL-2287 Connection Protocol (#140)
46ef902 addedd the connect to lint (#143)
b37b762 feat(mercury): [WIP] ATL-1741-Present-Proof-Protocol (#98)
21fe5bc feat(mercury): ATL-1740 issue credential (#64)
bb4dfe5 ATL-1738-Aries-RFC-0023-DIDExchange-Protocol (#29)
f160a51 ATL-1886-Fix issue (#54)
c0fb7aa ATL-1893-DidPeerResolver (#36)
57ed209 Aries RFC 0434: Out-of-Band Protocol 1.1 (#22)

Signed-off-by: Shailesh Patil <[email protected]>
antonbaliasnikov pushed a commit that referenced this pull request Aug 21, 2023
…epo subject to the Developer Certificate of Origin (DCO), Version 1.1.

cf49ac5 docs: Update status of the ADR for multi-tenancy routing [skip ci] (#547)
fe5920b docs: ADR for mediator-message-storage [skip ci] (#530)
6452ec3 docs: ADR for multi-tenancy routing [skip ci] (#523)
f3e705c test(pollux) : Added test for service (#507)
b271ac0 test(pollux): Unit test added for JDBCRepo (#494)
948f2fc feat(prism-agent): Update the connect pollux and mercury to fix to use nimbus-jose-jwt 10.0.0-preview (#467)
8444057 feat(connect): Updated the mercury version for jwt (#466)
67e3622 feat(mercury): Added the resolver and update the nimbus libray to pre… (#465)
adb7000 feat(prism-agent): Update pollux lib to 0.43.0 includes the nimbus-jo… (#460)
8c0070f feat(pollux): Update the nimbus-jose-jwt library with a patch 10.0.0-preview (#457)
ee93880 feat(prism-agent): VerificationOptions are configurable for PrismAgent (#449)
301022a feat(prism-agent): Added connectionId to the request Presentation and deleted the readme files as they are moved here https://github.com/input-output-hk/atala-prism-building-blocks/tree/main/docs/docusaurus (#432)
8f52b12 feat(mercury): Code cleanup removed the Presentation Attachment and added to the Pollux (#365)
55569ed feat(prism-agent): Added new state PresentationVerificationFailed (#412)
94031f8 feat(pollux): Added new state PresentationVerificationFailed (#400)
bff8d21 feat(connect): Updated version for mercury (#398)
faac0a7 feat(pollux): Updated version for mercury (#399)
403f4c2 feat(mercury): ReportProblem Protocol updated with test and updated t… (#396)
409b673 feat(prsim-agent): pollux version updated (#392)
2765845 feat(pollux): Moving the check when accepting the credential to crea… (#391)
35704f4 feat(pollux): Added the Issued credetinal check at the ApiEndpoint (#387)
4f0b261 feat(prism-agent): Added challenge and domain and to protect agains r… (#364)
5349a0e feat(pollux): Added New Erorr (#363)
abc007f feat(pollux) : Added challenge and domain (#361)
da288bf feat(mercury) : Added challenge domain and presentation definition (#322)
cf2b2d3 fix(mercury) : fix the test for attachment (#312)
cc7c533 feat(prismagent): prism did creation and use  updated protocol state (#291)
859c29e feat(pullux): dummy commit for release (#293)
174fe52 feat(pollux): added column credentionals_to_use and new state present… (#288) (#290)
25a1df1 feat:(pollux) added column credentionals_to_use and new state presentation generated (#289)
7c7f051 feat:(pollux) added column credentionals_to_use and new state present… (#288)
ae74e20 feat(prism-agnet): Verifiable Credential (#281)
a87dc17 feat(pollux): Added JWT verfication (#280)
7629eab feat(connect): updated  the version for mercury (#246)
a2af672 feat(pollux): updated  the version for mercury (#245)
b704abc feat(pollux): Added new state (#234)
cd416bf feat(pollux): Added a new column to the table to store the issued credential
faf3e6f added thid (#183)
f7cba3b feat(prism-agent): implement Connect flow (#130)
7f0f412 feat(pollux): Verify PresentProof Protocol (#149)
96b0fbc feat(connect): removed the unwanted dependencies (#145)
e4d4a41 feat(connect): Added Connect Lib (#138)
402248b feat(mercury): ATL-2287 Connection Protocol (#140)
46ef902 addedd the connect to lint (#143)
b37b762 feat(mercury): [WIP] ATL-1741-Present-Proof-Protocol (#98)
21fe5bc feat(mercury): ATL-1740 issue credential (#64)
bb4dfe5 ATL-1738-Aries-RFC-0023-DIDExchange-Protocol (#29)
f160a51 ATL-1886-Fix issue (#54)
c0fb7aa ATL-1893-DidPeerResolver (#36)
57ed209 Aries RFC 0434: Out-of-Band Protocol 1.1 (#22)

Signed-off-by: Shailesh Patil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants