Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aries RFC 0434: Out-of-Band Protocol 1.1 #22

Merged
merged 9 commits into from
Sep 16, 2022
Merged

Aries RFC 0434: Out-of-Band Protocol 1.1 #22

merged 9 commits into from
Sep 16, 2022

Conversation

mineme0110
Copy link
Contributor

@mineme0110 mineme0110 commented Sep 9, 2022 •
edited
Loading

Overview

Aries RFC 0434: Out-of-Band Protocol

Added features

Added out-of-band protocol protocol
The Out-of-band protocol is used when you wish to engage with another agent and you don't have a DIDComm connection to use for the interaction.

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

@mineme0110 mineme0110 requested review from a team, loverdos and essbante-io and removed request for a team September 9, 2022 10:54
@mineme0110 mineme0110 changed the title [WIP] Aries RFC 0434: Out-of-Band Protocol 1.1 Aries RFC 0434: Out-of-Band Protocol 1.1 Sep 15, 2022
@mineme0110 mineme0110 force-pushed the ATL-1739-Aries-RFC-0434-Out-of-Band-Protocol branch from 53cb4fb to cdf6946 Compare September 16, 2022 07:41
FabioPinheiro
FabioPinheiro approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clean up a bit and committed the changes we did this morning.
LGTM

I think we can do a squash merge commit and figure out what other utility methods we need after.

@mineme0110 mineme0110 merged commit 57ed209 into main Sep 16, 2022
@antonbaliasnikov antonbaliasnikov deleted the ATL-1739-Aries-RFC-0434-Out-of-Band-Protocol branch March 21, 2023 11:29
mineme0110 added a commit that referenced this pull request Aug 17, 2023
@mineme0110
I, Shailesh Patil hereby sign-off-by all of my past commits to this r…
9ef8715 
…epo subject to the Developer Certificate of Origin (DCO), Version 1.1.

cf49ac5 docs: Update status of the ADR for multi-tenancy routing [skip ci] (#547)
fe5920b docs: ADR for mediator-message-storage [skip ci] (#530)
6452ec3 docs: ADR for multi-tenancy routing [skip ci] (#523)
f3e705c test(pollux) : Added test for service (#507)
b271ac0 test(pollux): Unit test added for JDBCRepo (#494)
948f2fc feat(prism-agent): Update the connect pollux and mercury to fix to use nimbus-jose-jwt 10.0.0-preview (#467)
8444057 feat(connect): Updated the mercury version for jwt (#466)
67e3622 feat(mercury): Added the resolver and update the nimbus libray to pre… (#465)
adb7000 feat(prism-agent): Update pollux lib to 0.43.0 includes the nimbus-jo… (#460)
8c0070f feat(pollux): Update the nimbus-jose-jwt library with a patch 10.0.0-preview (#457)
ee93880 feat(prism-agent): VerificationOptions are configurable for PrismAgent (#449)
301022a feat(prism-agent): Added connectionId to the request Presentation and deleted the readme files as they are moved here https://github.com/input-output-hk/atala-prism-building-blocks/tree/main/docs/docusaurus (#432)
8f52b12 feat(mercury): Code cleanup removed the Presentation Attachment and added to the Pollux (#365)
55569ed feat(prism-agent): Added new state PresentationVerificationFailed (#412)
94031f8 feat(pollux): Added new state PresentationVerificationFailed (#400)
bff8d21 feat(connect): Updated version for mercury (#398)
faac0a7 feat(pollux): Updated version for mercury (#399)
403f4c2 feat(mercury): ReportProblem Protocol updated with test and updated t… (#396)
409b673 feat(prsim-agent): pollux version updated (#392)
2765845 feat(pollux): Moving the check when accepting the credential to crea… (#391)
35704f4 feat(pollux): Added the Issued credetinal check at the ApiEndpoint (#387)
4f0b261 feat(prism-agent): Added challenge and domain and to protect agains r… (#364)
5349a0e feat(pollux): Added New Erorr (#363)
abc007f feat(pollux) : Added challenge and domain (#361)
da288bf feat(mercury) : Added challenge domain and presentation definition (#322)
cf2b2d3 fix(mercury) : fix the test for attachment (#312)
cc7c533 feat(prismagent): prism did creation and use  updated protocol state (#291)
859c29e feat(pullux): dummy commit for release (#293)
174fe52 feat(pollux): added column credentionals_to_use and new state present… (#288) (#290)
25a1df1 feat:(pollux) added column credentionals_to_use and new state presentation generated (#289)
7c7f051 feat:(pollux) added column credentionals_to_use and new state present… (#288)
ae74e20 feat(prism-agnet): Verifiable Credential (#281)
a87dc17 feat(pollux): Added JWT verfication (#280)
7629eab feat(connect): updated  the version for mercury (#246)
a2af672 feat(pollux): updated  the version for mercury (#245)
b704abc feat(pollux): Added new state (#234)
cd416bf feat(pollux): Added a new column to the table to store the issued credential
faf3e6f added thid (#183)
f7cba3b feat(prism-agent): implement Connect flow (#130)
7f0f412 feat(pollux): Verify PresentProof Protocol (#149)
96b0fbc feat(connect): removed the unwanted dependencies (#145)
e4d4a41 feat(connect): Added Connect Lib (#138)
402248b feat(mercury): ATL-2287 Connection Protocol (#140)
46ef902 addedd the connect to lint (#143)
b37b762 feat(mercury): [WIP] ATL-1741-Present-Proof-Protocol (#98)
21fe5bc feat(mercury): ATL-1740 issue credential (#64)
bb4dfe5 ATL-1738-Aries-RFC-0023-DIDExchange-Protocol (#29)
f160a51 ATL-1886-Fix issue (#54)
c0fb7aa ATL-1893-DidPeerResolver (#36)
57ed209 Aries RFC 0434: Out-of-Band Protocol 1.1 (#22)

Signed-off-by: Shailesh Patil <[email protected]>
@mineme0110 mineme0110 mentioned this pull request Aug 17, 2023
Merged
14 tasks
antonbaliasnikov pushed a commit that referenced this pull request Aug 21, 2023
@mineme0110
I, Shailesh Patil hereby sign-off-by all of my past commits to this r…
3b3b43a 
…epo subject to the Developer Certificate of Origin (DCO), Version 1.1.

cf49ac5 docs: Update status of the ADR for multi-tenancy routing [skip ci] (#547)
fe5920b docs: ADR for mediator-message-storage [skip ci] (#530)
6452ec3 docs: ADR for multi-tenancy routing [skip ci] (#523)
f3e705c test(pollux) : Added test for service (#507)
b271ac0 test(pollux): Unit test added for JDBCRepo (#494)
948f2fc feat(prism-agent): Update the connect pollux and mercury to fix to use nimbus-jose-jwt 10.0.0-preview (#467)
8444057 feat(connect): Updated the mercury version for jwt (#466)
67e3622 feat(mercury): Added the resolver and update the nimbus libray to pre… (#465)
adb7000 feat(prism-agent): Update pollux lib to 0.43.0 includes the nimbus-jo… (#460)
8c0070f feat(pollux): Update the nimbus-jose-jwt library with a patch 10.0.0-preview (#457)
ee93880 feat(prism-agent): VerificationOptions are configurable for PrismAgent (#449)
301022a feat(prism-agent): Added connectionId to the request Presentation and deleted the readme files as they are moved here https://github.com/input-output-hk/atala-prism-building-blocks/tree/main/docs/docusaurus (#432)
8f52b12 feat(mercury): Code cleanup removed the Presentation Attachment and added to the Pollux (#365)
55569ed feat(prism-agent): Added new state PresentationVerificationFailed (#412)
94031f8 feat(pollux): Added new state PresentationVerificationFailed (#400)
bff8d21 feat(connect): Updated version for mercury (#398)
faac0a7 feat(pollux): Updated version for mercury (#399)
403f4c2 feat(mercury): ReportProblem Protocol updated with test and updated t… (#396)
409b673 feat(prsim-agent): pollux version updated (#392)
2765845 feat(pollux): Moving the check when accepting the credential to crea… (#391)
35704f4 feat(pollux): Added the Issued credetinal check at the ApiEndpoint (#387)
4f0b261 feat(prism-agent): Added challenge and domain and to protect agains r… (#364)
5349a0e feat(pollux): Added New Erorr (#363)
abc007f feat(pollux) : Added challenge and domain (#361)
da288bf feat(mercury) : Added challenge domain and presentation definition (#322)
cf2b2d3 fix(mercury) : fix the test for attachment (#312)
cc7c533 feat(prismagent): prism did creation and use  updated protocol state (#291)
859c29e feat(pullux): dummy commit for release (#293)
174fe52 feat(pollux): added column credentionals_to_use and new state present… (#288) (#290)
25a1df1 feat:(pollux) added column credentionals_to_use and new state presentation generated (#289)
7c7f051 feat:(pollux) added column credentionals_to_use and new state present… (#288)
ae74e20 feat(prism-agnet): Verifiable Credential (#281)
a87dc17 feat(pollux): Added JWT verfication (#280)
7629eab feat(connect): updated  the version for mercury (#246)
a2af672 feat(pollux): updated  the version for mercury (#245)
b704abc feat(pollux): Added new state (#234)
cd416bf feat(pollux): Added a new column to the table to store the issued credential
faf3e6f added thid (#183)
f7cba3b feat(prism-agent): implement Connect flow (#130)
7f0f412 feat(pollux): Verify PresentProof Protocol (#149)
96b0fbc feat(connect): removed the unwanted dependencies (#145)
e4d4a41 feat(connect): Added Connect Lib (#138)
402248b feat(mercury): ATL-2287 Connection Protocol (#140)
46ef902 addedd the connect to lint (#143)
b37b762 feat(mercury): [WIP] ATL-1741-Present-Proof-Protocol (#98)
21fe5bc feat(mercury): ATL-1740 issue credential (#64)
bb4dfe5 ATL-1738-Aries-RFC-0023-DIDExchange-Protocol (#29)
f160a51 ATL-1886-Fix issue (#54)
c0fb7aa ATL-1893-DidPeerResolver (#36)
57ed209 Aries RFC 0434: Out-of-Band Protocol 1.1 (#22)

Signed-off-by: Shailesh Patil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@FabioPinheiro FabioPinheiro FabioPinheiro approved these changes

@loverdos loverdos Awaiting requested review from loverdos

@essbante-io essbante-io Awaiting requested review from essbante-io

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mineme0110 @FabioPinheiro @yshyn-iohk @atala-dev