Fix ClassCastException in DebugMetrics nested structures [#7383] #7499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves an issue where Double values in nested metric structures were incorrectly cast to Map objects, causing a ClassCastException. The fix allows for proper handling of both direct values and nested structures at the same level. A comprehensive test case has been added to reproduce the bug and verify the fix, ensuring that complex, dynamically nested metric structures can be handled without errors. Resolves: hyperledger#7383 Signed-off-by: Ade Lucas <[email protected]>
This commit adds a new entry to `CHANGELOG.md` detailing the fix for the `ClassCastException` in `DebugMetrics`. Additionally, `DebugMetricsTest.java` has been reformatted using `spotlessApply` to ensure code style consistency. These changes contribute to maintaining clear documentation and code quality in the project. Resolves: hyperledger#7383 Signed-off-by: Ade Lucas <[email protected]>
Signed-off-by: garyschulte <[email protected]> Signed-off-by: Ade Lucas <[email protected]>
…#7483) Add pending block header to TransactionEvaluationContext plugin API, so PluginTransactionSelector can access info of the pending block. --- Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Usman Saleem <[email protected]> Signed-off-by: Ade Lucas <[email protected]>
Signed-off-by: Snazzy <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Ade Lucas <[email protected]>
Update the EOF validation error strings so that they can validate against expected exceptions in reference tests. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Ade Lucas <[email protected]>
) * 5098: Add RpcErrorTypes Signed-off-by: Matilda Clerke <[email protected]> --------- Signed-off-by: Matilda Clerke <[email protected]> Signed-off-by: Matilda-Clerke <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Ade Lucas <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Ade Lucas <[email protected]>
cloudspores
force-pushed
the
issue-7383-debug_metrics-method-error
branch
from
ae7bdf9
to
4534020
Compare
This commit merges updates from the main branch into the current branch and resolves a conflict in the CHANGELOG.md file. Both the changelog entry for the DebugMetrics fix and the additions from the main branch have been preserved. This ensures that the documentation for upcoming releases is consistent and complete. Signed-off-by: Ade Lucas <[email protected]>
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
…#7383] (hyperledger#7499) * Fix ClassCastException in DebugMetrics nested structures This commit resolves an issue where Double values in nested metric structures were incorrectly cast to Map objects, causing a ClassCastException. The fix allows for proper handling of both direct values and nested structures at the same level. A comprehensive test case has been added to reproduce the bug and verify the fix, ensuring that complex, dynamically nested metric structures can be handled without errors. Resolves: hyperledger#7383 Signed-off-by: Ade Lucas <[email protected]> --------- Signed-off-by: Ade Lucas <[email protected]> Signed-off-by: garyschulte <[email protected]> Signed-off-by: Snazzy <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Matilda Clerke <[email protected]> Signed-off-by: Matilda-Clerke <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: garyschulte <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: gringsam <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Matilda-Clerke <[email protected]> Signed-off-by: gconnect <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves an issue where Double values in nested metric structures were incorrectly cast to Map objects, causing a ClassCastException. The fix allows for proper handling of both direct values and nested structures at the same level.
A comprehensive test case has been added to reproduce the bug and verify the fix, ensuring that complex, dynamically nested metric structures can be handled without errors.
Resolves: #7383
PR description
Fixed Issue(s)
"fixes #7383"
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests