CI Fix: Preprocess release title in gha #7486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
force-pushed
the
fix/release-version-preprocess
branch
5 times, most recently
from
eb94deb
to
c1dbeef
Compare
Signed-off-by: garyschulte <[email protected]>
garyschulte
force-pushed
the
fix/release-version-preprocess
branch
from
c1dbeef
to
ff8e322
Compare
siladu
approved these changes
Aug 19, 2024
| # strip all whitespace | ||
| RELEASE_NAME="${RELEASE_NAME//[[:space:]]/}" | ||
| if [[ ! "$RELEASE_NAME" =~ ^[0-9]+\.[0-9]+(\.[0-9]+)?(-.*)?$ ]]; then | ||
| echo "Release name does not conform to a valid besu release format YY.M.v[-suffix], e.g. 24.8.0-RC1." |
There was a problem hiding this comment.
Wonder if we should make this strictly full release since this workflow is triggered by the released type which doesn't include pre-releases.
There was a problem hiding this comment.
I think the flexibility is worth it, there is historical precedent for publishing -* releases, like for verkle or testnets etc
There was a problem hiding this comment.
In terms of github technicalities, would these be published as full releases rather than a pre-release then?
cloudspores
pushed a commit
to cloudspores/besu
that referenced
this pull request
Aug 20, 2024
Signed-off-by: garyschulte <[email protected]>
cloudspores
pushed a commit
to cloudspores/besu
that referenced
this pull request
Aug 20, 2024
Signed-off-by: garyschulte <[email protected]> Signed-off-by: Ade Lucas <[email protected]>
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
Signed-off-by: garyschulte <[email protected]> Signed-off-by: gconnect <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
pre-process release title in release actions to ensure it conforms to a besu release version and trim any leading or trailing spaces
Tested on forked repo with a variety of whitespace and failure modes.