-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow empty maxFeePerBlobGas for eth_call #6731
allow empty maxFeePerBlobGas for eth_call #6731
Conversation
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
@fab-10 does it makes sense to add the blob gas checks under the |
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/transaction/TransactionSimulator.java
Outdated
Show resolved
Hide resolved
yes it makes sense to me |
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
engine-cancun hive tests passing locally except for occasional known flakiness from |
* allow empty blob gas for eth_call * handle empty maxFeePerBlobGas by setting to blobBaseFee if empty * set allowExceedingBalance if blobGas not specified * added a test case for strict with zero blob gas Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: amsmota <[email protected]>
* allow empty blob gas for eth_call * handle empty maxFeePerBlobGas by setting to blobBaseFee if empty * set allowExceedingBalance if blobGas not specified * added a test case for strict with zero blob gas Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: amsmota <[email protected]>
* allow empty blob gas for eth_call * handle empty maxFeePerBlobGas by setting to blobBaseFee if empty * set allowExceedingBalance if blobGas not specified * added a test case for strict with zero blob gas Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Justin Florentine <[email protected]>
PR description
Fixed Issue(s)
fixes #6709
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Most advanced CI tests are deferred until PR approval, but you could:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests
engine-cancun
suite