Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make maxBlobFeePerGas optional for eth_call with blob versionedHashes #6709

Closed
macfarla opened this issue Mar 11, 2024 · 0 comments · Fixed by #6731
Closed

make maxBlobFeePerGas optional for eth_call with blob versionedHashes #6709

macfarla opened this issue Mar 11, 2024 · 0 comments · Fixed by #6731
Assignees
@macfarla
Labels
bug Something isn't working P2 High (ex: Degrading performance issues, unexpected behavior of core features (DevP2P, syncing, etc)) RPC

Comments

@macfarla
Copy link
Contributor

Follow up to #6657

We shouldn’t require maxFeePerBlobGas for eth_call for the same reason regular gas fee settings aren’t necessary for eth_call for transactions without blobs.

Current implementation uses transaction validation so this would require checking the fields on the eth_call CallParameter
@non-fungible-nelson non-fungible-nelson added P2 High (ex: Degrading performance issues, unexpected behavior of core features (DevP2P, syncing, etc)) bug Something isn't working labels Mar 13, 2024
@macfarla macfarla mentioned this issue Mar 14, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macfarla macfarla

Labels
bug Something isn't working P2 High (ex: Degrading performance issues, unexpected behavior of core features (DevP2P, syncing, etc)) RPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow empty maxFeePerBlobGas for eth_call macfarla/besu
2 participants
@macfarla @non-fungible-nelson