Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 4844 transaction fields to the CallParameter #6657

Closed
Gabriel-Trintinalia opened this issue Mar 1, 2024 · 2 comments
Closed

Add 4844 transaction fields to the CallParameter #6657

Gabriel-Trintinalia opened this issue Mar 1, 2024 · 2 comments
Assignees
@macfarla
Labels
4844 bug Something isn't working P2 High (ex: Degrading performance issues, unexpected behavior of core features (DevP2P, syncing, etc))

Comments

@Gabriel-Trintinalia
Copy link
Contributor

Gabriel-Trintinalia commented Mar 1, 2024 •
edited by macfarla
Loading

currently eth_call does not work for blob transactions.

Spec for eth_call params
https://github.com/ethereum/execution-apis/blob/main/src/schemas/transaction.yaml
@Gabriel-Trintinalia Gabriel-Trintinalia changed the title Add blobVersionedHashes and blobs to the CallParameter Add 4844 transaction fields to the CallParameter Mar 1, 2024
@macfarla macfarla added bug Something isn't working P2 High (ex: Degrading performance issues, unexpected behavior of core features (DevP2P, syncing, etc)) 4844 labels Mar 1, 2024
@macfarla macfarla self-assigned this Mar 1, 2024
@macfarla
Copy link
Contributor

macfarla commented Mar 1, 2024

Branch https://github.com/macfarla/besu/tree/eth-call-4844

This was referenced Mar 1, 2024
Merged
Closed
@macfarla
Copy link
Contributor

macfarla commented Mar 1, 2024 •
edited
Loading

ok have made draft PR on the release branch. TxSimulator unit tests are passing locally
TODO

  • not sure what to do with maxFeePerBlobGas in the transaction simulator
  • needs more tests

This was referenced Mar 4, 2024
Closed
Closed
@macfarla macfarla closed this as completed Mar 5, 2024
This was referenced Mar 7, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macfarla macfarla

Labels
4844 bug Something isn't working P2 High (ex: Degrading performance issues, unexpected behavior of core features (DevP2P, syncing, etc))
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macfarla @Gabriel-Trintinalia