Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clique createemptyblocks transition #6608

Merged
merged 22 commits into from
Mar 4, 2024

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Feb 23, 2024

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

Create genesis config transitions:

  "config": {
    ...
    "clique": {
      "blockperiodseconds": 3,
      "epochlength": 30,
      "requesttimeoutseconds": 6,
      "createemptyblocks": true
    },
    "transitions": {
      "clique": [
        {
          "block": 3,
          "createemptyblocks": false
        }
      ]
    }
  },

Fixed Issue(s)

Fixes #6290

jframe and others added 15 commits October 20, 2023 11:38
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
default createemptyblocks to true for transitions
Signed-off-by: Simon Dudley <[email protected]>
@siladu siladu changed the title clique block period transition Clique createemptyblocks transition Feb 26, 2024
@siladu siladu marked this pull request as ready for review February 26, 2024 07:36
Signed-off-by: Simon Dudley <[email protected]>
@siladu siladu added the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 26, 2024
@siladu siladu requested review from jframe and fab-10 February 26, 2024 08:07
@fab-10
Copy link
Contributor

fab-10 commented Feb 29, 2024

Please rebase

@siladu siladu merged commit dbc128f into hyperledger:main Mar 4, 2024
54 of 55 checks passed
@siladu siladu deleted the clique-transition-createemptyblocks branch March 4, 2024 21:12
@joaniefromtheblock joaniefromtheblock removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Mar 7, 2024
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Support clique transitions for createemptyblocks boolean

---------

Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Co-authored-by: Jason Frame <[email protected]>
Signed-off-by: amsmota <[email protected]>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Support clique transitions for createemptyblocks boolean

---------

Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Co-authored-by: Jason Frame <[email protected]>
Signed-off-by: amsmota <[email protected]>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
Support clique transitions for createemptyblocks boolean

---------

Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Co-authored-by: Jason Frame <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clique createemptyblock set to false, should allow to sync even if there are empty blocks
4 participants