Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Clique transitions #1583

Merged
merged 2 commits into from
May 2, 2024
Merged

Document Clique transitions #1583

merged 2 commits into from
May 2, 2024

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Apr 24, 2024 •
edited
Loading

Document Clique block period and empty blocks transitions. Also fix some formatting and link issues on the QBFT and IBFT transition sections.

Fixes #1528
Fixes #1531

Preview: https://besu-docs-f8rvwdpjq-hyperledger.vercel.app/development/private-networks/how-to/configure/consensus/clique#transitions

@alexandratran alexandratran requested a review from siladu April 24, 2024 21:25
@alexandratran alexandratran requested a review from a team as a code owner April 24, 2024 21:25
@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 5:57pm

@siladu
Copy link
Contributor

siladu commented Apr 30, 2024

Should hyperledger/besu#6608 be included in this PR too?

Might have been captured by this issue #1531
instead of #1528

@alexandratran alexandratran changed the title Document Clique block period transition Document Clique transitions Apr 30, 2024
@alexandratran alexandratran requested a review from siladu April 30, 2024 17:53
siladu
siladu approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joaniekube
joaniekube approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@joaniekube joaniekube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor question about numbering

@alexandratran alexandratran merged commit 38ddde3 into hyperledger:main May 2, 2024
9 checks passed
@alexandratran alexandratran deleted the 1528-clique-transitions branch May 2, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

@joaniekube joaniekube joaniekube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify createemptyblocks transition in Clique Document Clique transitions
3 participants
@alexandratran @siladu @joaniekube