Default storage format now Bonsai #6536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
|
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
macfarla
added
the
doc-change-required
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
|
What happens if you are not specifying the format before and after the upgrade to this version, is the previous Forest format recognized or there is an format mismatch error? |
Signed-off-by: Sally MacFarlane <[email protected]>
Good callout - Added to the description of the PR and the changelog |
Signed-off-by: Sally MacFarlane <[email protected]>
fab-10
reviewed
Feb 16, 2024
| params.addAll( | ||
| DataStorageOptions.fromConfig( | ||
| ImmutableDataStorageConfiguration.builder() | ||
| .from(DataStorageConfiguration.DEFAULT_FOREST_CONFIG) |
There was a problem hiding this comment.
should not be better to use BONSAI in tests since it is the default?
| @@ -201,6 +202,7 @@ public void startNode(final BesuNode node) { | |||
| .nodeKey(new NodeKey(new KeyPairSecurityModule(KeyPairUtil.loadKeyPair(dataDir)))) | |||
| .metricsSystem(metricsSystem) | |||
| .transactionPoolConfiguration(txPoolConfig) | |||
| .dataStorageConfiguration(DataStorageConfiguration.DEFAULT_FOREST_CONFIG) | |||
|
That's a fair comment on the tests @fab-10 - I'm not going to get that done today though - do you reckon that could be a separate PR? |
Yes. definitely it could be done in another PR |
fab-10
approved these changes
Feb 16, 2024
Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]>
suraneti
pushed a commit
to suraneti/besu
that referenced
this pull request
Feb 24, 2024
* default bonsai * be explicit about config in tests * default forest storage for fast sync tests * added upcoming breaking changes section * added db mismatch message Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>
alexandratran
removed
the
doc-change-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #6530
Change default storage format to BONSAI (was FOREST)
Note - if you had previously used FOREST, this is a breaking change - at startup you will get an error indicating the mismatch -
Mismatch: DB at '/your-path' is FOREST (Version 1) but config expects BONSAI (Version 2). Please check your config
Refs #5391