Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SNAP the default sync mode for named networks #6530

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Make SNAP the default sync mode for named networks #6530

merged 6 commits into from
Feb 16, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Feb 6, 2024 •
edited
Loading

SNAP sync is the default for named networks

refs #5391

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

@macfarla
changelog
fe4254a 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla mentioned this pull request Feb 7, 2024
Merged
@macfarla macfarla enabled auto-merge (squash) February 16, 2024 00:39
@macfarla macfarla merged commit 5bf959a into hyperledger:main Feb 16, 2024
50 checks passed
@macfarla macfarla added the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 18, 2024
@macfarla macfarla mentioned this pull request Feb 18, 2024
Merged
suraneti pushed a commit to suraneti/besu that referenced this pull request Feb 24, 2024
@macfarla @suraneti
Make SNAP the default sync mode for named networks (hyperledger#6530)
b1992e9 
* snap by default to replace fast

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla mentioned this pull request Feb 26, 2024
Closed
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 27, 2024
@macfarla macfarla deleted the snap-default branch July 16, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fab-10 fab-10 fab-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macfarla @fab-10 @alexandratran