[MINOR] ux improvements #6049

macfarla · 2023-10-18T05:27:36Z

log plugins summary at info (part of config overview)
include affected CLI option when there's a compatibility issue found by failIfOptionDoesntMeetRequirement

Signed-off-by: Sally MacFarlane <[email protected]>

github-actions · 2023-10-18T05:27:51Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

macfarla · 2023-10-18T07:05:27Z

the AT fail is because the plugins registration summary is logged before the Usage message. maybe this should change back to debug - @fab-10 thoughts?

fab-10

LGTM, just a non blocking nice to have, is to merge the plugin summary into the existing Besu summary log

fab-10 · 2023-10-18T09:46:10Z

the AT fail is because the plugins registration summary is logged before the Usage message. maybe this should change back to debug - @fab-10 thoughts?

I think this is another reason to try to move that log in the existing Besu summary log, that should be already logged at the right moment

macfarla · 2023-10-19T02:20:20Z

moved plugins summary to be part of besu config summary

# Total memory: 16.00 GB                                                                           #
# CPU cores: 10                                                                                    #
#                                                                                                  #
# Plugins:                                                                                         #
# ERROR LineaTransactionSelectorPlugin                                                             #
# RollupRpcEndpointServicePlugin                                                                   #
# TOTAL = 1 of 2 plugins successfully loaded                                                       #
# from /Users/sm/workspace/besu-local-nodes/./plugins                                 #
#                                                                                                  #
####################################################################################################

macfarla · 2023-10-19T02:48:19Z

in the case of zero plugins

# Total memory: 16.00 GB                                                                           #
# CPU cores: 10                                                                                    #
#                                                                                                  #
# Plugins:                                                                                         #
# TOTAL = 0 of 0  plugins successfully loaded                                                      #
# from /Users/sm/workspace/besu-local-nodes/./plugins                                 #
#                                                                                                  #
####################################################################################################

Signed-off-by: Sally MacFarlane <[email protected]>

* log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>

* log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>

* Expose getSize to transaction interface (#5983) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add parameters to EVM library fluent API (#5930) Add the ability to configure more parameters in the fluent API. Specifically contract address, coinbase, difficulty, mixHash/prevRandao, baseFee, block number, timestamp, gas limit, previous block hashes, and versioned hashes. Also create EVM forks parametrically instead of by a method name. Signed-off-by: Danno Ferrin <[email protected]> * Validation ordering (#5986) * re-ordering error reporting priority * fixes fork checking on getPayload * adds acceptance test reproducing an issue where built blocks have proofs > txs * test coverage and fix for subtle re-org bug prior to proposals --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [4844] EngineNewPayload - Add Blob Count validation (#5973) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (#5988) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Only use the builder to create transactions (#5980) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Bump version to 23.10.1-SNAPSHOT (#5990) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * hive tests explicitly attempt zero (#5993) Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add plugins summary (#5964) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Tests for GraphQL Cancun fields (#5975) * Tests for GraphQL Cancun fields Add tests for GraphQL fields added to support cancun. Also, re-work test case inclusion code and update tests impacted by adding a new block to the chain. Signed-off-by: Danno Ferrin <[email protected]> * unneeded deltas in genesis file Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (#5995) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Change Array Copying (#5998) * Change Array Copying Change array copying by re-using arrays when safe. Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> * different bigint API Signed-off-by: Danno Ferrin <[email protected]> * straddle case Signed-off-by: Danno Ferrin <[email protected]> * less stack traces Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (#6005) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Base EIP-6110 on top of Cancun (#5752) This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add method to disable root verification for T8n and not Reference tests (#6013) * add method to disable root verification for T8n and not Reference tests Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction detachedCopy to optimize txpool memory usage (#5985) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Use existing Bytes48 for KZGCommitment and KZGProof (#5997) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update 23.10.0 changelog (#6017) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction Validation and Selection Plugin API update (#6020) change Transaction Validation and Selection Plugin to make them more useful Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Force the use of jdk18 version of Bouncy Castle library (#5748) This avoid that any dependency can include the jdk15 version in the distribution. Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove code duplication (#6028) Signed-off-by: Stefan <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * docs: fix typo (#6029) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: vuittont60 <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Standardize pubkey and public key naming in deposit (#6012) --------- Signed-off-by: naviechan <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Optimize Eth_feeHistory RPC method (#6011) * Add a cache to EthFeeHistory and improve rewards algorithm * cache the rewards by hash instead of block number * Add final on some fields Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (#6009) * Add a flag --cache-last-blocks to cache last n blocks, The default value is 0 Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Sort only once rewardPercentiles instead of doing it for each block header (#6035) Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * link to issue 5772 (#6038) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * fix incorrect argument passing in blockParameter of TraceCallMany class (#6034) Signed-off-by: seongmin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix 23.10.0 Breaking Changes changelog entry (#6040) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Priority senders (#5959) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fcu v2 defer fork validation (#6037) * more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix typos (#6036) Signed-off-by: shuoer86 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add X (Twitter) to README, Fix Roadmap Hyperlink (#6047) * Add X to README, Fix Roadmap Hyperlink Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> --------- Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Unsigned timestamps and blob gas used (#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [MINOR] ux improvements (#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog release (#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Dencun corner cases (#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog and gradle properties to next release Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: seongmin <[email protected]> Signed-off-by: shuoer86 <[email protected]> Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: NC <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: seongmin <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: David Cardenas <[email protected]>

* log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>

* log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> (cherry picked from commit e8bca61)

* Expose getSize to transaction interface (hyperledger#5983) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add parameters to EVM library fluent API (hyperledger#5930) Add the ability to configure more parameters in the fluent API. Specifically contract address, coinbase, difficulty, mixHash/prevRandao, baseFee, block number, timestamp, gas limit, previous block hashes, and versioned hashes. Also create EVM forks parametrically instead of by a method name. Signed-off-by: Danno Ferrin <[email protected]> * Validation ordering (hyperledger#5986) * re-ordering error reporting priority * fixes fork checking on getPayload * adds acceptance test reproducing an issue where built blocks have proofs > txs * test coverage and fix for subtle re-org bug prior to proposals --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [4844] EngineNewPayload - Add Blob Count validation (hyperledger#5973) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (hyperledger#5988) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Only use the builder to create transactions (hyperledger#5980) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Bump version to 23.10.1-SNAPSHOT (hyperledger#5990) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * hive tests explicitly attempt zero (hyperledger#5993) Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add plugins summary (hyperledger#5964) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Tests for GraphQL Cancun fields (hyperledger#5975) * Tests for GraphQL Cancun fields Add tests for GraphQL fields added to support cancun. Also, re-work test case inclusion code and update tests impacted by adding a new block to the chain. Signed-off-by: Danno Ferrin <[email protected]> * unneeded deltas in genesis file Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (hyperledger#5995) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Change Array Copying (hyperledger#5998) * Change Array Copying Change array copying by re-using arrays when safe. Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> * different bigint API Signed-off-by: Danno Ferrin <[email protected]> * straddle case Signed-off-by: Danno Ferrin <[email protected]> * less stack traces Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (hyperledger#6005) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Base EIP-6110 on top of Cancun (hyperledger#5752) This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add method to disable root verification for T8n and not Reference tests (hyperledger#6013) * add method to disable root verification for T8n and not Reference tests Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction detachedCopy to optimize txpool memory usage (hyperledger#5985) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Use existing Bytes48 for KZGCommitment and KZGProof (hyperledger#5997) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (hyperledger#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update 23.10.0 changelog (hyperledger#6017) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction Validation and Selection Plugin API update (hyperledger#6020) change Transaction Validation and Selection Plugin to make them more useful Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Force the use of jdk18 version of Bouncy Castle library (hyperledger#5748) This avoid that any dependency can include the jdk15 version in the distribution. Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove code duplication (hyperledger#6028) Signed-off-by: Stefan <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * docs: fix typo (hyperledger#6029) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: vuittont60 <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Standardize pubkey and public key naming in deposit (hyperledger#6012) --------- Signed-off-by: naviechan <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Optimize Eth_feeHistory RPC method (hyperledger#6011) * Add a cache to EthFeeHistory and improve rewards algorithm * cache the rewards by hash instead of block number * Add final on some fields Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (hyperledger#6009) * Add a flag --cache-last-blocks to cache last n blocks, The default value is 0 Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Sort only once rewardPercentiles instead of doing it for each block header (hyperledger#6035) Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * link to issue 5772 (hyperledger#6038) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * fix incorrect argument passing in blockParameter of TraceCallMany class (hyperledger#6034) Signed-off-by: seongmin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix 23.10.0 Breaking Changes changelog entry (hyperledger#6040) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Priority senders (hyperledger#5959) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fcu v2 defer fork validation (hyperledger#6037) * more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix typos (hyperledger#6036) Signed-off-by: shuoer86 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add X (Twitter) to README, Fix Roadmap Hyperlink (hyperledger#6047) * Add X to README, Fix Roadmap Hyperlink Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> --------- Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Unsigned timestamps and blob gas used (hyperledger#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [MINOR] ux improvements (hyperledger#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog release (hyperledger#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Dencun corner cases (hyperledger#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog and gradle properties to next release Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: seongmin <[email protected]> Signed-off-by: shuoer86 <[email protected]> Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: NC <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: seongmin <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: David Cardenas <[email protected]> Signed-off-by: Justin Florentine <[email protected]>

* log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> (cherry picked from commit e8bca61) Signed-off-by: Justin Florentine <[email protected]>

* Unsigned timestamps and blob gas used (#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> (cherry picked from commit a90ea05) * [MINOR] ux improvements (#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> (cherry picked from commit e8bca61) * Update changelog release (#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> (cherry picked from commit f810887) * Dencun corner cases (#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> (cherry picked from commit 9d9fe8c) * add retry logic on sync pipeline for rocksdb issue (#6004) * add retry logic for sync pipeline with rocksdb issue Signed-off-by: Karim TAAM <[email protected]> (cherry picked from commit c839a3b) * Mining options refactor (#6027) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> (cherry picked from commit 20a82d4) * Update reference tests to Cancun (#6054) * Update reference tests to Cancun Update reference tests to cancun tests. Signed-off-by: Danno Ferrin <[email protected]> * update the subrepo Signed-off-by: Danno Ferrin <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> * update to develop Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> (cherry picked from commit 909649f) * Optimize GetPooledTransactionsFromPeerTask with HashSet (#6071) Switch from using a List to a HashSet for transaction hashes in GetPooledTransactionsFromPeerTask to improve performance. Signed-off-by: Suyash Nayan <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> (cherry picked from commit a2dbb82) * Decouple TrieLogManager and CachedWorldStorageManager (#6072) Separate out the concepts of world state caching and trie log management. Remove AbstractTrieLogManager and make TrieLogManager the concrete implementation. Signed-off-by: Simon Dudley <[email protected]> (cherry picked from commit 20f518e) * Implement miner_setMinPriorityFee and miner_getMinPriorityFee (#6080) * Refactor mining options Signed-off-by: Fabio Di Fabio <[email protected]> * Fix null pointer exception Signed-off-by: Fabio Di Fabio <[email protected]> * fix another null pointer exception Signed-off-by: Fabio Di Fabio <[email protected]> * uncomment code Signed-off-by: Fabio Di Fabio <[email protected]> * Move miner options tests Signed-off-by: Fabio Di Fabio <[email protected]> * Unit test fixes Signed-off-by: Fabio Di Fabio <[email protected]> * Removed the commented code Signed-off-by: Fabio Di Fabio <[email protected]> * WIP Signed-off-by: Fabio Di Fabio <[email protected]> * WIP Signed-off-by: Fabio Di Fabio <[email protected]> * New miner option: min-priority-fee Signed-off-by: Fabio Di Fabio <[email protected]> * Remove not relevant for this feature Signed-off-by: Fabio Di Fabio <[email protected]> * Remove not relevant for this feature Signed-off-by: Fabio Di Fabio <[email protected]> * Fix javadoc Signed-off-by: Fabio Di Fabio <[email protected]> * Remove code not belonging to this PR Signed-off-by: Fabio Di Fabio <[email protected]> * coinbase is an updatable parameter Signed-off-by: Fabio Di Fabio <[email protected]> * Move MiningOptions to upper package Signed-off-by: Fabio Di Fabio <[email protected]> * Fix coinbase for *bft Signed-off-by: Fabio Di Fabio <[email protected]> * Implement methods to get and set min priority fee Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix spotless Signed-off-by: Gabriel-Trintinalia <[email protected]> * Apply suggestions from code review Signed-off-by: Fabio Di Fabio <[email protected]> * Update besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java [skip-ci] Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> * Add new config option to everything config Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix unit test Signed-off-by: Gabriel-Trintinalia <[email protected]> * Accept PR suggestions Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> (cherry picked from commit 3310c41) * Use Bytes Trie to track warm addresses (#6069) * Use Bytes Trie to track warm addresses Move from a java HashSet to a custom Trie based on bytes to store the warm addresses, creates, and self-destructs. This avoids needing to calculate java hashes or engage in using custom Comparators. Signed-off-by: Danno Ferrin <[email protected]> * codeql scan Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> (cherry picked from commit af011d2) * Migrate Operand Stack to Growing Stack (#6068) To improve the performance of CALL operations move the OperandStack and ReturnStack to growing stacks instead of a fully allocated stack. Signed-off-by: Danno Ferrin <[email protected]> (cherry picked from commit 949c724) * Remove a BonsaiWorldStateProvider constructor (#6090) Was only used for supporting test code and can instead reuse static factory from InMemoryKeyValueStorageProvider Signed-off-by: Simon Dudley <[email protected]> (cherry picked from commit 9a22703) * add RpcEndpointService to thread runner (#6091) Signed-off-by: Sally MacFarlane <[email protected]> (cherry picked from commit 7ac8af0) * ETC 'Spiral' network upgrade (#6078) * Add 23.10.2 section to changelog Signed-off-by: Diego López León <[email protected]> * Set ENR tree for DNS discovery for Mordor network Signed-off-by: Diego López León <[email protected]> * Add ECIP-1109: 'Spiral' network upgrade support Signed-off-by: Diego López León <[email protected]> --------- Signed-off-by: Diego López León <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> (cherry picked from commit f58f6cf) * Trigger contextEnter/Exit for all frames, including root (#6074) * Trigger contextEnter/Exit for all frames, including root * Differentiate between context entry and re-entry in `OperationTracer` * Update evm/src/test/java/org/hyperledger/besu/evm/processor/AbstractMessageProcessorTest.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: delehef <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: delehef <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> (cherry picked from commit 0345b24) * feat: add a way to read memory without altering the word capacity (#6073) * feat: add a way to read memory without altering the word capacity * add tests Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: Franklin Delehelle <[email protected]> * Fix read-past-end * Do not abuse method overload * Update CHANGELOG.md Signed-off-by: delehef <[email protected]> Signed-off-by: Franklin Delehelle <[email protected]> * add tests for MessageFrame.shadowReadMemory Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: Franklin Delehelle <[email protected]> * Straddled reads tests Signed-off-by: Franklin Delehelle <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: delehef <[email protected]> Signed-off-by: delehef <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> (cherry picked from commit edf23cb) * renamed env field (#6096) Signed-off-by: Justin Florentine <[email protected]> (cherry picked from commit 67ef9e0) * [MINOR] Upgrade netty and grpc (#6100) * Upgrade netty and grpc * fix verification file Signed-off-by: Simon Dudley <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> (cherry picked from commit accac1c) * TraceService: return results for transactions in block (#6087) * TraceService: return results for transactions in block Signed-off-by: Daniel Lehrner <[email protected]> (cherry picked from commit a60b31b) * RPC Parameters to accept input and data field (#6094) * Accept input or data as payload for RPC calls Signed-off-by: Gabriel Fukushima <[email protected]> * Add json new rpc valid and invalid request to test the changes Signed-off-by: Gabriel Fukushima <[email protected]> * Change JsonCallParameter signature to avoid duplicating constructor Signed-off-by: Gabriel Fukushima <[email protected]> * Add changelog Signed-off-by: Gabriel Fukushima <[email protected]> --------- Signed-off-by: Gabriel Fukushima <[email protected]> (cherry picked from commit 6dd558b) * Fix some typos (#6093) * Fix some typos * Update plugin version Signed-off-by: GoodDaisy <[email protected]> --------- Signed-off-by: GoodDaisy <[email protected]> (cherry picked from commit e814886) * Correct reference test blobgas calculation (#6107) * Correct reference test blobgas calculation Fix tpyo that resulted in an NPE in t8n blob gas calculations. Signed-off-by: Danno Ferrin <[email protected]> * changelog Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> (cherry picked from commit d0a6a70) * Restore javadoc and sources jar as trusted artifacts (#6109) Makes Idea happy again as documented here https://docs.gradle.org/6.8.3/userguide/dependency_verification.html#sec:skipping-javadocs Signed-off-by: Fabio Di Fabio <[email protected]> (cherry picked from commit 311570f) * Add API to set and get the minGasPrice at runtime (#6097) Signed-off-by: Fabio Di Fabio <[email protected]> (cherry picked from commit de8ca10) * Don't put NONCE_TOO_LOW transactions into the invalid nonce cache (#6067) * Don't put NONCE_TOO_LOW transactions into the invalid nonce cache Signed-off-by: Matthew Whitehead <[email protected]> * Update unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Use list of errors to ignore Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> (cherry picked from commit 84dee29) * Journaled world state (#6023) Introduce a new Journaled World State Updater. Within a transaction it keeps one copy of account and storage state, restoring previous revisions on reverts and exceptional halts. This updater only supports post-merge semantics with regard to empty accounts, namely that they do not exist in world state. Adds an EvmConfiguration option for stacked vs journaled updater, and wire it in where needed. The staked updater is default mode, which is the current behavior prior to this patch. Signed-off-by: Danno Ferrin <[email protected]> (cherry picked from commit 094c841) * setMinPriorityFee - Return Invalid Param when invalid and use hexadecimal instead of Long (#6099) Signed-off-by: Gabriel-Trintinalia <[email protected]> (cherry picked from commit 7acdd87) * [MINOR] - Add 23.10.1 correct changelog (#6110) Signed-off-by: Gabriel-Trintinalia <[email protected]> (cherry picked from commit 236779d) * Add transaction selector based on min priority fee parameter (#6083) Signed-off-by: Gabriel-Trintinalia <[email protected]> (cherry picked from commit 41b9575) * Add config option to clique to allow not creating empty blocks (#6082) Signed-off-by: Jason Frame <[email protected]> (cherry picked from commit 6a2d41f) * load all accounts into cache (#6101) There was a slight problem on the bonsai side because all account reads did not go through a single method. One of the two add the account to the cache but the other did not. This had two consequences: Less good performance because certain accounts had to be read several times and also all account reads were not marked in the trielog. This will fix both problems. Signed-off-by: Karim TAAM <[email protected]> (cherry picked from commit d049cb3) * Reference Tests v13 (#6114) v13 of the official Ethereum Reference Tests. Signed-off-by: Danno Ferrin <[email protected]> (cherry picked from commit cea3d8a) * clean up the ProcessableBlockHeader (#6117) * clean up Signed-off-by: [email protected] <[email protected]> (cherry picked from commit 646c5a3) * Log missing chain head as warning, not trace (#6127) Signed-off-by: Matthew Whitehead <[email protected]> (cherry picked from commit 83ae69a) * Update RPCs for yParity (#6119) Update the GraphQL and JSON-RPC endpoints to provide `yParity` instead of `v` for non-legacy transactions. Update the JSON-RPC tests to use the Hive data. Add tests for Shanghai and Cancun Blocks. Signed-off-by: Danno Ferrin <[email protected]> (cherry picked from commit 2284242) * Make tracer in block building block aware (#6135) Signed-off-by: [email protected] <[email protected]> (cherry picked from commit f42f8c1) * Revert "Discard invalid transaction" warning logs (#6137) * Revert "Log missing chain head as warning, not trace (#6127)" * leave chain head at warning, just revert the discard warning Signed-off-by: garyschulte <[email protected]> (cherry picked from commit 914ab79) * Reverse sort order (#6106) * Reverse added order and sequence number Signed-off-by: Matthew Whitehead <[email protected]> * Remove extraneous 'addedAt' check Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> (cherry picked from commit 0203092) * Force tx replacement price bump to zero when zero base fee market is configured (#6079) Signed-off-by: Fabio Di Fabio <[email protected]> (cherry picked from commit 636ad8a) * Time limited block creation (#6044) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> (cherry picked from commit 8319fae) * Limit memory used in handling invalid blocks (#6138) Signed-off-by: Jason Frame <[email protected]> (cherry picked from commit 701cbb0) * Delete leftPad when capturing the stack before and after a frame execution (#6102) * Delete leftPad when capturing the stack before and after the execution * Still use leftPad when displaying the stack in the output (ex. for debug_traceTransaction) * Fix integration test * Use StringBuilder to left pad the hex representation of a 32 bytes Signed-off-by: Ameziane H <[email protected]> (cherry picked from commit 9710a9a) * fix yParity flakey test (#6151) Fix the flakeiness in EthGetTransactionByHashTest as well as some other sonar identified cleanup. Signed-off-by: Danno Ferrin <[email protected]> (cherry picked from commit 4b58d07) * Apply the same reverse sort order as https://github.com/hyperledger/b… (#6146) * Apply the same reverse sort order as #6106 but to the base fee sorter Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Update eviction unit tests to expect highest-sequence TXs be evicted first Signed-off-by: Matthew Whitehead <[email protected]> * Update change log Signed-off-by: Matthew Whitehead <[email protected]> * Spotless fixes Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> (cherry picked from commit 8afad41) --------- Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Suyash Nayan <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Diego López León <[email protected]> Co-authored-by: delehef <[email protected]> Co-authored-by: daniellehrner <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Co-authored-by: GoodDaisy <[email protected]> Co-authored-by: Matt Whitehead <[email protected]> Co-authored-by: Jason Frame <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: garyschulte <[email protected]> Co-authored-by: ahamlat <[email protected]>

* log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>

macfarla added 5 commits October 18, 2023 11:30

log at info

af14c84

Signed-off-by: Sally MacFarlane <[email protected]>

typo

cbe19cb

Signed-off-by: Sally MacFarlane <[email protected]>

log command line option that is affected

db5c65f

Signed-off-by: Sally MacFarlane <[email protected]>

Merge branch 'main' of github.com:hyperledger/besu into plugins-ux

027afff

Merge branch 'main' of github.com:hyperledger/besu into plugins-ux

0542fdb

macfarla enabled auto-merge (squash) October 18, 2023 05:28

macfarla disabled auto-merge October 18, 2023 07:04

macfarla requested a review from fab-10 October 18, 2023 07:05

fab-10 approved these changes Oct 18, 2023

View reviewed changes

macfarla added 3 commits October 19, 2023 12:49

made plugins summary log part of config overview

77cbec7

Signed-off-by: Sally MacFarlane <[email protected]>

Merge branch 'main' of github.com:hyperledger/besu into plugins-ux

d2c96d8

debug lvl for one remaining msg

4c43d53

Signed-off-by: Sally MacFarlane <[email protected]>

Gabriel-Trintinalia approved these changes Oct 19, 2023

View reviewed changes

macfarla added 2 commits October 19, 2023 13:17

javadoc

cddf542

Signed-off-by: Sally MacFarlane <[email protected]>

formatting

ccef082

Signed-off-by: Sally MacFarlane <[email protected]>

macfarla enabled auto-merge (squash) October 19, 2023 03:18

macfarla disabled auto-merge October 19, 2023 03:33

check for null plugin context

d2943ba

Signed-off-by: Sally MacFarlane <[email protected]>

macfarla enabled auto-merge (squash) October 19, 2023 05:08

macfarla merged commit e8bca61 into hyperledger:main Oct 19, 2023
19 checks passed

macfarla deleted the plugins-ux branch October 19, 2023 23:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MINOR] ux improvements #6049

[MINOR] ux improvements #6049

macfarla commented Oct 18, 2023 •

edited

Loading

github-actions bot commented Oct 18, 2023

macfarla commented Oct 18, 2023

fab-10 left a comment

fab-10 commented Oct 18, 2023

macfarla commented Oct 19, 2023 •

edited

Loading

macfarla commented Oct 19, 2023

[MINOR] ux improvements #6049

[MINOR] ux improvements #6049

Conversation

macfarla commented Oct 18, 2023 • edited Loading

github-actions bot commented Oct 18, 2023

macfarla commented Oct 18, 2023

fab-10 left a comment

Choose a reason for hiding this comment

fab-10 commented Oct 18, 2023

macfarla commented Oct 19, 2023 • edited Loading

macfarla commented Oct 19, 2023

macfarla commented Oct 18, 2023 •

edited

Loading

macfarla commented Oct 19, 2023 •

edited

Loading