[Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted Signed-off-by: Gabriel-Trintinalia <[email protected]>
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...-api/src/main/java/org/hyperledger/besu/plugin/services/txselection/TransactionSelector.java
Fixed
Show fixed
Hide fixed
...-api/src/main/java/org/hyperledger/besu/plugin/services/txselection/TransactionSelector.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Gabriel-Trintinalia <[email protected]>
| */ | ||
| default void onTransactionRejected(final PendingTransaction pendingTransaction) {} | ||
| default void onTransactionNotSelected( | ||
| final PendingTransaction pendingTransaction, |
Check notice
Code scanning / CodeQL
Useless parameter Note
| default void onTransactionRejected(final PendingTransaction pendingTransaction) {} | ||
| default void onTransactionNotSelected( | ||
| final PendingTransaction pendingTransaction, | ||
| final TransactionSelectionResult transactionSelectionResult) {} |
Check notice
Code scanning / CodeQL
Useless parameter Note
Gabriel-Trintinalia
changed the title
Gabriel-Trintinalia
changed the title
fab-10
approved these changes
Oct 10, 2023
Gabriel-Trintinalia
added a commit
to Gabriel-Trintinalia/besu
that referenced
this pull request
Oct 20, 2023
…to the plugin when not transaction is not selected (hyperledger#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]>
Gabriel-Trintinalia
added a commit
to Gabriel-Trintinalia/besu
that referenced
this pull request
Oct 20, 2023
…to the plugin when not transaction is not selected (hyperledger#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]>
Gabriel-Trintinalia
added a commit
that referenced
this pull request
Oct 20, 2023
* Expose getSize to transaction interface (#5983) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add parameters to EVM library fluent API (#5930) Add the ability to configure more parameters in the fluent API. Specifically contract address, coinbase, difficulty, mixHash/prevRandao, baseFee, block number, timestamp, gas limit, previous block hashes, and versioned hashes. Also create EVM forks parametrically instead of by a method name. Signed-off-by: Danno Ferrin <[email protected]> * Validation ordering (#5986) * re-ordering error reporting priority * fixes fork checking on getPayload * adds acceptance test reproducing an issue where built blocks have proofs > txs * test coverage and fix for subtle re-org bug prior to proposals --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [4844] EngineNewPayload - Add Blob Count validation (#5973) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (#5988) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Only use the builder to create transactions (#5980) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Bump version to 23.10.1-SNAPSHOT (#5990) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * hive tests explicitly attempt zero (#5993) Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add plugins summary (#5964) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Tests for GraphQL Cancun fields (#5975) * Tests for GraphQL Cancun fields Add tests for GraphQL fields added to support cancun. Also, re-work test case inclusion code and update tests impacted by adding a new block to the chain. Signed-off-by: Danno Ferrin <[email protected]> * unneeded deltas in genesis file Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (#5995) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Change Array Copying (#5998) * Change Array Copying Change array copying by re-using arrays when safe. Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> * different bigint API Signed-off-by: Danno Ferrin <[email protected]> * straddle case Signed-off-by: Danno Ferrin <[email protected]> * less stack traces Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (#6005) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Base EIP-6110 on top of Cancun (#5752) This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add method to disable root verification for T8n and not Reference tests (#6013) * add method to disable root verification for T8n and not Reference tests Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction detachedCopy to optimize txpool memory usage (#5985) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Use existing Bytes48 for KZGCommitment and KZGProof (#5997) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update 23.10.0 changelog (#6017) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction Validation and Selection Plugin API update (#6020) change Transaction Validation and Selection Plugin to make them more useful Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Force the use of jdk18 version of Bouncy Castle library (#5748) This avoid that any dependency can include the jdk15 version in the distribution. Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove code duplication (#6028) Signed-off-by: Stefan <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * docs: fix typo (#6029) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: vuittont60 <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Standardize pubkey and public key naming in deposit (#6012) --------- Signed-off-by: naviechan <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Optimize Eth_feeHistory RPC method (#6011) * Add a cache to EthFeeHistory and improve rewards algorithm * cache the rewards by hash instead of block number * Add final on some fields Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (#6009) * Add a flag --cache-last-blocks to cache last n blocks, The default value is 0 Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Sort only once rewardPercentiles instead of doing it for each block header (#6035) Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * link to issue 5772 (#6038) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * fix incorrect argument passing in blockParameter of TraceCallMany class (#6034) Signed-off-by: seongmin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix 23.10.0 Breaking Changes changelog entry (#6040) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Priority senders (#5959) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fcu v2 defer fork validation (#6037) * more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix typos (#6036) Signed-off-by: shuoer86 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add X (Twitter) to README, Fix Roadmap Hyperlink (#6047) * Add X to README, Fix Roadmap Hyperlink Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> --------- Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Unsigned timestamps and blob gas used (#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [MINOR] ux improvements (#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog release (#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Dencun corner cases (#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog and gradle properties to next release Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: seongmin <[email protected]> Signed-off-by: shuoer86 <[email protected]> Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: NC <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: seongmin <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: David Cardenas <[email protected]>
jflo
added a commit
to jflo/besu
that referenced
this pull request
Nov 10, 2023
* Expose getSize to transaction interface (hyperledger#5983) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add parameters to EVM library fluent API (hyperledger#5930) Add the ability to configure more parameters in the fluent API. Specifically contract address, coinbase, difficulty, mixHash/prevRandao, baseFee, block number, timestamp, gas limit, previous block hashes, and versioned hashes. Also create EVM forks parametrically instead of by a method name. Signed-off-by: Danno Ferrin <[email protected]> * Validation ordering (hyperledger#5986) * re-ordering error reporting priority * fixes fork checking on getPayload * adds acceptance test reproducing an issue where built blocks have proofs > txs * test coverage and fix for subtle re-org bug prior to proposals --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [4844] EngineNewPayload - Add Blob Count validation (hyperledger#5973) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (hyperledger#5988) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Only use the builder to create transactions (hyperledger#5980) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Bump version to 23.10.1-SNAPSHOT (hyperledger#5990) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * hive tests explicitly attempt zero (hyperledger#5993) Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add plugins summary (hyperledger#5964) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Tests for GraphQL Cancun fields (hyperledger#5975) * Tests for GraphQL Cancun fields Add tests for GraphQL fields added to support cancun. Also, re-work test case inclusion code and update tests impacted by adding a new block to the chain. Signed-off-by: Danno Ferrin <[email protected]> * unneeded deltas in genesis file Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (hyperledger#5995) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Change Array Copying (hyperledger#5998) * Change Array Copying Change array copying by re-using arrays when safe. Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> * different bigint API Signed-off-by: Danno Ferrin <[email protected]> * straddle case Signed-off-by: Danno Ferrin <[email protected]> * less stack traces Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (hyperledger#6005) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Base EIP-6110 on top of Cancun (hyperledger#5752) This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add method to disable root verification for T8n and not Reference tests (hyperledger#6013) * add method to disable root verification for T8n and not Reference tests Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction detachedCopy to optimize txpool memory usage (hyperledger#5985) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Use existing Bytes48 for KZGCommitment and KZGProof (hyperledger#5997) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (hyperledger#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update 23.10.0 changelog (hyperledger#6017) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction Validation and Selection Plugin API update (hyperledger#6020) change Transaction Validation and Selection Plugin to make them more useful Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Force the use of jdk18 version of Bouncy Castle library (hyperledger#5748) This avoid that any dependency can include the jdk15 version in the distribution. Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove code duplication (hyperledger#6028) Signed-off-by: Stefan <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * docs: fix typo (hyperledger#6029) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: vuittont60 <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Standardize pubkey and public key naming in deposit (hyperledger#6012) --------- Signed-off-by: naviechan <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Optimize Eth_feeHistory RPC method (hyperledger#6011) * Add a cache to EthFeeHistory and improve rewards algorithm * cache the rewards by hash instead of block number * Add final on some fields Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (hyperledger#6009) * Add a flag --cache-last-blocks to cache last n blocks, The default value is 0 Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Sort only once rewardPercentiles instead of doing it for each block header (hyperledger#6035) Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * link to issue 5772 (hyperledger#6038) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * fix incorrect argument passing in blockParameter of TraceCallMany class (hyperledger#6034) Signed-off-by: seongmin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix 23.10.0 Breaking Changes changelog entry (hyperledger#6040) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Priority senders (hyperledger#5959) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fcu v2 defer fork validation (hyperledger#6037) * more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix typos (hyperledger#6036) Signed-off-by: shuoer86 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add X (Twitter) to README, Fix Roadmap Hyperlink (hyperledger#6047) * Add X to README, Fix Roadmap Hyperlink Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> --------- Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Unsigned timestamps and blob gas used (hyperledger#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [MINOR] ux improvements (hyperledger#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog release (hyperledger#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Dencun corner cases (hyperledger#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog and gradle properties to next release Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: seongmin <[email protected]> Signed-off-by: shuoer86 <[email protected]> Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: NC <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: seongmin <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: David Cardenas <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
…to the plugin when not transaction is not selected (hyperledger#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds the
TransactionSelectionResulttoTransactionSelector.onTransactionNotSelectedso that plugins have more context.Addresses the comment in this PR #6005 (comment)