Update holesky with fixed extraData, genesis time, shanghaiTime #5890

siladu · 2023-09-18T21:44:43Z

Incorporates eth-clients/holesky#73
and also @fab-10's changes from eth-clients/holesky#72

Signed-off-by: Simon Dudley <[email protected]>

github-actions · 2023-09-18T21:44:57Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Signed-off-by: Simon Dudley <[email protected]>

gfukushima

LGTM, double-checked against the expected block hash and it matches:
0xb5f7f912443c940f21fd611f12828d75b534364ed9e95ca4e307729a4661bde4

I'm going to wait until eth-clients/holesky#73 gets merged to approve this.

garyschulte

It looks like the missing brace would have parsed the remaining accounts as storage fields? I presume this was possible because of a json parsing policy that ignores missing fields, otherwise we should have thrown when "balance":xx wasn't part of the json schema for storage fields.

can we add stricter json parsing for storage fields and/or test coverage?

siladu · 2023-09-19T00:58:48Z

@fab-10 I have some doubt about the removal of cancunTime (which is currently breaking the tests).

Eth-clients genesis didn't have it but geth did: https://github.com/ethereum/go-ethereum/blob/90d5bd85bcf2919ac2735a47fde675213348a0a6/params/config.go#L84

Nethermind didn't: https://github.com/NethermindEth/nethermind/blob/8ce10d324c05a44dc1fb9e07e6b8618350addac9/src/Nethermind/Nethermind.Specs/HoleskySpecProvider.cs#L15

I think it's probably fine either way...just not 100% sure if "fork next" having a different value affects peering

After changing shanghaiTime and removing cancunTime Signed-off-by: Simon Dudley <[email protected]>

siladu · 2023-09-19T01:27:00Z

besu/src/test/java/org/hyperledger/besu/ForkIdsNetworkConfigTest.java

-                new ForkId(Bytes.ofUnsignedInt(0x840a3b53L), 2000000000L),
-                new ForkId(Bytes.ofUnsignedInt(0x30771f90), 0L),
-                new ForkId(Bytes.ofUnsignedInt(0x30771f90), 0L))
+                new ForkId(Bytes.ofUnsignedInt(0xc61a6098L), 1696000704L),


Couldn't find a reference for the ForkId hash, would be good to cross reference with other clients once they've made the changes

fab-10 · 2023-09-19T05:04:29Z

@fab-10 I have some doubt about the removal of cancunTime (which is currently breaking the tests).

Eth-clients genesis didn't have it but geth did: https://github.com/ethereum/go-ethereum/blob/90d5bd85bcf2919ac2735a47fde675213348a0a6/params/config.go#L84

Nethermind didn't: https://github.com/NethermindEth/nethermind/blob/8ce10d324c05a44dc1fb9e07e6b8618350addac9/src/Nethermind/Nethermind.Specs/HoleskySpecProvider.cs#L15

I think it's probably fine either way...just not 100% sure if "fork next" having a different value affects peering

Ok, now I remember why I added it in the first place, so should I readd it or have you found a way to fix the tests?

siladu · 2023-09-19T06:01:00Z

Ok, now I remember why I added it in the first place, so should I readd it or have you found a way to fix the tests?

@fab-10 I fixed the tests and confirmed with Stefan that a future cancunTime shouldn't affect peering so think we're good.
Would still like to confirm with other EL clients if the forkId is the expected value before we re-launch

Signed-off-by: Simon Dudley <[email protected]>

jframe · 2023-09-19T21:53:56Z

It looks like the missing brace would have parsed the remaining accounts as storage fields? I presume this was possible because of a json parsing policy that ignores missing fields, otherwise we should have thrown when "balance":xx wasn't part of the json schema for storage fields.

can we add stricter json parsing for storage fields and/or test coverage?

Definitely a good idea to do that. Happy for that to be in another PR to not hold up the release for the Holesky relaunch. Even better would be to be compatible with the same genesis config that other clients use.

macfarla · 2023-09-19T22:13:13Z

Created this issue for tightening up the parsing #5900

jframe · 2023-09-19T22:18:02Z

config/src/main/resources/holesky.json

+      "balance": "0xd3c21bcecceda1000000"
+    },
+    "0x4BC656B34De23896fa6069C9862F355b740401aF": {
+      "balance": "0x084595161401484a000000"
    }
  },
  "coinbase": "0x0000000000000000000000000000000000000000",
  "baseFeePerGas": "0x3B9ACA00",


Why does the Besu config need baseFeePerGas but the default genesis.json doesn't?

Just double checked and we technically don't because it is the default initial value: https://github.com/hyperledger/besu/blob/main/config/src/main/java/org/hyperledger/besu/config/GenesisConfigFile.java#L43 so we still get same genesis block when it loads.

However, if we change it in this PR then we will no longer exactly match https://github.com/eth-clients/holesky/blob/main/custom_config_data/besu.json if anyone cares about that.

I actually prefer it being in, more explicit, since it is actually part of the genesis block.

garyschulte

🚢 LGTM. AFAIK, next fork shouldn't present a peering problem until we 'get there'

--- Drop Kotti Network support (ETC) (hyperledger#5816) Signed-off-by: Diego López León <[email protected]> fix ForkId if there are no Forks and the starting timestamp is not 0 (hyperledger#5819) Signed-off-by: Stefan <[email protected]> enforce that BlobTransactions have at least one blob (hyperledger#5826) * enforce that BlobTransactions have at least one blob Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Do not create ignorable segments on `revert storage-variables` (hyperledger#5830) * fix the bug that creates the ignorable chain pruner segment, add rocks exception parsing to RocksDBColumnarKeyValueStorage subclasses * parse rocksdb error for unprintable column family id's Signed-off-by: garyschulte <[email protected]> add versioned hashes and number of blobs to toString() (hyperledger#5831) Signed-off-by: Stefan <[email protected]> add parent beacon block root to payload id calculation (hyperledger#5843) Signed-off-by: Stefan <[email protected]> bump version to 23.7.3-SNAPSHOT (hyperledger#5854) Signed-off-by: Daniel Lehrner <[email protected]> set the beacon root address to the correct value (hyperledger#5853) Signed-off-by: Stefan <[email protected]> docs(readme): fix broken link to installation of binaries page (hyperledger#5859) Fixes hyperledger#5858 Signed-off-by: Peter Somogyvari <[email protected]> Update RocksDB version from 8.0.0 to 8.3.2 (hyperledger#5832) Signed-off-by: Ameziane H <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> use non-deprecated authenticate methods (hyperledger#5852) Signed-off-by: Sally MacFarlane <[email protected]> move to Hyperledger shared runners for current github actions (hyperledger#5860) Signed-off-by: garyschulte <[email protected]> Add range tracing with worldstate (hyperledger#5844) Implement a method to trace a range of blocks and have access to the worldstate before and after the tracing Signed-off-by: Karim TAAM <[email protected]> Layered txpool by default and txpool options hoverhaul (hyperledger#5772) Signed-off-by: Fabio Di Fabio <[email protected]> Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions (hyperledger#5857) Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions Signed-off-by: Ameziane H <[email protected]> updated gradle verification metadata (hyperledger#5870) * removed old artefacts [skip ci] * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> [4844] Add encodingContext to TransactionEncoder and TransactionDecoder (hyperledger#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Stefan <[email protected]> payload attributes: fix wrong warning and fail if beacon root is available before cancun (hyperledger#5872) Signed-off-by: Stefan <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Merge MutableAccount and EVMAccount (hyperledger#5863) Merge MutableAccount and EVMAccount functionalities by removing EVMAccount, all calls to getMutable, and the WrappedEVMAccount that was wrapping non-EVMAccounts in a mutable fashion. Instead, use a MutableAccount in all cases an EVMAccount would have been used. This also tends to reduce a level of layering in many places. Signed-off-by: Danno Ferrin <[email protected]> Add world context to transaction tracing API (hyperledger#5836) * Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <[email protected]> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <[email protected]> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <[email protected]> * Rebase on main Signed-off-by: Franklin Delehelle <[email protected]> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <[email protected]> * added test Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Bonsai based reference test worldstate (hyperledger#5686) * create a bonsai based reference test worldstate -> getOrCreate in BonsaiWorldStateUpdateAccumulator - do not throw if we discover an empty account in a non-null BonsaiValue<Account> -> add curentStateRoot to t8n -> storageEntriesFrom and streamAccounts implemented in BonsaiWorldStateKeyValueStorage -> add endKey version of streamFromKey * bonsai fix for self-destruct and create2 at the same address and same block Signed-off-by: garyschulte <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Karim TAAM <[email protected]> Don't start BFT mining coordinators until initial sync has completed (hyperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> display only peers ready for requets on ethstats (hyperledger#5880) * display only ready for requets peers in ethstats Signed-off-by: Karim TAAM <[email protected]> * cast to int Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> [MINOR] test RLP used for encode/decode blob tx should contain to field (hyperledger#5883) * validate to field on encode/decode for blob tx Signed-off-by: Sally MacFarlane <[email protected]> * revert decode/encode checks - tis done later in tx validation Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Fix: correctly convert percentage options in TOML configuration file (hyperledger#5886) Signed-off-by: Fabio Di Fabio <[email protected]> EIP7516 - Add BlobBaseFee opcode to Cancun EVM (hyperledger#5884) Signed-off-by: Gabriel-Trintinalia <[email protected]> Fix snapsync heal (hyperledger#5838) Signed-off-by: Karim TAAM <[email protected]> Upgrade besu-native (hyperledger#5893) Upgrade besu-native to 0.8.2 Signed-off-by: Danno Ferrin <[email protected]> Tune G1GC to reduce Besu memory footprint (hyperledger#5879) Signed-off-by: Fabio Di Fabio <[email protected]> Add updated storage to evmtool json trace (hyperledger#5892) Add the EIP-3155 "storage" option to the standard tracer, with the caveat only updated storage is logged. Signed-off-by: Danno Ferrin <[email protected]> Update holesky with fixed extraData, genesis time, shanghaiTime (hyperledger#5890) Signed-off-by: Simon Dudley <[email protected]> [CHANGELOG] removed duplicated line (hyperledger#5904) * removed duplicated line [skip ci] Signed-off-by: Sally MacFarlane <[email protected]> * fixed spelling on Holesky Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: garyschulte <[email protected]>

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

burn-in candidate for 23.7.3 from main sha 6dc10a9..eef40bd https://github.com/hyperledger/besu/compare/6dc10a9..eef40bd --- * Drop Kotti Network support (ETC) (#5816) Signed-off-by: Diego López León <[email protected]> Signed-off-by: garyschulte <[email protected]> * fix ForkId if there are no Forks and the starting timestamp is not 0 (#5819) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * enforce that BlobTransactions have at least one blob (#5826) * enforce that BlobTransactions have at least one blob Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: garyschulte <[email protected]> * Do not create ignorable segments on `revert storage-variables` (#5830) * fix the bug that creates the ignorable chain pruner segment, add rocks exception parsing to RocksDBColumnarKeyValueStorage subclasses * parse rocksdb error for unprintable column family id's Signed-off-by: garyschulte <[email protected]> * add versioned hashes and number of blobs to toString() (#5831) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * add parent beacon block root to payload id calculation (#5843) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * bump version to 23.7.3-SNAPSHOT (#5854) Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: garyschulte <[email protected]> * set the beacon root address to the correct value (#5853) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * docs(readme): fix broken link to installation of binaries page (#5859) Fixes #5858 Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: garyschulte <[email protected]> * Update RocksDB version from 8.0.0 to 8.3.2 (#5832) Signed-off-by: Ameziane H <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * use non-deprecated authenticate methods (#5852) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * move to Hyperledger shared runners for current github actions (#5860) Signed-off-by: garyschulte <[email protected]> * Add range tracing with worldstate (#5844) Implement a method to trace a range of blocks and have access to the worldstate before and after the tracing Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: garyschulte <[email protected]> * Layered txpool by default and txpool options hoverhaul (#5772) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: garyschulte <[email protected]> * Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions (#5857) Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions Signed-off-by: Ameziane H <[email protected]> Signed-off-by: garyschulte <[email protected]> * updated gradle verification metadata (#5870) * removed old artefacts [skip ci] * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * [4844] Add encodingContext to TransactionEncoder and TransactionDecoder (#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * #5868: fix beacon root address and modulus for devnet 9 (#5871) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * payload attributes: fix wrong warning and fail if beacon root is available before cancun (#5872) Signed-off-by: Stefan <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * Merge MutableAccount and EVMAccount (#5863) Merge MutableAccount and EVMAccount functionalities by removing EVMAccount, all calls to getMutable, and the WrappedEVMAccount that was wrapping non-EVMAccounts in a mutable fashion. Instead, use a MutableAccount in all cases an EVMAccount would have been used. This also tends to reduce a level of layering in many places. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: garyschulte <[email protected]> * Add world context to transaction tracing API (#5836) * Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <[email protected]> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <[email protected]> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <[email protected]> * Rebase on main Signed-off-by: Franklin Delehelle <[email protected]> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <[email protected]> * added test Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * Bonsai based reference test worldstate (#5686) * create a bonsai based reference test worldstate -> getOrCreate in BonsaiWorldStateUpdateAccumulator - do not throw if we discover an empty account in a non-null BonsaiValue<Account> -> add curentStateRoot to t8n -> storageEntriesFrom and streamAccounts implemented in BonsaiWorldStateKeyValueStorage -> add endKey version of streamFromKey * bonsai fix for self-destruct and create2 at the same address and same block Signed-off-by: garyschulte <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Karim TAAM <[email protected]> Signed-off-by: garyschulte <[email protected]> * Don't start BFT mining coordinators until initial sync has completed (#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: garyschulte <[email protected]> * display only peers ready for requets on ethstats (#5880) * display only ready for requets peers in ethstats Signed-off-by: Karim TAAM <[email protected]> * cast to int Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: garyschulte <[email protected]> * [MINOR] test RLP used for encode/decode blob tx should contain to field (#5883) * validate to field on encode/decode for blob tx Signed-off-by: Sally MacFarlane <[email protected]> * revert decode/encode checks - tis done later in tx validation Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * Fix: correctly convert percentage options in TOML configuration file (#5886) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: garyschulte <[email protected]> * EIP7516 - Add BlobBaseFee opcode to Cancun EVM (#5884) Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: garyschulte <[email protected]> * Fix snapsync heal (#5838) Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: garyschulte <[email protected]> * Upgrade besu-native (#5893) Upgrade besu-native to 0.8.2 Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: garyschulte <[email protected]> * Tune G1GC to reduce Besu memory footprint (#5879) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: garyschulte <[email protected]> * Add updated storage to evmtool json trace (#5892) Add the EIP-3155 "storage" option to the standard tracer, with the caveat only updated storage is logged. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: garyschulte <[email protected]> * Update holesky with fixed extraData, genesis time, shanghaiTime (#5890) Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: garyschulte <[email protected]> * [CHANGELOG] removed duplicated line (#5904) * removed duplicated line [skip ci] Signed-off-by: Sally MacFarlane <[email protected]> * fixed spelling on Holesky Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * add 23.7.2 release SHAs and bump to 23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-RC version Signed-off-by: garyschulte <[email protected]> --------- Signed-off-by: Diego López León <[email protected]> Signed-off-by: garyschulte <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Diego López León <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Peter Somogyvari <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: delehef <[email protected]> Co-authored-by: Matt Whitehead <[email protected]> Co-authored-by: Simon Dudley <[email protected]>

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

* Revert "Burn in candidate for 23.7.3 (#5906)" This reverts commit ed9d80e. Signed-off-by: Simon Dudley <[email protected]> * Update holesky with fixed extraData, genesis time, shanghaiTime (#5890) Signed-off-by: Simon Dudley <[email protected]> * 23.7.3-RC2 version bump and 23.7.2 release SHAs Signed-off-by: Simon Dudley <[email protected]> * updated gradle verification metadata (#5870) * removed old artefacts * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> * Add rocksdbjni-8.0.0 gradle verification back in Signed-off-by: Simon Dudley <[email protected]> --------- Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Justin Florentine <[email protected]>

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

Update holesky with fixed extraData, genesis time, shanghaiTime

34b6569

Signed-off-by: Simon Dudley <[email protected]>

siladu requested review from gfukushima and fab-10 September 18, 2023 21:53

changelog

0105d67

Signed-off-by: Simon Dudley <[email protected]>

gfukushima reviewed Sep 18, 2023

View reviewed changes

siladu added the TeamGroot GH issues worked on by Groot Team label Sep 18, 2023

garyschulte reviewed Sep 18, 2023

View reviewed changes

Fix forkId tests

10cdedf

After changing shanghaiTime and removing cancunTime Signed-off-by: Simon Dudley <[email protected]>

siladu commented Sep 19, 2023

View reviewed changes

siladu added 2 commits September 20, 2023 07:26

Make it match eth-clients version

349a850

Signed-off-by: Simon Dudley <[email protected]>

Merge remote-tracking branch 'upstream/main' into holesky-round2

8ce35ce

Signed-off-by: Simon Dudley <[email protected]>

macfarla mentioned this pull request Sep 19, 2023

stricter parsing of genesis JSON #5900

Open

jframe reviewed Sep 19, 2023

View reviewed changes

garyschulte approved these changes Sep 19, 2023

View reviewed changes

Merge branch 'main' into holesky-round2

e68956d

siladu enabled auto-merge (squash) September 19, 2023 23:44

siladu merged commit cedcb5c into hyperledger:main Sep 20, 2023
8 checks passed

siladu deleted the holesky-round2 branch September 20, 2023 00:49

siladu mentioned this pull request Sep 20, 2023

Burn in release of 23.7.3 from main (inclusive of sha eef40bd) #5905

Closed

garyschulte pushed a commit to garyschulte/besu that referenced this pull request Sep 20, 2023

Update holesky with fixed extraData, genesis time, shanghaiTime (hype…

a854491

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

garyschulte pushed a commit to garyschulte/besu that referenced this pull request Sep 20, 2023

Update holesky with fixed extraData, genesis time, shanghaiTime (hype…

fd499a3

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: garyschulte <[email protected]>

siladu added a commit to siladu/besu that referenced this pull request Sep 20, 2023

Update holesky with fixed extraData, genesis time, shanghaiTime (hype…

95eafc2

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

siladu added a commit to siladu/besu that referenced this pull request Sep 20, 2023

Update holesky with fixed extraData, genesis time, shanghaiTime (hype…

a3d6832

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

siladu added a commit to siladu/besu that referenced this pull request Sep 26, 2023

Update holesky with fixed extraData, genesis time, shanghaiTime (hype…

a6a2498

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023

Update holesky with fixed extraData, genesis time, shanghaiTime (hype…

8b2c90b

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

jflo pushed a commit to jflo/besu that referenced this pull request Nov 10, 2023

Update holesky with fixed extraData, genesis time, shanghaiTime (hype…

fb4f14f

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Justin Florentine <[email protected]>

NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023

Update holesky with fixed extraData, genesis time, shanghaiTime (hype…

3e1e5ff

…rledger#5890) Signed-off-by: Simon Dudley <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update holesky with fixed extraData, genesis time, shanghaiTime #5890

Update holesky with fixed extraData, genesis time, shanghaiTime #5890

siladu commented Sep 18, 2023

github-actions bot commented Sep 18, 2023 •

edited by siladu

Loading

gfukushima left a comment

garyschulte left a comment •

edited

Loading

siladu commented Sep 19, 2023 •

edited

Loading

siladu Sep 19, 2023 •

edited

Loading

fab-10 commented Sep 19, 2023

siladu commented Sep 19, 2023

jframe commented Sep 19, 2023 •

edited

Loading

macfarla commented Sep 19, 2023

jframe Sep 19, 2023

siladu Sep 19, 2023 •

edited

Loading

garyschulte left a comment

Update holesky with fixed extraData, genesis time, shanghaiTime #5890

Update holesky with fixed extraData, genesis time, shanghaiTime #5890

Conversation

siladu commented Sep 18, 2023

github-actions bot commented Sep 18, 2023 • edited by siladu Loading

gfukushima left a comment

Choose a reason for hiding this comment

garyschulte left a comment • edited Loading

Choose a reason for hiding this comment

siladu commented Sep 19, 2023 • edited Loading

siladu Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

fab-10 commented Sep 19, 2023

siladu commented Sep 19, 2023

jframe commented Sep 19, 2023 • edited Loading

macfarla commented Sep 19, 2023

jframe Sep 19, 2023

Choose a reason for hiding this comment

siladu Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

garyschulte left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 18, 2023 •

edited by siladu

Loading

garyschulte left a comment •

edited

Loading

siladu commented Sep 19, 2023 •

edited

Loading

siladu Sep 19, 2023 •

edited

Loading

jframe commented Sep 19, 2023 •

edited

Loading

siladu Sep 19, 2023 •

edited

Loading