Don't start BFT mining coordinators until initial sync has completed #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matthew1001
force-pushed
the
bft-wait-for-sync
branch
2 times, most recently
from
5cb8c1d
to
b3adcc1
Compare
Signed-off-by: Matthew Whitehead <[email protected]>
matthew1001
force-pushed
the
bft-wait-for-sync
branch
from
5c6c07d
to
a2bcc2a
Compare
Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
macfarla
approved these changes
Sep 14, 2023
.../main/java/org/hyperledger/besu/consensus/common/bft/blockcreation/BftMiningCoordinator.java
Show resolved
Hide resolved
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Sep 20, 2023
--- Drop Kotti Network support (ETC) (hyperledger#5816) Signed-off-by: Diego López León <[email protected]> fix ForkId if there are no Forks and the starting timestamp is not 0 (hyperledger#5819) Signed-off-by: Stefan <[email protected]> enforce that BlobTransactions have at least one blob (hyperledger#5826) * enforce that BlobTransactions have at least one blob Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Do not create ignorable segments on `revert storage-variables` (hyperledger#5830) * fix the bug that creates the ignorable chain pruner segment, add rocks exception parsing to RocksDBColumnarKeyValueStorage subclasses * parse rocksdb error for unprintable column family id's Signed-off-by: garyschulte <[email protected]> add versioned hashes and number of blobs to toString() (hyperledger#5831) Signed-off-by: Stefan <[email protected]> add parent beacon block root to payload id calculation (hyperledger#5843) Signed-off-by: Stefan <[email protected]> bump version to 23.7.3-SNAPSHOT (hyperledger#5854) Signed-off-by: Daniel Lehrner <[email protected]> set the beacon root address to the correct value (hyperledger#5853) Signed-off-by: Stefan <[email protected]> docs(readme): fix broken link to installation of binaries page (hyperledger#5859) Fixes hyperledger#5858 Signed-off-by: Peter Somogyvari <[email protected]> Update RocksDB version from 8.0.0 to 8.3.2 (hyperledger#5832) Signed-off-by: Ameziane H <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> use non-deprecated authenticate methods (hyperledger#5852) Signed-off-by: Sally MacFarlane <[email protected]> move to Hyperledger shared runners for current github actions (hyperledger#5860) Signed-off-by: garyschulte <[email protected]> Add range tracing with worldstate (hyperledger#5844) Implement a method to trace a range of blocks and have access to the worldstate before and after the tracing Signed-off-by: Karim TAAM <[email protected]> Layered txpool by default and txpool options hoverhaul (hyperledger#5772) Signed-off-by: Fabio Di Fabio <[email protected]> Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions (hyperledger#5857) Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions Signed-off-by: Ameziane H <[email protected]> updated gradle verification metadata (hyperledger#5870) * removed old artefacts [skip ci] * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> [4844] Add encodingContext to TransactionEncoder and TransactionDecoder (hyperledger#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Stefan <[email protected]> payload attributes: fix wrong warning and fail if beacon root is available before cancun (hyperledger#5872) Signed-off-by: Stefan <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Merge MutableAccount and EVMAccount (hyperledger#5863) Merge MutableAccount and EVMAccount functionalities by removing EVMAccount, all calls to getMutable, and the WrappedEVMAccount that was wrapping non-EVMAccounts in a mutable fashion. Instead, use a MutableAccount in all cases an EVMAccount would have been used. This also tends to reduce a level of layering in many places. Signed-off-by: Danno Ferrin <[email protected]> Add world context to transaction tracing API (hyperledger#5836) * Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <[email protected]> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <[email protected]> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <[email protected]> * Rebase on main Signed-off-by: Franklin Delehelle <[email protected]> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <[email protected]> * added test Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Bonsai based reference test worldstate (hyperledger#5686) * create a bonsai based reference test worldstate -> getOrCreate in BonsaiWorldStateUpdateAccumulator - do not throw if we discover an empty account in a non-null BonsaiValue<Account> -> add curentStateRoot to t8n -> storageEntriesFrom and streamAccounts implemented in BonsaiWorldStateKeyValueStorage -> add endKey version of streamFromKey * bonsai fix for self-destruct and create2 at the same address and same block Signed-off-by: garyschulte <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Karim TAAM <[email protected]> Don't start BFT mining coordinators until initial sync has completed (hyperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> display only peers ready for requets on ethstats (hyperledger#5880) * display only ready for requets peers in ethstats Signed-off-by: Karim TAAM <[email protected]> * cast to int Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> [MINOR] test RLP used for encode/decode blob tx should contain to field (hyperledger#5883) * validate to field on encode/decode for blob tx Signed-off-by: Sally MacFarlane <[email protected]> * revert decode/encode checks - tis done later in tx validation Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Fix: correctly convert percentage options in TOML configuration file (hyperledger#5886) Signed-off-by: Fabio Di Fabio <[email protected]> EIP7516 - Add BlobBaseFee opcode to Cancun EVM (hyperledger#5884) Signed-off-by: Gabriel-Trintinalia <[email protected]> Fix snapsync heal (hyperledger#5838) Signed-off-by: Karim TAAM <[email protected]> Upgrade besu-native (hyperledger#5893) Upgrade besu-native to 0.8.2 Signed-off-by: Danno Ferrin <[email protected]> Tune G1GC to reduce Besu memory footprint (hyperledger#5879) Signed-off-by: Fabio Di Fabio <[email protected]> Add updated storage to evmtool json trace (hyperledger#5892) Add the EIP-3155 "storage" option to the standard tracer, with the caveat only updated storage is logged. Signed-off-by: Danno Ferrin <[email protected]> Update holesky with fixed extraData, genesis time, shanghaiTime (hyperledger#5890) Signed-off-by: Simon Dudley <[email protected]> [CHANGELOG] removed duplicated line (hyperledger#5904) * removed duplicated line [skip ci] Signed-off-by: Sally MacFarlane <[email protected]> * fixed spelling on Holesky Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 20, 2023
…yperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 20, 2023
…yperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: garyschulte <[email protected]>
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Sep 20, 2023
…yperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]>
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Sep 20, 2023
…yperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]>
siladu
added a commit
that referenced
this pull request
Sep 20, 2023
burn-in candidate for 23.7.3 from main sha 6dc10a9..eef40bd https://github.com/hyperledger/besu/compare/6dc10a9..eef40bd --- * Drop Kotti Network support (ETC) (#5816) Signed-off-by: Diego López León <[email protected]> Signed-off-by: garyschulte <[email protected]> * fix ForkId if there are no Forks and the starting timestamp is not 0 (#5819) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * enforce that BlobTransactions have at least one blob (#5826) * enforce that BlobTransactions have at least one blob Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: garyschulte <[email protected]> * Do not create ignorable segments on `revert storage-variables` (#5830) * fix the bug that creates the ignorable chain pruner segment, add rocks exception parsing to RocksDBColumnarKeyValueStorage subclasses * parse rocksdb error for unprintable column family id's Signed-off-by: garyschulte <[email protected]> * add versioned hashes and number of blobs to toString() (#5831) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * add parent beacon block root to payload id calculation (#5843) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * bump version to 23.7.3-SNAPSHOT (#5854) Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: garyschulte <[email protected]> * set the beacon root address to the correct value (#5853) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * docs(readme): fix broken link to installation of binaries page (#5859) Fixes #5858 Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: garyschulte <[email protected]> * Update RocksDB version from 8.0.0 to 8.3.2 (#5832) Signed-off-by: Ameziane H <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * use non-deprecated authenticate methods (#5852) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * move to Hyperledger shared runners for current github actions (#5860) Signed-off-by: garyschulte <[email protected]> * Add range tracing with worldstate (#5844) Implement a method to trace a range of blocks and have access to the worldstate before and after the tracing Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: garyschulte <[email protected]> * Layered txpool by default and txpool options hoverhaul (#5772) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: garyschulte <[email protected]> * Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions (#5857) Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions Signed-off-by: Ameziane H <[email protected]> Signed-off-by: garyschulte <[email protected]> * updated gradle verification metadata (#5870) * removed old artefacts [skip ci] * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * [4844] Add encodingContext to TransactionEncoder and TransactionDecoder (#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * #5868: fix beacon root address and modulus for devnet 9 (#5871) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * payload attributes: fix wrong warning and fail if beacon root is available before cancun (#5872) Signed-off-by: Stefan <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * Merge MutableAccount and EVMAccount (#5863) Merge MutableAccount and EVMAccount functionalities by removing EVMAccount, all calls to getMutable, and the WrappedEVMAccount that was wrapping non-EVMAccounts in a mutable fashion. Instead, use a MutableAccount in all cases an EVMAccount would have been used. This also tends to reduce a level of layering in many places. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: garyschulte <[email protected]> * Add world context to transaction tracing API (#5836) * Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <[email protected]> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <[email protected]> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <[email protected]> * Rebase on main Signed-off-by: Franklin Delehelle <[email protected]> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <[email protected]> * added test Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * Bonsai based reference test worldstate (#5686) * create a bonsai based reference test worldstate -> getOrCreate in BonsaiWorldStateUpdateAccumulator - do not throw if we discover an empty account in a non-null BonsaiValue<Account> -> add curentStateRoot to t8n -> storageEntriesFrom and streamAccounts implemented in BonsaiWorldStateKeyValueStorage -> add endKey version of streamFromKey * bonsai fix for self-destruct and create2 at the same address and same block Signed-off-by: garyschulte <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Karim TAAM <[email protected]> Signed-off-by: garyschulte <[email protected]> * Don't start BFT mining coordinators until initial sync has completed (#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: garyschulte <[email protected]> * display only peers ready for requets on ethstats (#5880) * display only ready for requets peers in ethstats Signed-off-by: Karim TAAM <[email protected]> * cast to int Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: garyschulte <[email protected]> * [MINOR] test RLP used for encode/decode blob tx should contain to field (#5883) * validate to field on encode/decode for blob tx Signed-off-by: Sally MacFarlane <[email protected]> * revert decode/encode checks - tis done later in tx validation Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * Fix: correctly convert percentage options in TOML configuration file (#5886) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: garyschulte <[email protected]> * EIP7516 - Add BlobBaseFee opcode to Cancun EVM (#5884) Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: garyschulte <[email protected]> * Fix snapsync heal (#5838) Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: garyschulte <[email protected]> * Upgrade besu-native (#5893) Upgrade besu-native to 0.8.2 Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: garyschulte <[email protected]> * Tune G1GC to reduce Besu memory footprint (#5879) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: garyschulte <[email protected]> * Add updated storage to evmtool json trace (#5892) Add the EIP-3155 "storage" option to the standard tracer, with the caveat only updated storage is logged. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: garyschulte <[email protected]> * Update holesky with fixed extraData, genesis time, shanghaiTime (#5890) Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: garyschulte <[email protected]> * [CHANGELOG] removed duplicated line (#5904) * removed duplicated line [skip ci] Signed-off-by: Sally MacFarlane <[email protected]> * fixed spelling on Holesky Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * add 23.7.2 release SHAs and bump to 23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-RC version Signed-off-by: garyschulte <[email protected]> --------- Signed-off-by: Diego López León <[email protected]> Signed-off-by: garyschulte <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Diego López León <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Peter Somogyvari <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: delehef <[email protected]> Co-authored-by: Matt Whitehead <[email protected]> Co-authored-by: Simon Dudley <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…yperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
…yperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR is a suggested approach to resolving the NPE described in issue #5856 whereby a QBFT block expiry timer causes a null pointer if the QBFT node is still syncing with the rest of the chain with
--sync-mode=FASTor--sync-mode=X_SNAPI have made the fix specific to BFT mining coordinators so that the behaviour of other consensus mining algorithms is unaffected by the change. I tested a lower-level fix to just for
nullinTransactionPool.selectTransactions()and that does indeed stop the NPE and allow the node to complete syncing successfully. However I have left the check out of this PR because it feels more appropriate to avoid any reason for trying to select transactions for a BFT miner that hasn't sync'd yet.I've noted that while this prevents the NPE for
--sync-mode=X_SNAPand the sync appears to complete successfully, the node does not participate in BFT block validation or proposals. I think that's a separate issue, and I assume it hasn't worked before since the NPE would have been hit. I suspect a new issue should be opened for that to be looked at separately but I'll wait for the conclusion of this PR.Fixed Issue(s)
Fixes #5856