Add documentation for snapsync-bft-enabled option #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhanu Pulluri <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thanks for the contribution! Since this option only applies to private networks (IBFT 2.0 and QBFT networks), can you move this documentation to the private networks command line options reference page?
Signed-off-by: Bhanu Pulluri <[email protected]>
macfarla
reviewed
Nov 27, 2024
| @@ -922,6 +922,48 @@ privacy-url="http://127.0.0.1:8888" | |||
|
|
|||
| The URL on which the [Tessera node](../../tutorials/privacy/index.md#3-create-tessera-configuration-files) is running. | |||
|
|
|||
| ### `snapsync-bft-enabled` | |||
There was a problem hiding this comment.
do we want to add the version of besu that this becomes available eg (since 24.12.0)
|
ok per comments on the besu PR this option is being removed altogether |
macfarla
requested changes
Nov 28, 2024
| Use `--Xsnapsync-bft-enabled` with `--sync-mode=SNAP` to enable snap sync in QBFT and IBFT 2.0 private networks. | ||
|
|
||
| ::: | ||
|
|
There was a problem hiding this comment.
so if the option is being removed altogether, we want this change (deletion)
| Enables or disables snapsync in IBFT 2.0 and QBFT private networks. The default is `false`. | ||
|
|
||
| Use `--snapsync-bft-enabled` with `--sync-mode=SNAP` to enable snapsync in QBFT and IBFT 2.0 private networks. | ||
|
|
There was a problem hiding this comment.
so if the option is being removed altogether, we DON'T want this change (addition)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue(s) fixed
#7924
Fixes #