Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary/experimental flag --Xsnapsync-bft-enabled #7924

Open
matthew1001 opened this issue Nov 26, 2024 · 2 comments
Open

Remove temporary/experimental flag --Xsnapsync-bft-enabled #7924

matthew1001 opened this issue Nov 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@matthew1001
Copy link
Contributor

matthew1001 commented Nov 26, 2024

Our testing shows that this is stable and hasn't shown any issues since being introduced as an experimental option.

It can be moved out of the experimental options have the X prefix dropped, and be added to the Besu docs. removed entirely

@matthew1001 matthew1001 added the bug Something isn't working label Nov 26, 2024
@pullurib
Copy link
Contributor

I can take care of this, please assign

@matthew1001
Copy link
Contributor Author

matthew1001 commented Nov 27, 2024

@pullurib I think I should have named this "Remove the experimental --Xsnapsync-bft-enabled flag. We added it as a way to turn BFT snap sync on and off while we tested the function. Now that we're happy it works, I think we want to remove the flag entirely, and then I think we can just remove the BesuCommand.validateConsensusSyncCompatibilityOptions() function as well.

@matthew1001 matthew1001 changed the title Make experimental flag --Xsnapsync-bft-enabled non-experimental Remove temporary/experimental flag --Xsnapsync-bft-enabled Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants