Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): several fixes for js wrapper #131

Merged
merged 16 commits into from
Mar 13, 2023
Merged

fix(js): several fixes for js wrapper #131

merged 16 commits into from
Mar 13, 2023

Conversation

TimoGlastra
Copy link
Member

@TimoGlastra TimoGlastra changed the title feat(javascript): add setDefautlLogger fix(js): several fixes for js wrapper Mar 6, 2023
genaris
genaris reviewed Mar 6, 2023
View reviewed changes
wrappers/javascript/anoncreds-shared/src/Anoncreds.ts
@@ -39,6 +39,7 @@ export interface Anoncreds {
version(): string

getCurrentError(): string
setDefaultLogger(): void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way in these new components to set a custom logger like we did in indy-sdk to log in our language of choice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never implemented that method for React Native, only Node.JS. I think it should be possible, but not sure how to do it currently. We thought defaultLogger would be enough for now and we can add the custom logger later on

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do that recently but I remember that in NodeJS I needed to set environment variable RUST_LOG=anoncreds:loglevel in addition to a call to set_default_logger. In React Native this can also be achieved so Rust traces can be seen in Android logcat or something?

@berendsliedrecht
Copy link
Contributor

closes #125

@TimoGlastra TimoGlastra linked an issue Mar 7, 2023 that may be closed by this pull request
Test AnonCreds in React Native and fix bugs that are encountered #132
Closed
@berendsliedrecht berendsliedrecht mentioned this pull request Mar 10, 2023
Merged
@TimoGlastra TimoGlastra marked this pull request as ready for review March 11, 2023 16:57
@TimoGlastra
Copy link
Member Author

Tested in React Native

@TimoGlastra TimoGlastra linked an issue Mar 11, 2023 that may be closed by this pull request
[JS] JSI asBool is not available in RN 0.66 #141
Closed
@berendsliedrecht
Copy link
Contributor

Since we can just use getBool, this closes #141

@TimoGlastra TimoGlastra merged commit acd0b8b into hyperledger:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genaris genaris genaris left review comments

@berendsliedrecht berendsliedrecht berendsliedrecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JS] JSI asBool is not available in RN 0.66 Test AnonCreds in React Native and fix bugs that are encountered
3 participants
@TimoGlastra @berendsliedrecht @genaris